Skip to content

Conversation

@1RyanK
Copy link
Collaborator

@1RyanK 1RyanK commented Dec 12, 2025

As seen in the issue, performance dropped again. Investigating what happened in this PR.

Check branch performance here and compare to main performance here.

Closes #5150: Try to fix bigint performance again

@1RyanK 1RyanK force-pushed the 5150-Try_to_fix_bigint_performance_again branch from 4203fbf to 17fc7be Compare December 12, 2025 15:39
@1RyanK 1RyanK marked this pull request as ready for review December 12, 2025 15:48
@1RyanK 1RyanK force-pushed the 5150-Try_to_fix_bigint_performance_again branch 4 times, most recently from 1ae145c to 8f7c20f Compare December 17, 2025 11:50
@1RyanK 1RyanK force-pushed the 5150-Try_to_fix_bigint_performance_again branch from 295f9b6 to b8a86e5 Compare December 17, 2025 13:59
Copy link
Contributor

@drculhane drculhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@1RyanK 1RyanK force-pushed the 5150-Try_to_fix_bigint_performance_again branch from b8a86e5 to 2fbcfb9 Compare January 13, 2026 17:17
Copy link
Contributor

@ajpotts ajpotts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@ajpotts ajpotts enabled auto-merge January 13, 2026 18:58
@ajpotts ajpotts added this pull request to the merge queue Jan 13, 2026
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@168089e). Learn more about missing BASE report.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #5151   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         4           
  Lines           ?        63           
  Branches        ?         0           
========================================
  Hits            ?        63           
  Misses          ?         0           
  Partials        ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Merged via the queue into Bears-R-Us:main with commit d780663 Jan 13, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Try to fix bigint performance again

4 participants