Skip to content

Update bruno properties from release Bruno-2026.3.5#72

Merged
N6REJ merged 1 commit intomainfrom
update-bruno-Bruno-2026.3.5
Mar 5, 2026
Merged

Update bruno properties from release Bruno-2026.3.5#72
N6REJ merged 1 commit intomainfrom
update-bruno-Bruno-2026.3.5

Conversation

@N6REJ
Copy link
Collaborator

@N6REJ N6REJ commented Mar 5, 2026

🤖 Automated Module Properties Update

This PR updates the bruno.properties file with new versions from release Bruno-2026.3.5.

Changes:

  • Extracted assets starting with bruno (.7z, .exe, or .zip files)
  • Added version entries with download URLs
  • Maintained semver ordering (newest first)

Release URL: https://github.com/Bearsampp/modules-untouched/releases/tag/Bruno-2026.3.5

Next Steps:

  1. ⏳ Link validation will run automatically
  2. ✅ Once validation passes, this PR will auto-merge
  3. ❌ If validation fails, please review and fix invalid URLs

Auto-generated from release Bruno-2026.3.5
@qodo-code-review
Copy link

Review Summary by Qodo

Add Bruno 3.1.4 release to module properties

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Add Bruno version 3.1.4 to module properties
• Update module tracking from mysql to bruno
• Maintain semver ordering with newest version first
Diagram
flowchart LR
  A["Bruno Release 3.1.4"] -- "Extract asset" --> B["bruno_3.1.4_x64_win.zip"]
  B -- "Add to properties" --> C["modules/bruno.properties"]
  D["module_name.txt"] -- "Update tracking" --> E["bruno"]
Loading

Grey Divider

File Changes

1. module_name.txt ⚙️ Configuration changes +1/-1

Update module name tracking

• Changed module tracking identifier from mysql to bruno

module_name.txt


2. modules/bruno.properties ✨ Enhancement +1/-0

Add Bruno 3.1.4 version entry

• Added new version entry 3.1.4 with download URL from Bruno-2026.3.5 release
• Positioned at top of file maintaining semver ordering (newest first)
• URL points to bruno_3.1.4_x64_win.zip asset

modules/bruno.properties


Grey Divider

Qodo Logo

@qodo-code-review
Copy link

qodo-code-review bot commented Mar 5, 2026

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider


Remediation recommended

1. Scratch file committed 🐞 Bug ⛯ Reliability
Description
module_name.txt appears to be a workflow scratch artifact used only to pass data between steps,
but it is being committed in the PR. This adds noise to every automated PR and can create
unnecessary merge conflicts when multiple module-update PRs are open concurrently (different modules
will still conflict on this shared file).
Code

module_name.txt[1]

+bruno
Evidence
The update workflow explicitly creates module_name.txt to pass the module name to later steps,
then creates the PR while the file still exists, and only removes it afterwards during cleanup—so it
will be included in the PR commit. This strongly indicates the file is an intermediate artifact
rather than intended repository content.

.github/workflows/update-module-properties.yml[56-71]
.github/workflows/update-module-properties.yml[602-655]
.github/workflows/update-module-properties.yml[669-675]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`module_name.txt` is created as an intermediate workflow artifact but is being committed into automated PRs. This creates unnecessary diffs and can cause avoidable merge conflicts when multiple module update PRs exist at the same time.

## Issue Context
The workflow writes `module_name.txt` for cross-step communication, then creates the PR while the file still exists; cleanup runs only after PR creation.

## Fix Focus Areas
- .github/workflows/update-module-properties.yml[56-71]
- .github/workflows/update-module-properties.yml[602-655]
- .github/workflows/update-module-properties.yml[669-675]
- .gitignore[1-30]

## Implementation notes (pick one)
1) **Preferred**: stop using `module_name.txt` by writing the module name to `$GITHUB_OUTPUT` directly from the Python step (or via a dedicated step output), so there is no file to commit.
2) Configure `peter-evans/create-pull-request` with `add-paths: modules/${{ steps.module_info.outputs.module_name }}.properties` so only the properties file is committed.
3) As a safety net, add `module_name.txt` to `.gitignore` and ensure it is deleted (or never created) before the PR creation step.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@N6REJ N6REJ merged commit 9121f22 into main Mar 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant