Skip to content

Commit 2dc8dda

Browse files
committed
Add test options for slurm
1 parent f3f93bb commit 2dc8dda

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

gromacs/qsub.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -367,12 +367,12 @@ def write_script(template):
367367
logger.info("Setting up queuing system script {submitscript!r}...".format(**vars()))
368368
# These substitution rules are documented for the user in the module doc string
369369
qsystem = detect_queuing_system(template)
370-
if qsystem.name == 'Slurm':
370+
if qsystem is not None and (qsystem.name == 'Slurm'):
371371
cbook.edit_txt(template,
372372
[('^ *DEFFNM=','(?<==)(.*)', deffnm),
373373
('^#.*(-J)', '((?<=-J\s))\s*\w+', jobname),
374374
('^#.*(-A|account_no)', '((?<=-A\s)|(?<=account_no\s))\s*\w+', budget),
375-
('^#.*(-t walltime)', '(?<==)(\d+:\d+:\d+)', walltime),
375+
('^#.*(-t)', '(?<=-t\s)(\d+:\d+:\d+)', walltime),
376376
('^ *WALL_HOURS=', '(?<==)(.*)', wall_hours),
377377
('^ *STARTDIR=', '(?<==)(.*)', startdir),
378378
('^ *NPME=', '(?<==)(.*)', npme),

gromacs/tests/test_qsub.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
import gromacs.qsub
55

6-
def test_queuing_systems(known=("Sun Gridengine", "PBS", "LoadLeveler")):
6+
def test_queuing_systems(known=("Sun Gridengine", "PBS", "LoadLeveler", 'Slurm')):
77
assert len(gromacs.qsub.queuing_systems) == len(known)
88
for qs in gromacs.qsub.queuing_systems:
99
assert qs.name in known
@@ -18,7 +18,8 @@ def test_queuing_systems(known=("Sun Gridengine", "PBS", "LoadLeveler")):
1818
@pytest.mark.parametrize("scriptfile,name", [
1919
("foo.sge", "Sun Gridengine"),
2020
("foo.pbs", "PBS"),
21-
("foo.ll", "LoadLeveler")])
21+
("foo.ll", "LoadLeveler"),
22+
("foo.slu", "Slurm")])
2223
def test_detect_queuing_system(scriptfile, name):
2324
qs = gromacs.qsub.detect_queuing_system(scriptfile)
2425
assert qs.name == name

0 commit comments

Comments
 (0)