Skip to content

Commit d68ed9a

Browse files
authored
Merge pull request #118 from Becksteinlab/race-condition
Don't change timeout on pause/unpause
2 parents 07069e1 + 5d7c1e1 commit d68ed9a

File tree

2 files changed

+18
-4
lines changed

2 files changed

+18
-4
lines changed

CHANGELOG.md

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,24 @@ The rules for this file:
1515
* YYYY-MM-DD date format (following ISO 8601)
1616
* accompany each entry with github issue/PR number (Issue #xyz)
1717
-->
18+
## [v0.2.3] - 2025-11-08
19+
### Authors
20+
@ljwoods2
21+
22+
### Changed
23+
24+
### Added
25+
26+
### Fixed
27+
* Removed timeout changes during pause/resume for IMDv2 and IMv3
28+
(Issue #96, PR #118)
29+
30+
### Deprecated
31+
<!-- Soon-to-be removed features -->
32+
33+
### Removed
34+
<!-- Removed features -->
35+
1836

1937
## [v0.2.2] - 2025-07-20
2038
### Authors

imdclient/IMDClient.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -591,7 +591,6 @@ def _parse_imdframe(self):
591591
raise RuntimeError("IMDProducer: Unexpected packet type or length")
592592

593593
def _pause(self):
594-
self._conn.settimeout(0)
595594
logger.debug(
596595
"IMDProducer: Pausing simulation because buffer is almost full"
597596
)
@@ -607,7 +606,6 @@ def _pause(self):
607606
# from the socket
608607

609608
def _unpause(self):
610-
self._conn.settimeout(self._timeout)
611609
logger.debug("IMDProducer: Unpausing simulation, buffer has space")
612610
unpause = create_header_bytes(IMDHeaderType.IMD_PAUSE, 0)
613611
try:
@@ -658,7 +656,6 @@ def __init__(
658656
self._forces = bytearray(xvf_bytes)
659657

660658
def _pause(self):
661-
self._conn.settimeout(0)
662659
logger.debug(
663660
"IMDProducer: Pausing simulation because buffer is almost full"
664661
)
@@ -674,7 +671,6 @@ def _pause(self):
674671
# from the socket
675672

676673
def _unpause(self):
677-
self._conn.settimeout(self._timeout)
678674
logger.debug("IMDProducer: Unpausing simulation, buffer has space")
679675
unpause = create_header_bytes(IMDHeaderType.IMD_RESUME, 0)
680676
try:

0 commit comments

Comments
 (0)