Skip to content

Commit 7196755

Browse files
authored
Merge pull request #18 from Becksteinlab/develop
Remove NAMD
2 parents c15e014 + 29f59eb commit 7196755

File tree

12 files changed

+4
-226
lines changed

12 files changed

+4
-226
lines changed

.github/workflows/ci.yaml

Lines changed: 0 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -89,44 +89,6 @@ jobs:
8989
build-args: |
9090
LMP_OPTS=${{ matrix.LMP_OPTS }}
9191
92-
build-namd-image:
93-
runs-on: ubuntu-latest
94-
strategy:
95-
matrix:
96-
arch: [amd64]
97-
tag_suffix: ["GPU"]
98-
# Sets the permissions granted to the `GITHUB_TOKEN` for the actions in this job.
99-
permissions:
100-
contents: read
101-
102-
steps:
103-
- name: Free disk space
104-
uses: jlumbroso/free-disk-space@main
105-
with:
106-
android: true
107-
dotnet: true
108-
haskell: true
109-
large-packages: true
110-
swap-storage: true
111-
112-
- name: Checkout repository
113-
uses: actions/checkout@v4
114-
115-
- name: Convert compiler options to simple tag suffix
116-
id: NAMD_OPTS
117-
run: |
118-
if [[ "${{ matrix.tag_suffix }}" == "GPU" ]]; then
119-
echo NAMD_OPTS="--with-cuda" >> $GITHUB_ENV
120-
fi
121-
122-
- name: Build and push Docker image
123-
uses: docker/build-push-action@v5
124-
with:
125-
context: ./docker/namd
126-
push: false
127-
build-args: |
128-
NAMD_OPTS=${{ matrix.NAMD_OPTS }}
129-
13092
build-common-image:
13193
runs-on: ubuntu-latest
13294
strategy:
@@ -154,12 +116,10 @@ jobs:
154116
id: option
155117
run: |
156118
if [ "${{ matrix.build }}" == "Common-CPU" ]; then
157-
echo NAMD_OPTS= >> $GITHUB_ENV
158119
echo GMX_OPTS= >> $GITHUB_ENV
159120
echo LMP_OPTS= >> $GITHUB_ENV
160121
echo DOCKERFILE="Dockerfile.cpu" >> $GITHUB_ENV
161122
else
162-
echo NAMD_OPTS="--with-cuda" >> $GITHUB_ENV
163123
echo GMX_OPTS="-DGMX_GPU=CUDA" >> $GITHUB_ENV
164124
echo LMP_OPTS="-DPKG_GPU=on -DGPU_API=cuda" >> $GITHUB_ENV
165125
echo DOCKERFILE="Dockerfile.gpu" >> $GITHUB_ENV
@@ -172,6 +132,5 @@ jobs:
172132
push: false
173133
file: ./docker/common/${{ env.DOCKERFILE }}
174134
build-args: |
175-
NAMD_OPTS=${{ env.NAMD_OPTS }}
176135
GMX_OPTS=${{ env.GMX_OPTS }}
177136
LMP_OPTS=${{ env.LMP_OPTS }}

.github/workflows/deploy_docker.yaml

Lines changed: 0 additions & 59 deletions
Original file line numberDiff line numberDiff line change
@@ -130,62 +130,6 @@ jobs:
130130
labels: ${{ steps.meta.outputs.labels }}
131131
build-args: |
132132
LMP_OPTS=${{ env.LMP_OPTS }}
133-
134-
build-and-push-namd-image:
135-
runs-on: ubuntu-latest
136-
strategy:
137-
matrix:
138-
arch: [amd64]
139-
tag_suffix: ["GPU"]
140-
# Sets the permissions granted to the `GITHUB_TOKEN` for the actions in this job.
141-
permissions:
142-
contents: read
143-
packages: write
144-
#
145-
steps:
146-
- name: Free disk space
147-
uses: jlumbroso/free-disk-space@main
148-
with:
149-
android: true
150-
dotnet: true
151-
haskell: true
152-
large-packages: true
153-
swap-storage: true
154-
155-
- name: Checkout repository
156-
uses: actions/checkout@v4
157-
# Uses the `docker/login-action` action to log in to the Container registry registry using the account and password that will publish the packages. Once published, the packages are scoped to the account defined here.
158-
- name: Log in to the Container registry
159-
uses: docker/login-action@v3
160-
with:
161-
registry: ${{ env.REGISTRY }}
162-
username: ${{ github.actor }}
163-
password: ${{ secrets.GITHUB_TOKEN }}
164-
165-
- name: Convert compiler options to simple tag suffix
166-
id: tag_suffix
167-
run: |
168-
if [[ "${{ matrix.tag_suffix }}" == "GPU" ]]; then
169-
echo NAMD_OPTS="--with-cuda" >> $GITHUB_ENV
170-
fi
171-
# This step uses [docker/metadata-action](https://github.com/docker/metadata-action#about) to extract tags and labels that will be applied to the specified image. The `id` "meta" allows the output of this step to be referenced in a subsequent step. The `images` value provides the base name for the tags and labels.
172-
- name: Extract metadata (tags, labels) for Docker
173-
id: meta
174-
uses: docker/metadata-action@v5
175-
with:
176-
images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
177-
# This step uses the `docker/build-push-action` action to build the image, based on your repository's `Dockerfile`. If the build succeeds, it pushes the image to GitHub Packages.
178-
# It uses the `context` parameter to define the build's context as the set of files located in the specified path. For more information, see "[Usage](https://github.com/docker/build-push-action#usage)" in the README of the `docker/build-push-action` repository.
179-
# It uses the `tags` and `labels` parameters to tag and label the image with the output from the "meta" step.
180-
- name: Build and push Docker image
181-
uses: docker/build-push-action@v5
182-
with:
183-
context: ./docker/namd
184-
push: true
185-
tags: ${{ steps.meta.outputs.tags }}-NAMD-${{ env.tag_suffix }}
186-
labels: ${{ steps.meta.outputs.labels }}
187-
build-args: |
188-
NAMD_OPTS=${{ env.NAMD_OPTS }}
189133
190134
build-common-image:
191135
runs-on: ubuntu-latest
@@ -222,12 +166,10 @@ jobs:
222166
id: option
223167
run: |
224168
if [ "${{ matrix.build }}" == "Common-CPU" ]; then
225-
echo NAMD_OPTS= >> $GITHUB_ENV
226169
echo GMX_OPTS= >> $GITHUB_ENV
227170
echo LMP_OPTS= >> $GITHUB_ENV
228171
echo DOCKERFILE="Dockerfile.cpu" >> $GITHUB_ENV
229172
else
230-
echo NAMD_OPTS="--with-cuda" >> $GITHUB_ENV
231173
echo GMX_OPTS="-DGMX_GPU=CUDA" >> $GITHUB_ENV
232174
echo LMP_OPTS="-DPKG_GPU=on -DGPU_API=cuda" >> $GITHUB_ENV
233175
echo DOCKERFILE="Dockerfile.gpu" >> $GITHUB_ENV
@@ -248,6 +190,5 @@ jobs:
248190
tags: ${{ steps.meta.outputs.tags }}-${{ matrix.build }}
249191
labels: ${{ steps.meta.outputs.labels }}
250192
build-args: |
251-
NAMD_OPTS=${{ env.NAMD_OPTS }}
252193
GMX_OPTS=${{ env.GMX_OPTS }}
253194
LMP_OPTS=${{ env.LMP_OPTS }}

docker/common/Dockerfile.cpu

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,11 @@ FROM condaforge/linux-anvil-cuda:11.8 AS build
33

44
ARG LMP_OPTS=""
55
ARG GMX_OPTS=""
6-
ARG NAMD_OPTS=""
76

87
COPY . .
98
RUN source /opt/conda/etc/profile.d/conda.sh && conda env create --file env.yaml
109
RUN source /opt/conda/etc/profile.d/conda.sh && conda activate env && ./install_lammps.sh "$LMP_OPTS"
1110
RUN source /opt/conda/etc/profile.d/conda.sh && conda activate env && ./install_gromacs.sh "$GMX_OPTS"
12-
RUN source /opt/conda/etc/profile.d/conda.sh && conda activate env && ./install_namd.sh "$NAMD_OPTS"
1311

1412
# Delete the heavy environment but keep conda binaries
1513
RUN source /opt/conda/etc/profile.d/conda.sh && conda remove -n env --all -y
@@ -34,8 +32,6 @@ RUN ln -s /opt/gromacs_build/bin/gmx /bin/gmx
3432
COPY --from=build /opt/lammps_build /opt/lammps_build
3533
RUN ln -s /opt/lammps_build/bin/lmp /bin/lmp
3634

37-
COPY --from=build /opt/namd-build /opt/namd-build
38-
RUN ln -s /opt/namd-build/namd3 /bin/namd3
3935

4036
ENTRYPOINT [ "/opt/conda/bin/tini", "--", "/opt/docker/bin/entrypoint" ]
4137
CMD [ "/bin/bash" ]

docker/common/Dockerfile.gpu

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,11 @@ FROM condaforge/linux-anvil-cuda:11.8 AS build
33

44
ARG LMP_OPTS=""
55
ARG GMX_OPTS=""
6-
ARG NAMD_OPTS=""
76

87
COPY . .
98
RUN source /opt/conda/etc/profile.d/conda.sh && conda env create --file env.yaml
109
RUN source /opt/conda/etc/profile.d/conda.sh && conda activate env && ./install_lammps.sh "$LMP_OPTS"
1110
RUN source /opt/conda/etc/profile.d/conda.sh && conda activate env && ./install_gromacs.sh "$GMX_OPTS"
12-
RUN source /opt/conda/etc/profile.d/conda.sh && conda activate env && ./install_namd.sh "$NAMD_OPTS"
1311

1412
# Delete the heavy environment but keep conda binaries
1513
RUN source /opt/conda/etc/profile.d/conda.sh && conda remove -n env --all -y
@@ -34,8 +32,5 @@ RUN ln -s /opt/gromacs_build/bin/gmx /bin/gmx
3432
COPY --from=build /opt/lammps_build /opt/lammps_build
3533
RUN ln -s /opt/lammps_build/bin/lmp /bin/lmp
3634

37-
COPY --from=build /opt/namd-build /opt/namd-build
38-
RUN ln -s /opt/namd-build/namd3 /bin/namd3
39-
4035
ENTRYPOINT [ "/opt/conda/bin/tini", "--", "/opt/docker/bin/entrypoint" ]
4136
CMD [ "/bin/bash" ]

docker/common/env.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,5 @@ dependencies:
1919
- curl
2020
- openmp
2121
- openmpi
22+
- libacl
2223

docker/common/install_namd.sh

Lines changed: 0 additions & 25 deletions
This file was deleted.

docker/gromacs/env.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,5 @@ dependencies:
1919
- curl
2020
- openmp
2121
- openmpi
22+
- libacl
2223

docker/gromacs/install_gromacs.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
#!/bin/bash
22
export PATH="${PATH}:${CUDA_HOME}/bin"
33
cd /opt/
4+
45
export HOME_DIR=${PWD}
56
export NPROC=$(nproc)
67
export LIBRARY_PATH=${CONDA_PREFIX}/lib
78
export LD_LIBRARY_PATH=${CONDA_PREFIX}/lib
89

10+
911
git clone https://github.com/hcho38/gromacs.git
1012
cd gromacs
1113
git checkout imd-v3

docker/namd/Dockerfile

Lines changed: 0 additions & 31 deletions
This file was deleted.

docker/namd/env.yaml

Lines changed: 0 additions & 22 deletions
This file was deleted.

0 commit comments

Comments
 (0)