Skip to content

Commit 7acff3e

Browse files
authored
Merge pull request #21 from Becksteinlab/develop
Workshop dry run prep
2 parents 254a6a8 + ede73dc commit 7acff3e

File tree

6 files changed

+35
-35
lines changed

6 files changed

+35
-35
lines changed

.github/workflows/ci.yaml

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
strategy:
1414
matrix:
1515
arch: [amd64]
16-
tag_suffix: [GPU, GPU-Thread-MPI, GPU-Node-MPI]
16+
build: [GPU, GPU-Thread-MPI, GPU-Node-MPI]
1717
# Sets the permissions granted to the `GITHUB_TOKEN` for the actions in this job.
1818
permissions:
1919
contents: read
@@ -31,13 +31,13 @@ jobs:
3131
uses: actions/checkout@v4
3232

3333
- name: Convert compiler options to simple tag suffix
34-
id: GMX_OPTS
34+
id: option
3535
run: |
36-
if [[ "${{ matrix.tag_suffix }}" == "GPU-Thread-MPI" ]]; then
36+
if [ "${{ matrix.build }}" == "GPU-Thread-MPI" ]; then
3737
echo GMX_OPTS="-DGMX_GPU=CUDA -DGMX_THREAD_MPI=ON" >> $GITHUB_ENV
38-
elif [[ "${{ matrix.tag_suffix }}" == "GPU-Node-MPI" ]]; then
38+
elif [ "${{ matrix.build }}" == "GPU-Node-MPI" ]; then
3939
echo GMX_OPTS="-DGMX_GPU=CUDA -DGMX_MPI=ON" >> $GITHUB_ENV
40-
elif [[ "${{ matrix.tag_suffix }}" == "GPU" ]]; then
40+
elif [ "${{ matrix.build }}" == "GPU" ]; then
4141
echo GMX_OPTS="-DGMX_GPU=CUDA -DGMX_MPI=OFF" >> $GITHUB_ENV
4242
fi
4343
@@ -47,14 +47,14 @@ jobs:
4747
context: ./docker/gromacs
4848
push: false
4949
build-args:
50-
GMX_OPTS=${{ matrix.GMX_OPTS }}
50+
GMX_OPTS="${{ env.GMX_OPTS }}"
5151

5252
build-lammps-image:
5353
runs-on: ubuntu-latest
5454
strategy:
5555
matrix:
5656
arch: [amd64]
57-
tag_suffix: ["GPU-Node-MPI", "GPU"]
57+
build: ["GPU-Node-MPI", "GPU"]
5858
# Sets the permissions granted to the `GITHUB_TOKEN` for the actions in this job.
5959
permissions:
6060
contents: read
@@ -73,11 +73,11 @@ jobs:
7373
uses: actions/checkout@v4
7474

7575
- name: Convert compiler options to simple tag suffix
76-
id: LMP_OPTS
76+
id: option
7777
run: |
78-
if [[ "${{ matrix.tag_suffix }}" == "GPU-Node-MPI" ]]; then
78+
if [ "${{ matrix.build }}" == "GPU-Node-MPI" ]; then
7979
echo LMP_OPTS="-D PKG_GPU=on -D GPU_API=cuda -D BUILD_MPI=yes" >> $GITHUB_ENV
80-
elif [[ "${{ matrix.tag_suffix }}" == "GPU" ]]; then
80+
elif [ "${{ matrix.build }}" == "GPU" ]; then
8181
echo LMP_OPTS="-D PKG_GPU=on -D GPU_API=cuda -D BUILD_MI=no" >> $GITHUB_ENV
8282
fi
8383
@@ -87,14 +87,14 @@ jobs:
8787
context: ./docker/lammps
8888
push: false
8989
build-args: |
90-
LMP_OPTS=${{ matrix.LMP_OPTS }}
90+
LMP_OPTS="${{ env.LMP_OPTS }}"
9191
9292
build-common-image:
9393
runs-on: ubuntu-latest
9494
strategy:
9595
matrix:
9696
arch: [amd64]
97-
build: ["Common-CPU", "Common-GPU"]
97+
build: ["Common-CPU"] #, "Common-GPU"]
9898

9999
permissions:
100100
contents: read
@@ -132,5 +132,5 @@ jobs:
132132
push: false
133133
file: ./docker/common/${{ env.DOCKERFILE }}
134134
build-args: |
135-
GMX_OPTS=${{ env.GMX_OPTS }}
136-
LMP_OPTS=${{ env.LMP_OPTS }}
135+
GMX_OPTS="${{ env.GMX_OPTS }}"
136+
LMP_OPTS="${{ env.LMP_OPTS }}"

.github/workflows/deploy_docker.yaml

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
strategy:
1919
matrix:
2020
arch: [amd64]
21-
tag_suffix: [GPU, GPU-Thread-MPI, GPU-Node-MPI]
21+
build: [GPU, GPU-Thread-MPI, GPU-Node-MPI]
2222
# Sets the permissions granted to the `GITHUB_TOKEN` for the actions in this job.
2323
permissions:
2424
contents: read
@@ -44,13 +44,13 @@ jobs:
4444
password: ${{ secrets.GITHUB_TOKEN }}
4545

4646
- name: Convert compiler options to simple tag suffix
47-
id: GMX_OPTS
47+
id: option
4848
run: |
49-
if [[ "${{ matrix.tag_suffix }}" == "GPU-Thread-MPI" ]]; then
49+
if [ "${{ matrix.build }}" == "GPU-Thread-MPI" ]; then
5050
echo GMX_OPTS="-DGMX_GPU=CUDA -DGMX_THREAD_MPI=ON" >> $GITHUB_ENV
51-
elif [[ "${{ matrix.tag_suffix }}" == "GPU-Node-MPI" ]]; then
51+
elif [ "${{ matrix.build }}" == "GPU-Node-MPI" ]; then
5252
echo GMX_OPTS="-DGMX_GPU=CUDA -DGMX_MPI=ON" >> $GITHUB_ENV
53-
elif [[ "${{ matrix.tag_suffix }}" == "GPU" ]]; then
53+
elif [ "${{ matrix.build }}" == "GPU" ]; then
5454
echo GMX_OPTS="-DGMX_GPU=CUDA -DGMX_MPI=OFF" >> $GITHUB_ENV
5555
fi
5656
# This step uses [docker/metadata-action](https://github.com/docker/metadata-action#about) to extract tags and labels that will be applied to the specified image. The `id` "meta" allows the output of this step to be referenced in a subsequent step. The `images` value provides the base name for the tags and labels.
@@ -67,17 +67,17 @@ jobs:
6767
with:
6868
context: ./docker/gromacs
6969
push: true
70-
tags: "${{ steps.meta.outputs.tags }}-GROMACS-${{ matrix.tag_suffix }}"
70+
tags: "${{ steps.meta.outputs.tags }}-GROMACS-${{ matrix.build }}"
7171
labels: ${{ steps.meta.outputs.labels }}
7272
build-args: |
73-
GMX_OPTS=${{ env.GMX_OPTS }}
73+
GMX_OPTS="${{ env.GMX_OPTS }}"
7474
7575
build-and-push-lammps-image:
7676
runs-on: ubuntu-latest
7777
strategy:
7878
matrix:
7979
arch: [amd64]
80-
tag_suffix: ["GPU-Node-MPI", "GPU"]
80+
build: ["GPU-Node-MPI", "GPU"]
8181

8282
# Sets the permissions granted to the `GITHUB_TOKEN` for the actions in this job.
8383
permissions:
@@ -105,11 +105,11 @@ jobs:
105105
password: ${{ secrets.GITHUB_TOKEN }}
106106

107107
- name: Convert compiler options to simple tag suffix
108-
id: tag_suffix
108+
id: option
109109
run: |
110-
if [[ "${{ matrix.tag_suffix }}" == "GPU-Node-MPI" ]]; then
110+
if [ "${{ matrix.build }}" == "GPU-Node-MPI" ]; then
111111
echo LMP_OPTS="-D PKG_GPU=on -D GPU_API=cuda -D BUILD_MPI=yes" >> $GITHUB_ENV
112-
elif [[ "${{ matrix.tag_suffix }}" == "GPU" ]]; then
112+
elif [ "${{ matrix.build }}" == "GPU" ]; then
113113
echo LMP_OPTS="-D PKG_GPU=on -D GPU_API=cuda -D BUILD_MI=no" >> $GITHUB_ENV
114114
fi
115115
# This step uses [docker/metadata-action](https://github.com/docker/metadata-action#about) to extract tags and labels that will be applied to the specified image. The `id` "meta" allows the output of this step to be referenced in a subsequent step. The `images` value provides the base name for the tags and labels.
@@ -126,17 +126,17 @@ jobs:
126126
with:
127127
context: ./docker/lammps
128128
push: true
129-
tags: "${{ steps.meta.outputs.tags }}-LAMMPS-${{ matrix.tag_suffix }}"
129+
tags: "${{ steps.meta.outputs.tags }}-LAMMPS-${{ matrix.build }}"
130130
labels: ${{ steps.meta.outputs.labels }}
131131
build-args: |
132-
LMP_OPTS=${{ env.LMP_OPTS }}
132+
LMP_OPTS="${{ env.LMP_OPTS }}"
133133
134134
build-common-image:
135135
runs-on: ubuntu-latest
136136
strategy:
137137
matrix:
138138
arch: [amd64]
139-
build: ["Common-CPU", "Common-GPU"]
139+
build: ["Common-CPU"] #, "Common-GPU"]
140140

141141
permissions:
142142
contents: read
@@ -190,5 +190,5 @@ jobs:
190190
tags: ${{ steps.meta.outputs.tags }}-${{ matrix.build }}
191191
labels: ${{ steps.meta.outputs.labels }}
192192
build-args: |
193-
GMX_OPTS=${{ env.GMX_OPTS }}
194-
LMP_OPTS=${{ env.LMP_OPTS }}
193+
GMX_OPTS="${{ env.GMX_OPTS }}"
194+
LMP_OPTS="${{ env.LMP_OPTS }}"

docker/common/install_gromacs.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export NPROC=$(nproc)
66
export LIBRARY_PATH=${CONDA_PREFIX}/lib
77
export LD_LIBRARY_PATH=${CONDA_PREFIX}/lib
88

9-
git clone https://github.com/hcho38/gromacs.git
9+
git clone https://gitlab.com/ljwoods2/gromacs.git
1010
cd gromacs
1111
git checkout imd-v3
1212
mkdir build

docker/common/install_lammps.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export NPROC=$(nproc)
88
# Setup LAMMPS
99
git clone https://github.com/ljwoods2/lammps.git
1010
cd lammps
11-
git checkout imd-v3
11+
git checkout imd-v3-integration
1212
mkdir build
1313
cd build
1414
cmake ../cmake/ $(echo ${1} | sed 's/"//g') -D PKG_MISC=yes -D PKG_H5MD=yes -DCMAKE_INSTALL_PREFIX=/opt/lammps_build

docker/gromacs/install_gromacs.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export LIBRARY_PATH=${CONDA_PREFIX}/lib
88
export LD_LIBRARY_PATH=${CONDA_PREFIX}/lib
99

1010

11-
git clone https://github.com/hcho38/gromacs.git
11+
git clone https://gitlab.com/ljwoods2/gromacs.git
1212
cd gromacs
1313
git checkout imd-v3
1414
mkdir build

docker/lammps/install_lammps.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ export NPROC=$(nproc)
88
# Setup LAMMPS
99
git clone https://github.com/ljwoods2/lammps.git
1010
cd lammps
11-
git checkout imd-v3
11+
git checkout imd-v3-integration
1212
mkdir build
1313
cd build
1414
cmake ../cmake/ $(echo ${1} | sed 's/"//g') -D PKG_MISC=yes -D PKG_H5MD=yes -DCMAKE_INSTALL_PREFIX=/opt/lammps_build
1515
cmake --build . -j ${NPROC}
16-
make install
16+
make install

0 commit comments

Comments
 (0)