Skip to content

Commit a851399

Browse files
committed
Fixed the venvSlot not being parsed correctly and always being set to 0.
1 parent b606ac3 commit a851399

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

regolith/filter_python.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@ func PythonFilterDefinitionFromObject(id string, obj map[string]interface{}) (*P
3838
return nil, burrito.WrappedErrorf(jsonPropertyTypeError, "script", "string")
3939
}
4040
filter.Script = script
41-
filter.VenvSlot, _ = obj["venvSlot"].(int) // default venvSlot is 0
41+
venvSlot64, _ := obj["venvSlot"].(float64) // default venvSlot is 0.0
42+
filter.VenvSlot = int(venvSlot64)
4243

4344
requirementsObj, ok := obj["requirements"]
4445
if ok {

regolith/filter_remote.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,8 @@ func RemoteFilterDefinitionFromObject(id string, obj map[string]interface{}) (*R
4646
return nil, burrito.WrappedErrorf(jsonPropertyTypeError, "version", "string")
4747
}
4848
result.Version = version
49-
result.VenvSlot, _ = obj["venvSlot"].(int) // default venvSlot is 0
49+
venvSlot64, _ := obj["venvSlot"].(float64) // default venvSlot is 0.0
50+
result.VenvSlot = int(venvSlot64)
5051

5152
return result, nil
5253
}

0 commit comments

Comments
 (0)