Refactor deployment workflow to streamline S3 and CloudFront stack deployments and improve environment name handling

Author: av1choudharyy

.github/workflows/deploy.yml

@@ -32,10 +32,8 @@ jobs:
           name: build-artifact
           path: dist
 
-  setup:
+  deploy_s3:
     runs-on: ubuntu-latest
-    outputs:
-      env_name: ${{ steps.set_env.outputs.env_name }}
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -61,7 +59,6 @@ jobs:
         run: npm install -g aws-cdk
 
       - name: Determine Environment Name
-        id: set_env
         run: |
           if [[ $GITHUB_REF == refs/heads/main ]]; then
             ENV_NAME="production"
@@ -70,32 +67,41 @@ jobs:
           else
             ENV_NAME="dev"
           fi
-          echo "env_name=$ENV_NAME" >> $GITHUB_OUTPUT
+          echo "ENV_NAME=$ENV_NAME" >> $GITHUB_ENV
 
-  deploy_s3:
+      - name: Deploy S3 Stack
+        working-directory: infra
+        run: cdk deploy BeejhoFrontendS3Stack-${{ env.ENV_NAME }} --require-approval never
+
+  deploy_certificate:
     runs-on: ubuntu-latest
-    needs: setup
     steps:
       - name: Checkout
         uses: actions/checkout@v4
 
-      - name: Configure AWS Credentials
-        uses: aws-actions/configure-aws-credentials@v4
+      - name: Setup pnpm
+        uses: pnpm/action-setup@v4
         with:
-          aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
-          aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-          aws-region: ap-south-1
+          version: 9
+          run_install: false
 
-      - name: Deploy S3 Stack
+      - name: Install CDK Dependencies
         working-directory: infra
-        run: cdk deploy BeejhoFrontendS3Stack-${{ needs.setup.outputs.env_name }} --require-approval never
+        run: pnpm install
 
-  deploy_certificate:
-    runs-on: ubuntu-latest
-    needs: setup
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
+      - name: Install AWS CDK
+        run: npm install -g aws-cdk
+
+      - name: Determine Environment Name
+        run: |
+          if [[ $GITHUB_REF == refs/heads/main ]]; then
+            ENV_NAME="production"
+          elif [[ $GITHUB_REF == refs/heads/stage ]]; then
+            ENV_NAME="stg"
+          else
+            ENV_NAME="dev"
+          fi
+          echo "ENV_NAME=$ENV_NAME" >> $GITHUB_ENV
 
       - name: Configure AWS Credentials
         uses: aws-actions/configure-aws-credentials@v4
@@ -108,23 +114,47 @@ jobs:
         working-directory: infra
         run: cdk deploy BeejhoFrontendCertificateStack --require-approval never
 
-  deploy_infra:
+  deploy_cloudfront:
     runs-on: ubuntu-latest
     needs: [deploy_s3, deploy_certificate] # Ensures infra deploys only after S3 and Certificate are done
     steps:
       - name: Checkout
         uses: actions/checkout@v4
 
+      - name: Setup pnpm
+        uses: pnpm/action-setup@v4
+        with:
+          version: 9
+          run_install: false
+
+      - name: Install CDK Dependencies
+        working-directory: infra
+        run: pnpm install
+
       - name: Configure AWS Credentials
         uses: aws-actions/configure-aws-credentials@v4
         with:
           aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
           aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
           aws-region: ap-south-1
 
-      - name: Deploy Infra Stack
+      - name: Install AWS CDK
+        run: npm install -g aws-cdk
+
+      - name: Determine Environment Name
+        run: |
+          if [[ $GITHUB_REF == refs/heads/main ]]; then
+            ENV_NAME="production"
+          elif [[ $GITHUB_REF == refs/heads/stage ]]; then
+            ENV_NAME="stg"
+          else
+            ENV_NAME="dev"
+          fi
+          echo "ENV_NAME=$ENV_NAME" >> $GITHUB_ENV
+
+      - name: Deploy Cloudfront Stack
         working-directory: infra
-        run: cdk deploy BeejhoFrontendStack-${{ needs.setup.outputs.env_name }} --require-approval never
+        run: cdk deploy BeejhoFrontendCloudfrontStack-${{ env.ENV_NAME}} --require-approval never
 
   sync_to_s3:
     runs-on: ubuntu-latest