fix warnings

Author: facontidavide

.gitignore

@@ -3,6 +3,8 @@
 build*
 site/*
 /.vscode/
+.vs/
 
 # clangd cache
 /.cache/*
+CMakeSettings.json

CMakeLists.txt

@@ -60,7 +60,7 @@ if(USE_V3_COMPATIBLE_NAMES)
 endif()
 
 #---- Find other packages ----
-find_package(Threads)
+find_package(Threads REQUIRED)
 find_package(ZMQ)
 
 if( ZMQ_FOUND )
@@ -112,10 +112,12 @@ elseif(BTCPP_UNIT_TESTS)
         include(FetchContent)
         FetchContent_Declare(
             googletest
-            URL https://github.com/google/googletest/archive/609281088cfefc76f9d0ce82e1ff6c30cc3591e5.zip
-            )
+            GIT_REPOSITORY https://github.com/google/googletest.git
+            GIT_TAG        release-1.12.1)
         # For Windows: Prevent overriding the parent project's compiler/linker settings
         set(gtest_force_shared_crt ON CACHE BOOL "" FORCE)
+        set(BUILD_GMOCK OFF CACHE BOOL "" FORCE)
+        set(BUILD_GTEST ON CACHE BOOL "" FORCE)
         FetchContent_MakeAvailable(googletest)
     endif()
 endif()
@@ -195,7 +197,7 @@ endif()
 
 target_link_libraries(${BEHAVIOR_TREE_LIBRARY}
     PUBLIC
-        ${CMAKE_THREAD_LIBS_INIT}
+        Threads::Threads
         ${CMAKE_DL_LIBS}
     PRIVATE
         $<BUILD_INTERFACE:foonathan::lexy>

include/behaviortree_cpp/utils/convert_impl.hpp

@@ -73,9 +73,16 @@ inline void checkUpperLimit(const From& from)
 template <typename From, typename To>
 inline void checkLowerLimit(const From& from)
 {
-    if (from < std::numeric_limits<To>::min()){
-        throw std::runtime_error("Value outside the lovest numerical limit.");
+  if constexpr (std::is_same<To, bool>::value)
+  {
+    if (from !=0 && from != 1)
+    {
+      throw std::runtime_error("Implicit casting to bool is not allowed");
     }
+  }
+  else if (from < std::numeric_limits<To>::min()){
+    throw std::runtime_error("Value outside the lovest numerical limit.");
+  }
 }
 
 template <typename From, typename To>

tools/bt_log_cat.cpp

@@ -57,7 +57,7 @@ int main(int argc, char* argv[])
 
         for (size_t i = 0; i < node->children_uid()->size(); i++)
         {
-            recursiveStep(node->children_uid()->Get(i), indent + 1);
+            recursiveStep(node->children_uid()->Get(uint16_t(i)), indent + 1);
         }
     };