fix warnings

Author: facontidavide

.clang-tidy

@@ -13,18 +13,13 @@ Checks: [
   "-bugprone-branch-clone",
   "-bugprone-easily-swappable-parameters",
   "-bugprone-narrowing-conversions",
-  "-cert-err33-c",
-  "-cert-err58-cpp",
-  "-cert-oop54-cpp",
   "-clang-analyzer-optin.cplusplus.VirtualCall",
   "-cppcoreguidelines-avoid-c-arrays",
   "-cppcoreguidelines-avoid-const-or-ref-data-members",
   "-cppcoreguidelines-avoid-magic-numbers",
   "-cppcoreguidelines-avoid-non-const-global-variables",
   "-cppcoreguidelines-init-variables",
-  "-cppcoreguidelines-macro-usage",
   "-cppcoreguidelines-narrowing-conversions",
-  "-cppcoreguidelines-noexcept-move-operations",
   "-cppcoreguidelines-owning-memory",
   "-cppcoreguidelines-prefer-member-initializer",
   "-cppcoreguidelines-pro-bounds-array-to-pointer-decay",
@@ -34,7 +29,6 @@ Checks: [
   "-cppcoreguidelines-pro-type-member-init",
   "-cppcoreguidelines-pro-type-union-access",
   "-cppcoreguidelines-pro-type-vararg",
-  "-cppcoreguidelines-special-member-functions",
   "-cppcoreguidelines-use-default-member-init",
   "-misc-no-recursion",
   "-modernize-avoid-c-arrays",

include/behaviortree_cpp/utils/safe_any.hpp

@@ -118,6 +118,8 @@ class Any
 
   Any& operator=(const Any& other);
 
+  Any& operator=(Any&& other) noexcept;
+
   [[nodiscard]] bool isNumber() const;
 
   [[nodiscard]] bool isIntegral() const;
@@ -306,7 +308,17 @@ inline bool isCastingSafe(const std::type_index& type, const T& val)
 
 inline Any& Any::operator=(const Any& other)
 {
-  this->_any = other._any;
+  if(this != &other)
+  {
+    this->_any = other._any;
+    this->_original_type = other._original_type;
+  }
+  return *this;
+}
+
+inline Any& Any::operator=(Any&& other) noexcept
+{
+  this->_any = std::move(other._any);
   this->_original_type = other._original_type;
   return *this;
 }

include/behaviortree_cpp/utils/simple_string.hpp

@@ -31,8 +31,11 @@ class SimpleString
 
   SimpleString& operator=(const SimpleString& other)
   {
-    this->~SimpleString();
-    createImpl(other.data(), other.size());
+    if(this != &other)
+    {
+      this->~SimpleString();
+      createImpl(other.data(), other.size());
+    }
     return *this;
   }
 

src/blackboard.cpp

@@ -308,11 +308,14 @@ void ImportBlackboardFromJSON(const nlohmann::json& json, Blackboard& blackboard
 
 Blackboard::Entry& Blackboard::Entry::operator=(const Entry& other)
 {
-  value = other.value;
-  info = other.info;
-  string_converter = other.string_converter;
-  sequence_id = other.sequence_id;
-  stamp = other.stamp;
+  if(this != &other)
+  {
+    value = other.value;
+    info = other.info;
+    string_converter = other.string_converter;
+    sequence_id = other.sequence_id;
+    stamp = other.stamp;
+  }
   return *this;
 }
 

src/xml_parsing.cpp

@@ -243,7 +243,8 @@ void XMLParser::PImpl::loadDocImpl(XMLDocument* doc, bool add_includes)
   if(doc->Error())
   {
     char buffer[512];
-    snprintf(buffer, sizeof buffer, "Error parsing the XML: %s", doc->ErrorStr());
+    std::ignore =
+        snprintf(buffer, sizeof buffer, "Error parsing the XML: %s", doc->ErrorStr());
     throw RuntimeError(buffer);
   }
 
@@ -368,14 +369,16 @@ void VerifyXML(const std::string& xml_text,
   if(xml_error != tinyxml2::XML_SUCCESS)
   {
     char buffer[512];
-    snprintf(buffer, sizeof buffer, "Error parsing the XML: %s", doc.ErrorName());
+    std::ignore =
+        snprintf(buffer, sizeof buffer, "Error parsing the XML: %s", doc.ErrorName());
     throw RuntimeError(buffer);
   }
 
   //-------- Helper functions (lambdas) -----------------
   auto ThrowError = [&](int line_num, const std::string& text) {
     char buffer[512];
-    snprintf(buffer, sizeof buffer, "Error at line %d: -> %s", line_num, text.c_str());
+    std::ignore = snprintf(buffer, sizeof buffer, "Error at line %d: -> %s", line_num,
+                           text.c_str());
     throw RuntimeError(buffer);
   };