feat: improve runtime error output for missing manifest in xml_parser (#669)

fmros · facontidavide · web-flow · commit 9f02535856fe · 2023-10-16T16:46:15.000+02:00
* feat: improve runtime error output for missing manifest

by adding the element ID for which the parser failed to the output

* Update src/xml_parsing.cpp

---------

Co-authored-by: Davide Faconti &lt;davide.faconti@gmail.com&gt;
diff --git a/src/xml_parsing.cpp b/src/xml_parsing.cpp
@@ -600,7 +600,8 @@ TreeNode::Ptr XMLParser::PImpl::createNodeFromXML(const XMLElement* element,
   {
     if(!manifest)
     {
-      throw RuntimeError("Missing manifest. It shouldn't happen. Please report this issue");
+      auto msg = StrCat("Missing manifest for element_ID: ", element_ID, ". It shouldn't happen. Please report this issue.");
+      throw RuntimeError(msg);
     }
 
     //Check that name in remapping can be found in the manifest

Original file line number	Diff line number	Diff line change
`@@ -600,7 +600,8 @@ TreeNode::Ptr XMLParser::PImpl::createNodeFromXML(const XMLElement* element,`
`600`	`600`	`{`
`601`	`601`	`if(!manifest)`
`602`	`602`	`{`
`603`		`- throw RuntimeError("Missing manifest. It shouldn't happen. Please report this issue");`
	`603`	`+ auto msg = StrCat("Missing manifest for element_ID: ", element_ID, ". It shouldn't happen. Please report this issue.");`
	`604`	`+ throw RuntimeError(msg);`
`604`	`605`	`}`
`605`	`606`
`606`	`607`	`//Check that name in remapping can be found in the manifest`