fix warning in older compilers

facontidavide · facontidavide · commit d7457d22796a · 2023-10-16T17:37:23.000+02:00
diff --git a/include/behaviortree_cpp/utils/safe_any.hpp b/include/behaviortree_cpp/utils/safe_any.hpp
@@ -347,9 +347,9 @@ nonstd::expected<T, std::string> Any::stringToNumber() const
 {
   static_assert(std::is_arithmetic_v<T> && !std::is_same_v<T, bool>, "Expecting a numeric type");
 
-  auto str = linb::any_cast<SafeAny::SimpleString>(_any);
-  T out;
+  const auto str = linb::any_cast<SafeAny::SimpleString>(_any);
 #if __has_include(<GL/gl.h>)
+  T out;
   auto [ptr, err] = std::from_chars(str.data(), str.data() + str.size(), out);
   if(err == std::errc())
   {

Original file line number	Diff line number	Diff line change
`@@ -347,9 +347,9 @@ nonstd::expected<T, std::string> Any::stringToNumber() const`
`347`	`347`	`{`
`348`	`348`	`static_assert(std::is_arithmetic_v<T> && !std::is_same_v<T, bool>, "Expecting a numeric type");`
`349`	`349`
`350`		`- auto str = linb::any_cast<SafeAny::SimpleString>(_any);`
`351`		`- T out;`
	`350`	`+ const auto str = linb::any_cast<SafeAny::SimpleString>(_any);`
`352`	`351`	`#if __has_include(<GL/gl.h>)`
	`352`	`+ T out;`
`353`	`353`	`auto [ptr, err] = std::from_chars(str.data(), str.data() + str.size(), out);`
`354`	`354`	`if(err == std::errc())`
`355`	`355`	`{`