fix latest warnings

Author: facontidavide

include/behaviortree_cpp/utils/convert_impl.hpp

@@ -154,13 +154,21 @@ void convertNumber(const SRC& source, DST& target)
       throw std::runtime_error("Value is negative and can't be converted to unsigned");
     }
   }
-  // these conversions are always safe: // No check needed
-  if constexpr(is_same<SRC, DST>() ||                                // same type
-               (is_same<SRC, float>() && is_same<DST, double>()) ||  // float -> double
-               (is_convertible_to_bool<SRC>() && is_same<DST, bool>()))
+  // these conversions are always safe (no check needed):
+  // - same type
+  // - float -> double
+  // - floating point to bool (C-style: any non-zero is true)
+  if constexpr(is_same<SRC, DST>() || (is_same<SRC, float>() && is_same<DST, double>()) ||
+               (std::is_floating_point<SRC>::value && is_same<DST, bool>()))
   {
     target = static_cast<DST>(source);
   }
+  // integer to bool: only 0 and 1 are valid
+  else if constexpr(is_integer<SRC>() && is_same<DST, bool>())
+  {
+    checkLowerLimit<SRC, DST>(source);
+    target = static_cast<DST>(source);
+  }
   else if constexpr(both_integers)
   {
     if constexpr(sizeof(SRC) == sizeof(DST) && !is_signed<SRC>() && is_signed<DST>())

include/behaviortree_cpp/utils/simple_string.hpp

@@ -50,9 +50,11 @@ class SimpleString
 
   SimpleString& operator=(SimpleString&& other) noexcept
   {
-    this->~SimpleString();
-
-    std::swap(_storage, other._storage);
+    if(this != &other)
+    {
+      this->~SimpleString();
+      std::swap(_storage, other._storage);
+    }
     return *this;
   }
 
@@ -120,22 +122,34 @@ class SimpleString
 
   bool operator<=(const SimpleString& other) const
   {
-    return std::strcmp(data(), other.data()) <= 0;
+    return !(*this > other);
   }
 
   bool operator>=(const SimpleString& other) const
   {
-    return std::strcmp(data(), other.data()) >= 0;
+    return !(*this < other);
   }
 
   bool operator<(const SimpleString& other) const
   {
-    return std::strcmp(data(), other.data()) < 0;
+    const size_t min_size = std::min(size(), other.size());
+    int cmp = std::memcmp(data(), other.data(), min_size);
+    if(cmp != 0)
+    {
+      return cmp < 0;
+    }
+    return size() < other.size();
   }
 
   bool operator>(const SimpleString& other) const
   {
-    return std::strcmp(data(), other.data()) > 0;
+    const size_t min_size = std::min(size(), other.size());
+    int cmp = std::memcmp(data(), other.data(), min_size);
+    if(cmp != 0)
+    {
+      return cmp > 0;
+    }
+    return size() > other.size();
   }
 
   bool isSOO() const