(issue #163) fix ded code

facontidavide · facontidavide · commit f97f87f4566c · 2020-03-19T14:08:07.000+01:00
diff --git a/src/xml_parsing.cpp b/src/xml_parsing.cpp
@@ -321,12 +321,13 @@ void VerifyXML(const std::string& xml_text,
         }
         else if (StrEqual(name, "SubTree"))
         {
-            for (auto child = node->FirstChildElement(); child != nullptr;
-                 child = child->NextSiblingElement())
+            auto child = node->FirstChildElement();
+
+            if (child)
             {
-                if( StrEqual(child->Name(), "remap") )
+                if (StrEqual(child->Name(), "remap"))
                 {
-                   ThrowError(node->GetLineNum(), "<remap> was deprecated");
+                    ThrowError(node->GetLineNum(), "<remap> was deprecated");
                 }
                 else{
                     ThrowError(node->GetLineNum(), "<SubTree> should not have any child");

Original file line number	Diff line number	Diff line change
`@@ -321,12 +321,13 @@ void VerifyXML(const std::string& xml_text,`
`321`	`321`	`}`
`322`	`322`	`else if (StrEqual(name, "SubTree"))`
`323`	`323`	`{`
`324`		`- for (auto child = node->FirstChildElement(); child != nullptr;`
`325`		`- child = child->NextSiblingElement())`
	`324`	`+ auto child = node->FirstChildElement();`
	`325`	`+`
	`326`	`+ if (child)`
`326`	`327`	`{`
`327`		`- if( StrEqual(child->Name(), "remap") )`
	`328`	`+ if (StrEqual(child->Name(), "remap"))`
`328`	`329`	`{`
`329`		`- ThrowError(node->GetLineNum(), "<remap> was deprecated");`
	`330`	`+ ThrowError(node->GetLineNum(), "<remap> was deprecated");`
`330`	`331`	`}`
`331`	`332`	`else{`
`332`	`333`	`ThrowError(node->GetLineNum(), "<SubTree> should not have any child");`