Skip to content

Commit 1ded132

Browse files
committed
Prioritize directly defined rewards over reward files
Prevents weird cases of blank reward files overriding rewards
1 parent 95dd1ed commit 1ded132

File tree

1 file changed

+6
-13
lines changed

1 file changed

+6
-13
lines changed

AdvancedCore/src/main/java/com/bencodez/advancedcore/api/rewards/RewardHandler.java

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -325,19 +325,6 @@ public Reward getReward(String reward) {
325325
}
326326
reward = reward.replace(" ", "_");
327327

328-
/*
329-
* if (rewardOptions != null) { String prefix = rewardOptions.getPrefix(); if
330-
* (prefix != null && !prefix.equals("")) { String str = reward; reward = prefix
331-
* + "_" + str; } String suffix = rewardOptions.getSuffix(); if (suffix != null
332-
* && !suffix.equals("")) { reward += "_" + suffix; } }
333-
*/
334-
335-
for (Reward rewardFile : getRewards()) {
336-
if (rewardFile.getName().equalsIgnoreCase(reward)) {
337-
return rewardFile;
338-
}
339-
}
340-
341328
if (reward.equals("")) {
342329
plugin.getLogger().warning("Tried to get any empty reward file name, renaming to EmptyName");
343330
reward = "EmptyName";
@@ -362,6 +349,12 @@ public Reward getReward(String reward) {
362349
}
363350
}
364351

352+
for (Reward rewardFile : getRewards()) {
353+
if (rewardFile.getName().equalsIgnoreCase(reward)) {
354+
return rewardFile;
355+
}
356+
}
357+
365358
return new Reward(reward);
366359
}
367360

0 commit comments

Comments
 (0)