Skip to content

Conversation

@plakrisenko
Copy link
Collaborator

fix condition ids in simulation table, add datasetId column and visualization specification.

Visualizations without markers:

plot1 plot2 plot3 plot4 plot5 plot6

@plakrisenko
Copy link
Collaborator Author

I can split visualizations further, e.g. a plot for each typeId + expId.
The dashed line looks odd, I think due to too many points

@stephanmg
Copy link
Collaborator

@plakrisenko thanks for the effort - I think we keep the markers for the discrete measurement data, but not for the simulation

@plakrisenko
Copy link
Collaborator Author

@plakrisenko thanks for the effort - I think we keep the markers for the discrete measurement data, but not for the simulation

I removed the markers using this:
https://github.com/PEtab-dev/libpetab-python/blob/main/petab/v1/visualize/plotter.py#L19-L32

For this particular model, with the markers (for both measurements and the simulations) the plot look bad:
plot3

Copy link
Collaborator

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@plakrisenko plakrisenko merged commit 92568af into master Nov 6, 2025
6 checks passed
@plakrisenko plakrisenko linked an issue Nov 12, 2025 that may be closed by this pull request
14 tasks
@plakrisenko plakrisenko deleted the beer_fixes branch November 21, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing visualization files

4 participants