Skip to content

Commit b51f058

Browse files
committed
Revert ABI gen changes to get some fresh benchmarks
1 parent 7e60a34 commit b51f058

File tree

7 files changed

+7
-26
lines changed

7 files changed

+7
-26
lines changed

kotlin/settings/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ bool_flag(
3737
)
3838

3939
# Kotlin strict deps can be enabled by setting the following value on the command line
40-
# --@rules_kotlin//kotlin/settings:experimental_exclude_assocate_compile_jars_from_associates=True
40+
# --@io_bazel_rules_kotlin//kotlin/internal/jvm:experimental_exclude_assocate_compile_jars_from_associates=True
4141
bool_flag(
4242
name = "experimental_exclude_assocate_compile_jars_from_associates",
4343
build_setting_default = False,

kotlin/settings/BUILD.release.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ bool_flag(
2929
)
3030

3131
# Kotlin strict deps can be enabled by setting the following value on the command line
32-
# --@rules_kotlin//kotlin/settings:experimental_exclude_assocate_compile_jars_from_associates=True
32+
# --@io_bazel_rules_kotlin//kotlin/internal/jvm:experimental_exclude_assocate_compile_jars_from_associates=True
3333
bool_flag(
3434
name = "experimental_exclude_assocate_compile_jars_from_associates",
3535
build_setting_default = False,

src/main/kotlin/BUILD

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,6 @@ exports_files(
66
visibility = ["//src:__subpackages__"],
77
)
88

9-
filegroup(
10-
name = "jvm-abi-gen",
11-
srcs = ["jvm-abi-gen-1.9.20-with-DataClasses-SourceDebugExtension-NestedClasses-SortedOrder-Companions-InlineDebugInfo.jar"],
12-
visibility = ["//visibility:public"],
13-
)
14-
159
jar_jar(
1610
name = "skip-code-gen",
1711
input_jar = "//src/main/kotlin/io/bazel/kotlin/plugin:skip-code-gen_deploy.jar",
@@ -42,7 +36,6 @@ release_archive(
4236
name = "pkg",
4337
srcs = [
4438
":jdeps-gen.jar",
45-
":jvm-abi-gen-1.9.20-with-DataClasses-SourceDebugExtension-NestedClasses-SortedOrder-Companions-InlineDebugInfo.jar",
4639
":skip-code-gen.jar",
4740
],
4841
package_dir = "src/main/kotlin", # explicitly set the package directory, as there are no parent release_archives.

src/main/kotlin/BUILD.release.bazel

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,6 @@
1414

1515
load("@rules_java//java:defs.bzl", "java_binary", "java_import")
1616

17-
java_import(
18-
name = "jvm-abi-gen",
19-
jars = ["jvm-abi-gen-1.9.20-with-DataClasses-SourceDebugExtension-NestedClasses-SortedOrder-Companions-InlineDebugInfo.jar"],
20-
visibility = ["//visibility:public"],
21-
)
22-
2317
java_import(
2418
name = "worker",
2519
jars = ["kotlin_worker.jar"],
@@ -44,8 +38,8 @@ java_binary(
4438
name = "build",
4539
data = [
4640
":jdeps-gen",
47-
":jvm-abi-gen",
4841
":skip-code-gen",
42+
"//kotlin/compiler:jvm-abi-gen",
4943
"//kotlin/compiler:kotlin-annotation-processing",
5044
"//kotlin/compiler:kotlin-compiler",
5145
"//kotlin/compiler:kotlin-reflect",
@@ -55,7 +49,7 @@ java_binary(
5549
"@com_github_jetbrains_kotlin//:home",
5650
],
5751
jvm_flags = [
58-
"-D@com_github_jetbrains_kotlin...jvm-abi-gen=$(rlocationpath :jvm-abi-gen)",
52+
"-D@com_github_jetbrains_kotlin...jvm-abi-gen=$(rlocationpath //kotlin/compiler:jvm-abi-gen)",
5953
"-D@com_github_jetbrains_kotlin...kotlin-compiler=$(rlocationpath //kotlin/compiler:kotlin-compiler)",
6054
"-D@com_github_jetbrains_kotlin...kapt=$(rlocationpath //kotlin/compiler:kotlin-annotation-processing)",
6155
"-D@rules_kotlin...jdeps-gen=$(rlocationpath //src/main/kotlin:jdeps-gen)",

src/main/kotlin/io/bazel/kotlin/builder/cmd/BUILD.bazel

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
load("//src/main/kotlin:bootstrap.bzl", "kt_bootstrap_binary", "kt_bootstrap_library")
22

3-
java_import(
4-
name = "jvm-abi-gen",
5-
jars = ["//src/main/kotlin:jvm-abi-gen"],
6-
visibility = ["//visibility:public"],
7-
)
8-
93
kt_bootstrap_library(
104
name = "build_lib",
115
srcs = ["Build.kt"],
@@ -21,7 +15,7 @@ kt_bootstrap_library(
2115
kt_bootstrap_binary(
2216
name = "build",
2317
data = [
24-
":jvm-abi-gen",
18+
"//kotlin/compiler:jvm-abi-gen",
2519
"//kotlin/compiler:kotlin-annotation-processing",
2620
"//kotlin/compiler:kotlin-compiler",
2721
"//kotlin/compiler:kotlin-reflect",
@@ -33,7 +27,7 @@ kt_bootstrap_binary(
3327
"@com_github_jetbrains_kotlin//:home",
3428
],
3529
jvm_flags = [
36-
"-D@com_github_jetbrains_kotlin...jvm-abi-gen=$(rlocationpath :jvm-abi-gen)",
30+
"-D@com_github_jetbrains_kotlin...jvm-abi-gen=$(rlocationpath //kotlin/compiler:jvm-abi-gen)",
3731
"-D@com_github_jetbrains_kotlin...kotlin-compiler=$(rlocationpath //kotlin/compiler:kotlin-compiler)",
3832
"-D@com_github_jetbrains_kotlin...kapt=$(rlocationpath //kotlin/compiler:kotlin-annotation-processing)",
3933
"-D@rules_kotlin...jdeps-gen=$(rlocationpath //src/main/kotlin:jdeps-gen)",

src/main/starlark/core/repositories/compiler.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ kotlin_compiler_repository = repository_rule(
6060
),
6161
"_template": attr.label(
6262
doc = "repository build file template",
63-
default = "BUILD.com_github_jetbrains_kotlin.bazel",
63+
default = ":BUILD.com_github_jetbrains_kotlin.bazel",
6464
),
6565
"_capabilities_templates": attr.label_list(
6666
doc = "compiler capabilities file templates",

0 commit comments

Comments
 (0)