optimize the for range.

BeneficialCode · BeneficialCode · commit 5cd4c94215f9 · 2025-03-17T14:56:04.000+08:00
diff --git a/WinArk/ApiReader.cpp b/WinArk/ApiReader.cpp
@@ -34,6 +34,7 @@ void ApiReader::ParseModule(ModuleInfo* pModule) {
 			}
 		}
 	}
+	pModule->_isAlreadyParsed = true;
 }
 
 void ApiReader::ParseModuleWithMapping(ModuleInfo* pModule) {
@@ -176,7 +177,7 @@ void ApiReader::FindApiInProcess(ModuleInfo* pModule, char* pSearchName, WORD or
 
 		auto exports = parser.GetExports();
 
-		for (ExportedSymbol symbol : exports) {
+		for (const ExportedSymbol& symbol : exports) {
 			if (pSearchName != nullptr) {
 				if (!strcmp(symbol.Name.c_str(), pSearchName)) {
 					*pVA = symbol.Address + pModule->_modBaseAddr;
@@ -195,7 +196,7 @@ void ApiReader::FindApiInProcess(ModuleInfo* pModule, char* pSearchName, WORD or
 		PEParser parser(pModule->_fullPath);
 		auto exports = parser.GetExports();
 
-		for (ExportedSymbol symbol : exports) {
+		for (const ExportedSymbol& symbol : exports) {
 			if (pSearchName != nullptr) {
 				if (!strcmp(symbol.Name.c_str(), pSearchName)) {
 					*pVA = symbol.Address + pModule->_modBaseAddr;

Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,7 @@ void ApiReader::ParseModule(ModuleInfo* pModule) {`
`34`	`34`	`}`
`35`	`35`	`}`
`36`	`36`	`}`
	`37`	`+ pModule->_isAlreadyParsed = true;`
`37`	`38`	`}`
`38`	`39`
`39`	`40`	`void ApiReader::ParseModuleWithMapping(ModuleInfo* pModule) {`
`@@ -176,7 +177,7 @@ void ApiReader::FindApiInProcess(ModuleInfo* pModule, char* pSearchName, WORD or`
`176`	`177`
`177`	`178`	`auto exports = parser.GetExports();`
`178`	`179`
`179`		`- for (ExportedSymbol symbol : exports) {`
	`180`	`+ for (const ExportedSymbol& symbol : exports) {`
`180`	`181`	`if (pSearchName != nullptr) {`
`181`	`182`	`if (!strcmp(symbol.Name.c_str(), pSearchName)) {`
`182`	`183`	`*pVA = symbol.Address + pModule->_modBaseAddr;`
`@@ -195,7 +196,7 @@ void ApiReader::FindApiInProcess(ModuleInfo* pModule, char* pSearchName, WORD or`
`195`	`196`	`PEParser parser(pModule->_fullPath);`
`196`	`197`	`auto exports = parser.GetExports();`
`197`	`198`
`198`		`- for (ExportedSymbol symbol : exports) {`
	`199`	`+ for (const ExportedSymbol& symbol : exports) {`
`199`	`200`	`if (pSearchName != nullptr) {`
`200`	`201`	`if (!strcmp(symbol.Name.c_str(), pSearchName)) {`
`201`	`202`	`*pVA = symbol.Address + pModule->_modBaseAddr;`