fix(api): call to mpi/kokkos finalis in API finalise and also atexit to work with either from extern and app

Author: Benncs

apps/api/src/api.cpp

@@ -22,7 +22,9 @@
 #include <udf_handle.hpp>
 #include <utility>
 #include <vector>
-
+#ifndef NO_MPI
+#  include <mpi_w/wrap_mpi.hpp>
+#endif
 constexpr int ID_VERIF = 2025;
 
 #define CHECK_OR_RETURN(cond, msg)                                             \
@@ -66,7 +68,12 @@ namespace Api
   void
   finalise()
   {
-
+    if constexpr (AutoGenerated::FlagCompileTime::use_mpi)
+    {
+#ifndef NO_MPI
+      WrapMPI::finalize();
+#endif
+    }
     if (!Kokkos::is_finalized() && Kokkos::is_initialized())
     {
       Kokkos::finalize();

apps/api/src/api_raw.cpp

@@ -115,6 +115,7 @@ delete_handle(Handle* handle)
 {
   if (handle != nullptr)
   {
+
     delete *handle; // NOLINT
     *handle = nullptr;
   }

apps/core/src/case_data.cpp

@@ -178,13 +178,6 @@ namespace Core
       }
     }
 
-    if constexpr (AutoGenerated::FlagCompileTime::use_mpi)
-    {
-#ifndef NO_MPI
-      std::atexit(WrapMPI::finalize);
-#endif
-    }
-
     info.current_rank = static_cast<size_t>(rank);
     info.n_rank = static_cast<size_t>(size);
 

apps/core/src/host_export_handler.cpp

@@ -53,6 +53,9 @@ ExportHandler::pre_post_export(
     event_span = simulation.mc_unit->events.get_span();
   }
 
+  // TODO: Multi rank context : tally are not merged before exporting then
+  // events tally only correspond to rank 0
+
   // Update the main exporter with the current simulation data
   main_exporter->update_fields(current_time,
                                simulation.getCliqData(),