Fix backup path check and default value

Author: joshuamerold

paperless-ngx/DOCS.md

@@ -71,7 +71,7 @@ ssl: false
 certfile: fullchain.pem
 keyfile: privkey.pem
 backup_enabled: false
-backup_path: /share/paperless/exports
+backup_path: /data/exports
 backup_cron: "0 3 * * *"
 backup_keep_count: 3
 ```
@@ -162,11 +162,11 @@ Enables or disables automatic backups of your Paperless data. Set to `true` to e
 
 ### Option: `backup_path`
 
-Specifies the directory where backup files will be stored. The default path is `/share/paperless/exports`.
+Specifies the directory where backup files will be stored. The default path is `/data/exports`.
 
 ### Option: `backup_cron`
 
-Defines the cron schedule for automatic backups. The default value `"0 3 * * *"` runs backups daily at 3:00 AM. Use standard cron syntax to customize the backup schedule.
+Defines the cron schedule for automatic backups. The default value `"0 2 * * *"` runs backups daily at 3:00 AM. Use standard cron syntax to customize the backup schedule.
 
 ### Option: `backup_keep_count`
 

paperless-ngx/config.yaml

@@ -38,7 +38,7 @@ options:
   ingress_auth: false
   tika_gotenberg: false
   backup_enabled: false
-  backup_path: /share/paperless/exports
+  backup_path: "/data/exports"
   backup_cron: "0 3 * * *"
   backup_keep_count: 3
 schema:
@@ -63,7 +63,7 @@ schema:
   ingress_auth: bool
   tika_gotenberg: bool
   locales: str?
-  backup_enabled: bool 
-  backup_path: str 
-  backup_cron: str 
+  backup_enabled: bool
+  backup_path: str
+  backup_cron: str
   backup_keep_count: int

paperless-ngx/rootfs/etc/cont-init.d/90-cron-backup.sh

@@ -4,14 +4,16 @@ set -e
 
 echo "[INFO] Configuring backup cron job..."
 
-if type bashio >/dev/null 2>&1; then
-    CRON_SCHEDULE="$(bashio::config 'backup_cron')"
+if bashio::config.has_value 'backup_enabled'; then
     BACKUP_ENABLED="$(bashio::config 'backup_enabled')"
-    BACKUP_KEEP_COUNT="$(bashio::config 'backup_keep_count')"
 else
-    CRON_SCHEDULE="0 2 * * *"
     BACKUP_ENABLED="false"
-    BACKUP_KEEP_COUNT=-1
+fi
+
+if bashio::config.has_value 'backup_cron'; then
+    CRON_SCHEDULE="$(bashio::config 'backup_cron')"
+else
+    CRON_SCHEDULE="0 2 * * *"
 fi
 
 if [ "$BACKUP_ENABLED" == "false" ]; then
@@ -25,4 +27,4 @@ echo "${CRON_SCHEDULE} /usr/local/bin/paperless_backup.sh" > /etc/cron.d/paperle
 
 chmod 0644 /etc/cron.d/paperless-backup
 
-echo "[INFO] Backup cron job configured with schedule: $CRON_SCHEDULE & keep_count: $BACKUP_KEEP_COUNT"
+echo "[INFO] Backup cron job configured with schedule: $CRON_SCHEDULE"

paperless-ngx/rootfs/usr/local/bin/paperless_backup.sh

@@ -2,17 +2,25 @@
 # shellcheck shell=bash
 set -e
 
-if type bashio >/dev/null 2>&1; then
-    BACKUP_KEEP_COUNT="$(bashio::config 'backup_keep_count')"
+if bashio::config.has_value 'backup_path'; then
     BACKUP_PATH="$(bashio::config 'backup_path')"
 else
+    echo "[ERROR] No backup path configured. Please set 'backup_path' in the add-on configuration."
+    exit 1
+fi
+
+if bashio::config.has_value 'backup_keep_count'; then
+    BACKUP_KEEP_COUNT="$(bashio::config 'backup_keep_count')"
+else
+    echo "[WARN] 'backup_keep_count' not set, defaulting to 3"
     BACKUP_KEEP_COUNT=3
-    BACKUP_PATH="/share/paperless/exports"
 fi
 
 NOW=$(date '+%Y-%m-%d-%H:%M:%S')
 echo "[INFO] Backup started: $NOW"
 
+mkdir -p "$BACKUP_PATH"
+
 python3 manage.py document_exporter \
   "$BACKUP_PATH" \
   -z \