Skip to content

Commit 4d8dc22

Browse files
authored
chore: upgrade Node.js from 20.19.4 to 22.19.0 and update dependencies (coder#19870)
# Update Node.js from 20.19.4 to 22.19.0 This PR updates Node.js from v20.19.4 to v22.19.0 across the codebase. The change includes: - Updated Node.js version in GitHub Actions setup-node workflow - Updated Node.js version in the dogfood Dockerfile - Changed from `pkgs.nodejs_20` to `unstablePkgs.nodejs_22` in the Nix flake - Updated the Node.js engine version constraints in package.json files to allow Node.js 22 - Updated Playwright from v1.47.0 to v1.50.1 - Updated tzdata dependency from v1.0.44 to v1.0.46 - Updated the flake.lock file with latest nixpkgs references The PR also improves the error message for Playwright version mismatches by showing the actual versions in the error.
1 parent 6238937 commit 4d8dc22

File tree

7 files changed

+34
-33
lines changed

7 files changed

+34
-33
lines changed

.github/actions/setup-node/action.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ runs:
1616
- name: Setup Node
1717
uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
1818
with:
19-
node-version: 20.19.4
19+
node-version: 22.19.0
2020
# See https://github.com/actions/setup-node#caching-global-packages-data
2121
cache: "pnpm"
2222
cache-dependency-path: ${{ inputs.directory }}/pnpm-lock.yaml

dogfood/coder/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ RUN DOCTL_VERSION=$(curl -s "https://api.github.com/repos/digitalocean/doctl/rel
245245
ARG NVM_INSTALL_SHA=bdea8c52186c4dd12657e77e7515509cda5bf9fa5a2f0046bce749e62645076d
246246
# Install frontend utilities
247247
ENV NVM_DIR=/usr/local/nvm
248-
ENV NODE_VERSION=20.19.4
248+
ENV NODE_VERSION=22.19.0
249249
RUN mkdir -p $NVM_DIR
250250
RUN curl -o nvm_install.sh https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.0/install.sh && \
251251
echo "${NVM_INSTALL_SHA} nvm_install.sh" | sha256sum -c && \

flake.lock

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

flake.nix

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656

5757
formatter = pkgs.nixfmt-rfc-style;
5858

59-
nodejs = pkgs.nodejs_20;
59+
nodejs = unstablePkgs.nodejs_22;
6060
pnpm = pkgs.pnpm_10.override {
6161
inherit nodejs; # Ensure it points to the above nodejs version
6262
};
@@ -147,7 +147,6 @@
147147
less
148148
mockgen
149149
moreutils
150-
neovim
151150
nfpm
152151
nix-prefetch-git
153152
nodejs
@@ -242,7 +241,9 @@
242241
(pkgs.lib.importJSON ./site/package.json).devDependencies."@playwright/test"
243242
== pkgs.playwright-driver.version
244243
)
245-
"There is a mismatch between the playwright versions in the ./nix.flake and the ./site/package.json file. Please make sure that they use the exact same version.";
244+
"There is a mismatch between the playwright versions in the ./nix.flake (${pkgs.playwright-driver.version}) and the ./site/package.json (${
245+
(pkgs.lib.importJSON ./site/package.json).devDependencies."@playwright/test"
246+
}) file. Please make sure that they use the exact same version.";
246247
rec {
247248
inherit formatter;
248249

offlinedocs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
},
4343
"engines": {
4444
"npm": ">=9.0.0 <10.0.0",
45-
"node": ">=18.0.0 <21.0.0"
45+
"node": ">=18.0.0 <23.0.0"
4646
},
4747
"pnpm": {
4848
"overrides": {

site/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@
114114
"semver": "7.6.2",
115115
"tailwind-merge": "2.6.0",
116116
"tailwindcss-animate": "1.0.7",
117-
"tzdata": "1.0.44",
117+
"tzdata": "1.0.46",
118118
"ua-parser-js": "1.0.40",
119119
"ufuzzy": "npm:@leeoniya/[email protected]",
120120
"undici": "6.21.2",
@@ -127,7 +127,7 @@
127127
"@biomejs/biome": "2.2.0",
128128
"@chromatic-com/storybook": "4.1.0",
129129
"@octokit/types": "12.3.0",
130-
"@playwright/test": "1.47.0",
130+
"@playwright/test": "1.50.1",
131131
"@storybook/addon-docs": "9.1.2",
132132
"@storybook/addon-links": "9.1.2",
133133
"@storybook/addon-themes": "9.1.2",
@@ -195,7 +195,7 @@
195195
},
196196
"engines": {
197197
"pnpm": ">=10.0.0 <11.0.0",
198-
"node": ">=18.0.0 <21.0.0"
198+
"node": ">=18.0.0 <23.0.0"
199199
},
200200
"pnpm": {
201201
"overrides": {

site/pnpm-lock.yaml

Lines changed: 18 additions & 18 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)