Skip to content

Commit 7ebcb8c

Browse files
author
Ewan Crawford
committed
Improve command-buffer update error code wording
The `UR_DEVICE_INFO_COMMAND_BUFFER_UPDATE_SUPPORT_EXP` query no longer exists, so error defined for trying to make an updatable command-buffer when a device doesn't support it needs reworded to say if no capabilities are supported. Additionally, for each individual update capability, specify that an error is thrown if update is attempted using that characteristic. UR CTS added to verify this.
1 parent e7366f9 commit 7ebcb8c

File tree

9 files changed

+345
-29
lines changed

9 files changed

+345
-29
lines changed

‎include/ur_api.h‎

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8508,8 +8508,8 @@ typedef struct ur_exp_command_buffer_command_handle_t_ *ur_exp_command_buffer_co
85088508
/// + `NULL == phCommandBuffer`
85098509
/// - ::UR_RESULT_ERROR_INVALID_CONTEXT
85108510
/// - ::UR_RESULT_ERROR_INVALID_DEVICE
8511-
/// - ::UR_RESULT_ERROR_INVALID_OPERATION
8512-
/// + If `pCommandBufferDesc->isUpdatable` is true and `hDevice` does not support UR_DEVICE_INFO_COMMAND_BUFFER_UPDATE_SUPPORT_EXP.
8511+
/// - ::UR_RESULT_ERROR_UNSUPPORTED_FEATURE
8512+
/// + If `pCommandBufferDesc->isUpdatable` is true and `hDevice` returns 0 for the ::UR_DEVICE_INFO_COMMAND_BUFFER_UPDATE_CAPABILITIES_EXP query.
85138513
/// - ::UR_RESULT_ERROR_OUT_OF_HOST_MEMORY
85148514
/// - ::UR_RESULT_ERROR_OUT_OF_RESOURCES
85158515
UR_APIEXPORT ur_result_t UR_APICALL
@@ -9315,11 +9315,16 @@ urCommandBufferReleaseCommandExp(
93159315
/// - ::UR_RESULT_ERROR_INVALID_NULL_POINTER
93169316
/// + `NULL == pUpdateKernelLaunch`
93179317
/// - ::UR_RESULT_ERROR_UNSUPPORTED_FEATURE
9318-
/// + If update functionality is not supported by the device.
9318+
/// + If ::UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_KERNEL_ARGUMENTS is not supported by the device, but any of `pUpdateKernelLaunch->numNewMemObjArgs`, `pUpdateKernelLaunch->numNewPointerArgs`, or `pUpdateKernelLaunch->numNewValueArgs` are not zero.
9319+
/// + If ::UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_LOCAL_WORK_SIZE is not supported by the device but `pUpdateKernelLaunch->pNewLocalWorkSize` is not nullptr.
9320+
/// + If ::UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_GLOBAL_WORK_SIZE is not supported by the device but `pUpdateKernelLaunch->pNewGlobalWorkSize` is not nullptr
9321+
/// + If ::UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_GLOBAL_WORK_OFFSET is not supported by the device but `pUpdateKernelLaunch->pNewGlobalWorkOffset` is not nullptr.
9322+
/// + If ::UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_KERNEL_HANDLE is not supported by the device but `pUpdateKernelLaunch->hNewKernel` is not nullptr.
93199323
/// - ::UR_RESULT_ERROR_INVALID_OPERATION
93209324
/// + If ::ur_exp_command_buffer_desc_t::isUpdatable was not set to true on creation of the command buffer `hCommand` belongs to.
93219325
/// + If the command-buffer `hCommand` belongs to has not been finalized.
9322-
/// - ::UR_RESULT_ERROR_INVALID_COMMAND_BUFFER_COMMAND_HANDLE_EXP - "If `hCommand` is not a kernel execution command."
9326+
/// - ::UR_RESULT_ERROR_INVALID_COMMAND_BUFFER_COMMAND_HANDLE_EXP
9327+
/// + If `hCommand` is not a kernel execution command.
93239328
/// - ::UR_RESULT_ERROR_INVALID_MEM_OBJECT
93249329
/// - ::UR_RESULT_ERROR_INVALID_KERNEL_ARGUMENT_INDEX
93259330
/// - ::UR_RESULT_ERROR_INVALID_KERNEL_ARGUMENT_SIZE
@@ -9329,7 +9334,7 @@ urCommandBufferReleaseCommandExp(
93299334
/// - ::UR_RESULT_ERROR_INVALID_WORK_GROUP_SIZE
93309335
/// - ::UR_RESULT_ERROR_INVALID_VALUE
93319336
/// + If `pUpdateKernelLaunch->hNewKernel` was not passed to the `hKernel` or `phKernelAlternatives` parameters of ::urCommandBufferAppendKernelLaunchExp when this command was created.
9332-
/// + If `pUpdateKernelLaunch->newWorkDim` is different from the current workDim in `hCommand` and, pUpdateKernelLaunch->pNewGlobalWorkSize, or pUpdateKernelLaunch->pNewGlobalWorkOffset are nullptr.
9337+
/// + If `pUpdateKernelLaunch->newWorkDim` is different from the current workDim in `hCommand` and, `pUpdateKernelLaunch->pNewGlobalWorkSize`, or `pUpdateKernelLaunch->pNewGlobalWorkOffset` are nullptr.
93339338
/// - ::UR_RESULT_ERROR_OUT_OF_HOST_MEMORY
93349339
/// - ::UR_RESULT_ERROR_OUT_OF_RESOURCES
93359340
UR_APIEXPORT ur_result_t UR_APICALL
@@ -9355,7 +9360,7 @@ urCommandBufferUpdateKernelLaunchExp(
93559360
/// - ::UR_RESULT_ERROR_INVALID_NULL_POINTER
93569361
/// + `NULL == phSignalEvent`
93579362
/// - ::UR_RESULT_ERROR_UNSUPPORTED_FEATURE
9358-
/// + If UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_EVENTS is not supported by the device associated with `hCommand`.
9363+
/// + If ::UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_EVENTS is not supported by the device associated with `hCommand`.
93599364
/// - ::UR_RESULT_ERROR_INVALID_OPERATION
93609365
/// + If ::ur_exp_command_buffer_desc_t::isUpdatable was not set to true on creation of the command buffer `hCommand` belongs to.
93619366
/// + If the command-buffer `hCommand` belongs to has not been finalized.
@@ -9382,7 +9387,7 @@ urCommandBufferUpdateSignalEventExp(
93829387
/// - ::UR_RESULT_ERROR_INVALID_NULL_HANDLE
93839388
/// + `NULL == hCommand`
93849389
/// - ::UR_RESULT_ERROR_UNSUPPORTED_FEATURE
9385-
/// + If UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_EVENTS is not supported by the device associated with `hCommand`.
9390+
/// + If ::UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_EVENTS is not supported by the device associated with `hCommand`.
93869391
/// - ::UR_RESULT_ERROR_INVALID_OPERATION
93879392
/// + If ::ur_exp_command_buffer_desc_t::isUpdatable was not set to true on creation of the command buffer `hCommand` belongs to.
93889393
/// + If the command-buffer `hCommand` belongs to has not been finalized.

‎scripts/core/exp-command-buffer.yml‎

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -289,8 +289,9 @@ params:
289289
returns:
290290
- $X_RESULT_ERROR_INVALID_CONTEXT
291291
- $X_RESULT_ERROR_INVALID_DEVICE
292-
- $X_RESULT_ERROR_INVALID_OPERATION:
293-
- "If `pCommandBufferDesc->isUpdatable` is true and `hDevice` does not support UR_DEVICE_INFO_COMMAND_BUFFER_UPDATE_SUPPORT_EXP."
292+
- $X_RESULT_ERROR_UNSUPPORTED_FEATURE:
293+
- "If `pCommandBufferDesc->isUpdatable` is true and `hDevice` returns 0
294+
for the $X_DEVICE_INFO_COMMAND_BUFFER_UPDATE_CAPABILITIES_EXP query."
294295
- $X_RESULT_ERROR_OUT_OF_HOST_MEMORY
295296
- $X_RESULT_ERROR_OUT_OF_RESOURCES
296297
--- #--------------------------------------------------------------------------
@@ -1203,11 +1204,15 @@ params:
12031204
desc: "[in] Struct defining how the kernel command is to be updated."
12041205
returns:
12051206
- $X_RESULT_ERROR_UNSUPPORTED_FEATURE:
1206-
- "If update functionality is not supported by the device."
1207+
- "If $X_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_KERNEL_ARGUMENTS is not supported by the device, but any of `pUpdateKernelLaunch->numNewMemObjArgs`, `pUpdateKernelLaunch->numNewPointerArgs`, or `pUpdateKernelLaunch->numNewValueArgs` are not zero."
1208+
- "If $X_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_LOCAL_WORK_SIZE is not supported by the device but `pUpdateKernelLaunch->pNewLocalWorkSize` is not nullptr."
1209+
- "If $X_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_GLOBAL_WORK_SIZE is not supported by the device but `pUpdateKernelLaunch->pNewGlobalWorkSize` is not nullptr"
1210+
- "If $X_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_GLOBAL_WORK_OFFSET is not supported by the device but `pUpdateKernelLaunch->pNewGlobalWorkOffset` is not nullptr."
1211+
- "If $X_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_KERNEL_HANDLE is not supported by the device but `pUpdateKernelLaunch->hNewKernel` is not nullptr."
12071212
- $X_RESULT_ERROR_INVALID_OPERATION:
12081213
- "If $x_exp_command_buffer_desc_t::isUpdatable was not set to true on creation of the command buffer `hCommand` belongs to."
12091214
- "If the command-buffer `hCommand` belongs to has not been finalized."
1210-
- $X_RESULT_ERROR_INVALID_COMMAND_BUFFER_COMMAND_HANDLE_EXP
1215+
- $X_RESULT_ERROR_INVALID_COMMAND_BUFFER_COMMAND_HANDLE_EXP:
12111216
- "If `hCommand` is not a kernel execution command."
12121217
- $X_RESULT_ERROR_INVALID_MEM_OBJECT
12131218
- $X_RESULT_ERROR_INVALID_KERNEL_ARGUMENT_INDEX
@@ -1218,7 +1223,7 @@ returns:
12181223
- $X_RESULT_ERROR_INVALID_WORK_GROUP_SIZE
12191224
- $X_RESULT_ERROR_INVALID_VALUE:
12201225
- "If `pUpdateKernelLaunch->hNewKernel` was not passed to the `hKernel` or `phKernelAlternatives` parameters of $xCommandBufferAppendKernelLaunchExp when this command was created."
1221-
- "If `pUpdateKernelLaunch->newWorkDim` is different from the current workDim in `hCommand` and, pUpdateKernelLaunch->pNewGlobalWorkSize, or pUpdateKernelLaunch->pNewGlobalWorkOffset are nullptr."
1226+
- "If `pUpdateKernelLaunch->newWorkDim` is different from the current workDim in `hCommand` and, `pUpdateKernelLaunch->pNewGlobalWorkSize`, or `pUpdateKernelLaunch->pNewGlobalWorkOffset` are nullptr."
12221227
- $X_RESULT_ERROR_OUT_OF_HOST_MEMORY
12231228
- $X_RESULT_ERROR_OUT_OF_RESOURCES
12241229
--- #--------------------------------------------------------------------------
@@ -1236,7 +1241,7 @@ params:
12361241
desc: "[out] Event to be signaled."
12371242
returns:
12381243
- $X_RESULT_ERROR_UNSUPPORTED_FEATURE:
1239-
- "If UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_EVENTS is not supported by the device associated with `hCommand`."
1244+
- "If $X_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_EVENTS is not supported by the device associated with `hCommand`."
12401245
- $X_RESULT_ERROR_INVALID_OPERATION:
12411246
- "If $x_exp_command_buffer_desc_t::isUpdatable was not set to true on creation of the command buffer `hCommand` belongs to."
12421247
- "If the command-buffer `hCommand` belongs to has not been finalized."
@@ -1262,7 +1267,7 @@ params:
12621267
desc: "[in][optional][range(0, numEventsInWaitList)] pointer to a list of events that must be complete before the command execution. If nullptr, the numEventsInWaitList must be 0, indicating no wait events."
12631268
returns:
12641269
- $X_RESULT_ERROR_UNSUPPORTED_FEATURE:
1265-
- "If UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_EVENTS is not supported by the device associated with `hCommand`."
1270+
- "If $X_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_EVENTS is not supported by the device associated with `hCommand`."
12661271
- $X_RESULT_ERROR_INVALID_OPERATION:
12671272
- "If $x_exp_command_buffer_desc_t::isUpdatable was not set to true on creation of the command buffer `hCommand` belongs to."
12681273
- "If the command-buffer `hCommand` belongs to has not been finalized."

‎source/adapters/opencl/command_buffer.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferCreateExp(
7878
bool DeviceSupportsUpdate = UpdateCapabilities > 0;
7979

8080
if (IsUpdatable && !DeviceSupportsUpdate) {
81-
return UR_RESULT_ERROR_INVALID_OPERATION;
81+
return UR_RESULT_ERROR_UNSUPPORTED_FEATURE;
8282
}
8383

8484
cl_command_buffer_properties_khr Properties[3] = {

‎source/loader/ur_libapi.cpp‎

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7492,8 +7492,8 @@ ur_result_t UR_APICALL urBindlessImagesSignalExternalSemaphoreExp(
74927492
/// + `NULL == phCommandBuffer`
74937493
/// - ::UR_RESULT_ERROR_INVALID_CONTEXT
74947494
/// - ::UR_RESULT_ERROR_INVALID_DEVICE
7495-
/// - ::UR_RESULT_ERROR_INVALID_OPERATION
7496-
/// + If `pCommandBufferDesc->isUpdatable` is true and `hDevice` does not support UR_DEVICE_INFO_COMMAND_BUFFER_UPDATE_SUPPORT_EXP.
7495+
/// - ::UR_RESULT_ERROR_UNSUPPORTED_FEATURE
7496+
/// + If `pCommandBufferDesc->isUpdatable` is true and `hDevice` returns 0 for the ::UR_DEVICE_INFO_COMMAND_BUFFER_UPDATE_CAPABILITIES_EXP query.
74977497
/// - ::UR_RESULT_ERROR_OUT_OF_HOST_MEMORY
74987498
/// - ::UR_RESULT_ERROR_OUT_OF_RESOURCES
74997499
ur_result_t UR_APICALL urCommandBufferCreateExp(
@@ -8637,11 +8637,16 @@ ur_result_t UR_APICALL urCommandBufferReleaseCommandExp(
86378637
/// - ::UR_RESULT_ERROR_INVALID_NULL_POINTER
86388638
/// + `NULL == pUpdateKernelLaunch`
86398639
/// - ::UR_RESULT_ERROR_UNSUPPORTED_FEATURE
8640-
/// + If update functionality is not supported by the device.
8640+
/// + If ::UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_KERNEL_ARGUMENTS is not supported by the device, but any of `pUpdateKernelLaunch->numNewMemObjArgs`, `pUpdateKernelLaunch->numNewPointerArgs`, or `pUpdateKernelLaunch->numNewValueArgs` are not zero.
8641+
/// + If ::UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_LOCAL_WORK_SIZE is not supported by the device but `pUpdateKernelLaunch->pNewLocalWorkSize` is not nullptr.
8642+
/// + If ::UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_GLOBAL_WORK_SIZE is not supported by the device but `pUpdateKernelLaunch->pNewGlobalWorkSize` is not nullptr
8643+
/// + If ::UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_GLOBAL_WORK_OFFSET is not supported by the device but `pUpdateKernelLaunch->pNewGlobalWorkOffset` is not nullptr.
8644+
/// + If ::UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_KERNEL_HANDLE is not supported by the device but `pUpdateKernelLaunch->hNewKernel` is not nullptr.
86418645
/// - ::UR_RESULT_ERROR_INVALID_OPERATION
86428646
/// + If ::ur_exp_command_buffer_desc_t::isUpdatable was not set to true on creation of the command buffer `hCommand` belongs to.
86438647
/// + If the command-buffer `hCommand` belongs to has not been finalized.
8644-
/// - ::UR_RESULT_ERROR_INVALID_COMMAND_BUFFER_COMMAND_HANDLE_EXP - "If `hCommand` is not a kernel execution command."
8648+
/// - ::UR_RESULT_ERROR_INVALID_COMMAND_BUFFER_COMMAND_HANDLE_EXP
8649+
/// + If `hCommand` is not a kernel execution command.
86458650
/// - ::UR_RESULT_ERROR_INVALID_MEM_OBJECT
86468651
/// - ::UR_RESULT_ERROR_INVALID_KERNEL_ARGUMENT_INDEX
86478652
/// - ::UR_RESULT_ERROR_INVALID_KERNEL_ARGUMENT_SIZE
@@ -8651,7 +8656,7 @@ ur_result_t UR_APICALL urCommandBufferReleaseCommandExp(
86518656
/// - ::UR_RESULT_ERROR_INVALID_WORK_GROUP_SIZE
86528657
/// - ::UR_RESULT_ERROR_INVALID_VALUE
86538658
/// + If `pUpdateKernelLaunch->hNewKernel` was not passed to the `hKernel` or `phKernelAlternatives` parameters of ::urCommandBufferAppendKernelLaunchExp when this command was created.
8654-
/// + If `pUpdateKernelLaunch->newWorkDim` is different from the current workDim in `hCommand` and, pUpdateKernelLaunch->pNewGlobalWorkSize, or pUpdateKernelLaunch->pNewGlobalWorkOffset are nullptr.
8659+
/// + If `pUpdateKernelLaunch->newWorkDim` is different from the current workDim in `hCommand` and, `pUpdateKernelLaunch->pNewGlobalWorkSize`, or `pUpdateKernelLaunch->pNewGlobalWorkOffset` are nullptr.
86558660
/// - ::UR_RESULT_ERROR_OUT_OF_HOST_MEMORY
86568661
/// - ::UR_RESULT_ERROR_OUT_OF_RESOURCES
86578662
ur_result_t UR_APICALL urCommandBufferUpdateKernelLaunchExp(
@@ -8689,7 +8694,7 @@ ur_result_t UR_APICALL urCommandBufferUpdateKernelLaunchExp(
86898694
/// - ::UR_RESULT_ERROR_INVALID_NULL_POINTER
86908695
/// + `NULL == phSignalEvent`
86918696
/// - ::UR_RESULT_ERROR_UNSUPPORTED_FEATURE
8692-
/// + If UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_EVENTS is not supported by the device associated with `hCommand`.
8697+
/// + If ::UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_EVENTS is not supported by the device associated with `hCommand`.
86938698
/// - ::UR_RESULT_ERROR_INVALID_OPERATION
86948699
/// + If ::ur_exp_command_buffer_desc_t::isUpdatable was not set to true on creation of the command buffer `hCommand` belongs to.
86958700
/// + If the command-buffer `hCommand` belongs to has not been finalized.
@@ -8727,7 +8732,7 @@ ur_result_t UR_APICALL urCommandBufferUpdateSignalEventExp(
87278732
/// - ::UR_RESULT_ERROR_INVALID_NULL_HANDLE
87288733
/// + `NULL == hCommand`
87298734
/// - ::UR_RESULT_ERROR_UNSUPPORTED_FEATURE
8730-
/// + If UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_EVENTS is not supported by the device associated with `hCommand`.
8735+
/// + If ::UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_EVENTS is not supported by the device associated with `hCommand`.
87318736
/// - ::UR_RESULT_ERROR_INVALID_OPERATION
87328737
/// + If ::ur_exp_command_buffer_desc_t::isUpdatable was not set to true on creation of the command buffer `hCommand` belongs to.
87338738
/// + If the command-buffer `hCommand` belongs to has not been finalized.

‎source/ur_api.cpp‎

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6369,8 +6369,8 @@ ur_result_t UR_APICALL urBindlessImagesSignalExternalSemaphoreExp(
63696369
/// + `NULL == phCommandBuffer`
63706370
/// - ::UR_RESULT_ERROR_INVALID_CONTEXT
63716371
/// - ::UR_RESULT_ERROR_INVALID_DEVICE
6372-
/// - ::UR_RESULT_ERROR_INVALID_OPERATION
6373-
/// + If `pCommandBufferDesc->isUpdatable` is true and `hDevice` does not support UR_DEVICE_INFO_COMMAND_BUFFER_UPDATE_SUPPORT_EXP.
6372+
/// - ::UR_RESULT_ERROR_UNSUPPORTED_FEATURE
6373+
/// + If `pCommandBufferDesc->isUpdatable` is true and `hDevice` returns 0 for the ::UR_DEVICE_INFO_COMMAND_BUFFER_UPDATE_CAPABILITIES_EXP query.
63746374
/// - ::UR_RESULT_ERROR_OUT_OF_HOST_MEMORY
63756375
/// - ::UR_RESULT_ERROR_OUT_OF_RESOURCES
63766376
ur_result_t UR_APICALL urCommandBufferCreateExp(
@@ -7331,11 +7331,16 @@ ur_result_t UR_APICALL urCommandBufferReleaseCommandExp(
73317331
/// - ::UR_RESULT_ERROR_INVALID_NULL_POINTER
73327332
/// + `NULL == pUpdateKernelLaunch`
73337333
/// - ::UR_RESULT_ERROR_UNSUPPORTED_FEATURE
7334-
/// + If update functionality is not supported by the device.
7334+
/// + If ::UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_KERNEL_ARGUMENTS is not supported by the device, but any of `pUpdateKernelLaunch->numNewMemObjArgs`, `pUpdateKernelLaunch->numNewPointerArgs`, or `pUpdateKernelLaunch->numNewValueArgs` are not zero.
7335+
/// + If ::UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_LOCAL_WORK_SIZE is not supported by the device but `pUpdateKernelLaunch->pNewLocalWorkSize` is not nullptr.
7336+
/// + If ::UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_GLOBAL_WORK_SIZE is not supported by the device but `pUpdateKernelLaunch->pNewGlobalWorkSize` is not nullptr
7337+
/// + If ::UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_GLOBAL_WORK_OFFSET is not supported by the device but `pUpdateKernelLaunch->pNewGlobalWorkOffset` is not nullptr.
7338+
/// + If ::UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_KERNEL_HANDLE is not supported by the device but `pUpdateKernelLaunch->hNewKernel` is not nullptr.
73357339
/// - ::UR_RESULT_ERROR_INVALID_OPERATION
73367340
/// + If ::ur_exp_command_buffer_desc_t::isUpdatable was not set to true on creation of the command buffer `hCommand` belongs to.
73377341
/// + If the command-buffer `hCommand` belongs to has not been finalized.
7338-
/// - ::UR_RESULT_ERROR_INVALID_COMMAND_BUFFER_COMMAND_HANDLE_EXP - "If `hCommand` is not a kernel execution command."
7342+
/// - ::UR_RESULT_ERROR_INVALID_COMMAND_BUFFER_COMMAND_HANDLE_EXP
7343+
/// + If `hCommand` is not a kernel execution command.
73397344
/// - ::UR_RESULT_ERROR_INVALID_MEM_OBJECT
73407345
/// - ::UR_RESULT_ERROR_INVALID_KERNEL_ARGUMENT_INDEX
73417346
/// - ::UR_RESULT_ERROR_INVALID_KERNEL_ARGUMENT_SIZE
@@ -7345,7 +7350,7 @@ ur_result_t UR_APICALL urCommandBufferReleaseCommandExp(
73457350
/// - ::UR_RESULT_ERROR_INVALID_WORK_GROUP_SIZE
73467351
/// - ::UR_RESULT_ERROR_INVALID_VALUE
73477352
/// + If `pUpdateKernelLaunch->hNewKernel` was not passed to the `hKernel` or `phKernelAlternatives` parameters of ::urCommandBufferAppendKernelLaunchExp when this command was created.
7348-
/// + If `pUpdateKernelLaunch->newWorkDim` is different from the current workDim in `hCommand` and, pUpdateKernelLaunch->pNewGlobalWorkSize, or pUpdateKernelLaunch->pNewGlobalWorkOffset are nullptr.
7353+
/// + If `pUpdateKernelLaunch->newWorkDim` is different from the current workDim in `hCommand` and, `pUpdateKernelLaunch->pNewGlobalWorkSize`, or `pUpdateKernelLaunch->pNewGlobalWorkOffset` are nullptr.
73497354
/// - ::UR_RESULT_ERROR_OUT_OF_HOST_MEMORY
73507355
/// - ::UR_RESULT_ERROR_OUT_OF_RESOURCES
73517356
ur_result_t UR_APICALL urCommandBufferUpdateKernelLaunchExp(
@@ -7375,7 +7380,7 @@ ur_result_t UR_APICALL urCommandBufferUpdateKernelLaunchExp(
73757380
/// - ::UR_RESULT_ERROR_INVALID_NULL_POINTER
73767381
/// + `NULL == phSignalEvent`
73777382
/// - ::UR_RESULT_ERROR_UNSUPPORTED_FEATURE
7378-
/// + If UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_EVENTS is not supported by the device associated with `hCommand`.
7383+
/// + If ::UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_EVENTS is not supported by the device associated with `hCommand`.
73797384
/// - ::UR_RESULT_ERROR_INVALID_OPERATION
73807385
/// + If ::ur_exp_command_buffer_desc_t::isUpdatable was not set to true on creation of the command buffer `hCommand` belongs to.
73817386
/// + If the command-buffer `hCommand` belongs to has not been finalized.
@@ -7405,7 +7410,7 @@ ur_result_t UR_APICALL urCommandBufferUpdateSignalEventExp(
74057410
/// - ::UR_RESULT_ERROR_INVALID_NULL_HANDLE
74067411
/// + `NULL == hCommand`
74077412
/// - ::UR_RESULT_ERROR_UNSUPPORTED_FEATURE
7408-
/// + If UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_EVENTS is not supported by the device associated with `hCommand`.
7413+
/// + If ::UR_DEVICE_COMMAND_BUFFER_UPDATE_CAPABILITY_FLAG_EVENTS is not supported by the device associated with `hCommand`.
74097414
/// - ::UR_RESULT_ERROR_INVALID_OPERATION
74107415
/// + If ::ur_exp_command_buffer_desc_t::isUpdatable was not set to true on creation of the command buffer `hCommand` belongs to.
74117416
/// + If the command-buffer `hCommand` belongs to has not been finalized.

0 commit comments

Comments
 (0)