Fixes boss bar being one off for mined blocks

tastybento · tastybento · commit 811641fc8c38 · 2025-04-29T17:31:39.000-07:00
Incrementing was happening after the event was called instead before so the first block was not being counted. #426
diff --git a/src/main/java/world/bentobox/aoneblock/listeners/BlockListener.java b/src/main/java/world/bentobox/aoneblock/listeners/BlockListener.java
@@ -363,6 +363,9 @@ private void process(@NonNull Cancellable e, @NonNull Island i, @Nullable Player
             return;
         }
 
+        // Increment the block number
+        is.incrementBlockNumber();
+
         // Break the block
         if (e instanceof BlockBreakEvent) {
             this.breakBlock(player, block, nextBlock, i);
@@ -381,8 +384,6 @@ private void process(@NonNull Cancellable e, @NonNull Island i, @Nullable Player
             Bukkit.getPluginManager().callEvent(new MagicBlockEvent(i, null, null, block, nextBlock.getMaterial()));
         }
 
-        // Increment the block number
-        is.incrementBlockNumber();
     }
 
     private OneBlockPhase handleGoto(OneBlockIslands is, int gotoBlock) {

Original file line number	Diff line number	Diff line change
`@@ -363,6 +363,9 @@ private void process(@NonNull Cancellable e, @NonNull Island i, @Nullable Player`
`363`	`363`	`return;`
`364`	`364`	`}`
`365`	`365`
	`366`	`+ // Increment the block number`
	`367`	`+ is.incrementBlockNumber();`
	`368`	`+`
`366`	`369`	`// Break the block`
`367`	`370`	`if (e instanceof BlockBreakEvent) {`
`368`	`371`	`this.breakBlock(player, block, nextBlock, i);`
`@@ -381,8 +384,6 @@ private void process(@NonNull Cancellable e, @NonNull Island i, @Nullable Player`
`381`	`384`	`Bukkit.getPluginManager().callEvent(new MagicBlockEvent(i, null, null, block, nextBlock.getMaterial()));`
`382`	`385`	`}`
`383`	`386`
`384`		`- // Increment the block number`
`385`		`- is.incrementBlockNumber();`
`386`	`387`	`}`
`387`	`388`
`388`	`389`	`private OneBlockPhase handleGoto(OneBlockIslands is, int gotoBlock) {`