Fixed home setting on island creation warning.

Author: tastybento

src/main/java/world/bentobox/bentobox/database/objects/Island.java

@@ -1401,7 +1401,7 @@ public void setSpawnPoint(Environment islandType, Location l) {
         spawnPoint.compute(islandType, (key, value) -> {
             if (value == null || !value.equals(l)) {
                 setChanged(); // Call setChanged only if the value is updated.
-                return l;
+                return l; // clone??
             }
             return value;
         });

src/main/java/world/bentobox/bentobox/managers/IslandsManager.java

@@ -1829,14 +1829,25 @@ public Island getPrimaryIsland(World world, UUID uuid) {
     }
 
     public CompletableFuture<Void> homeTeleportAsync(Island island, User user) {
+        return homeTeleportAsync(island, user, false);
+    }
+
+    /**
+     * Teleport the user home
+     * @param island island
+     * @param user user
+     * @param newIsland true if this is a new island first time teleport
+     * @return future when it is done
+     */
+    public CompletableFuture<Void> homeTeleportAsync(Island island, User user, boolean newIsland) {
         Location loc = island.getHome("");
         user.sendMessage("commands.island.go.teleport");
         goingHome.add(user.getUniqueId());
         readyPlayer(user.getPlayer());
         return Util.teleportAsync(Objects.requireNonNull(user.getPlayer()), loc).thenAccept(b -> {
             // Only run the commands if the player is successfully teleported
             if (Boolean.TRUE.equals(b)) {
-                teleported(island.getWorld(), user, "", false, island);
+                teleported(island.getWorld(), user, "", newIsland, island);
                 this.setPrimaryIsland(user.getUniqueId(), island);
             } else {
                 // Remove from mid-teleport set

src/main/java/world/bentobox/bentobox/managers/island/NewIsland.java

@@ -267,7 +267,8 @@ public void newIsland(Island oldIsland) throws IOException {
     private void postCreationTask(Island oldIsland) {
         // Set initial spawn point if one exists
         if (island.getSpawnPoint(Environment.NORMAL) != null) {
-            plugin.getIslands().setHomeLocation(user, island.getSpawnPoint(Environment.NORMAL));
+            plugin.getIslands().setHomeLocation(island, island.getSpawnPoint(Environment.NORMAL), "");
+            plugin.getIslands().setPrimaryIsland(user.getUniqueId(), island);
         }
         // If player is online, handle teleportation and movement
         if (user.isOnline()) {
@@ -277,7 +278,7 @@ private void postCreationTask(Island oldIsland) {
                 user.getPlayer().setVelocity(new Vector(0, 0, 0));
                 user.getPlayer().setFallDistance(0F);
                 // Teleport player after island is built, then tidy up
-                plugin.getIslands().homeTeleportAsync(world, user.getPlayer(), true).thenRun(() -> tidyUp(oldIsland));
+                plugin.getIslands().homeTeleportAsync(island, user, true).thenRun(() -> tidyUp(oldIsland));
                 return;
             } else {
                 // Notify player they can teleport to their island