Null handling

Author: tastybento

src/main/java/world/bentobox/bentobox/api/user/User.java

@@ -241,7 +241,9 @@ public PlayerInventory getInventory() {
      */
     @NonNull
     public Location getLocation() {
-        return Objects.requireNonNull(player, "getLocation can only be called for online players!").getLocation();
+        Player p = Objects.requireNonNull(player, "getLocation can only be called for online players!");
+        Location loc = p.getLocation();
+        return Objects.requireNonNull(loc, "Player's location cannot be null! The player may not have a location (has never played).");
     }
 
     /**

src/main/java/world/bentobox/bentobox/database/objects/Island.java

@@ -851,7 +851,11 @@ private boolean playerIsVisitor(Player player) {
         if (player.getGameMode() == GameMode.SPECTATOR) {
             return false;
         }
-
+        Location loc = player.getLocation();
+        if (location == null) {
+            // This will only be true if the player has never played.  Allow them to be a visitor.
+            return true;
+        }
         return onIsland(player.getLocation()) && getRank(User.getInstance(player)) == RanksManager.VISITOR_RANK;
     }
 

src/main/java/world/bentobox/bentobox/database/yaml/YamlDatabaseHandler.java

@@ -598,7 +598,7 @@ private Object serialize(@Nullable Object object) {
         return switch (object) {
             case null -> "null";
 
-            // UUID has it's own serialization, that is not picked up automatically
+            // UUID has its own serialization, that is not picked up automatically
             case UUID uuid -> object.toString();
 
             // Only the world name is needed for worlds