Unable to set icons via the gui (challenge gui and biome gui)

[shezzaleenders]

Expected behavior

Expected behaviour would be to click the change icon button in the gui, then click on an item in my inventory, then the icon would be set to that item.

Observed/Actual behavior

Nothing happens when I click on the icon change button and an item in my inventory.

Steps/models to reproduce

Hovering over the ICON button shows a tooltip that says "Click to change".

Once I click on this button it now switches to "Click on an item in your inventory".

If I click on an item, nothing happens. No errors in chat, in console, etc. And the tooltip continues to display "Click on an item in your inventory".

BentoBox version

[16:54:50 INFO]: Running PAPER 1.21.4.
[16:54:50 INFO]: (1.21.4-232-12d8fe0 (MC: 1.21.4))
[16:54:50 INFO]: BentoBox version: 3.10.0
[16:54:50 INFO]: Database: JSON
[16:54:50 INFO]: Loaded Game Worlds:
[16:54:50 INFO]: bskyblock_world (BSkyBlock): Overworld, Nether, The End
[16:54:50 INFO]: Loaded Addons:
[16:54:50 INFO]: Biomes 2.2.1 (ENABLED)
[16:54:50 INFO]: BSkyBlock 1.19.1 (ENABLED)
[16:54:50 INFO]: Challenges 1.5.2 (ENABLED)
[16:54:50 INFO]: ControlPanel 1.14.0 (ENABLED)
[16:54:50 INFO]: DimensionalTrees 1.8.0 (ENABLED)
[16:54:50 INFO]: Level 2.22.0 (ENABLED)
[16:54:50 INFO]: Limits 1.27.1 (ENABLED)
[16:54:50 INFO]: TwerkingForTrees 1.5.2 (ENABLED)
[16:54:50 INFO]: Warps 1.17.0 (ENABLED)

Plugin list

No response

Other

No response

[tastybento]

The problem is that BentoBox 3.10.x is for 1.21.5 and later. There are recent changes that made support for 1.21.4 incompatible, like this. I recommend you try an older BentoBox version, or update your server. Maybe https://github.com/BentoBoxWorld/BentoBox/releases/tag/3.8.1

[lukesky19]

I have this same issue on 1.21.10. This affects all panels from my testing, but I first experienced it with the blueprint (/bsbadmin blueprint) panel. The issue started with this Commit.

The commit changes it so panels are no longer passed the click event when the player's inventory is clicked and only the top inventory/panel itself. So the panel's click handler never get sent the event for clicking an item in the player's inventory to change the icons.

Another side effect of the change, is players can shift-click items into and drag items across the panel and are unable to get them back, so they are deleted when the panel is closed.

BentoBox version

[13:11:12 INFO]: Running PAPER 1.21.10.
[13:11:12 INFO]: (1.21.10-117-df4b668 (MC: 1.21.10))
[13:11:12 INFO]: BentoBox version: 3.11.0
[13:11:12 INFO]: Database: JSON
[13:11:12 INFO]: Loaded Game Worlds:
[13:11:12 INFO]: bskyblock_world (BSkyBlock): Overworld
[13:11:12 INFO]: Loaded Addons:
[13:11:12 INFO]: Bank 1.9.0 (ENABLED)
[13:11:12 INFO]: Biomes 2.2.1 (ENABLED)
[13:11:12 INFO]: Border 4.5.1 (ENABLED)
[13:11:12 INFO]: BSkyBlock 1.19.0 (ENABLED)
[13:11:12 INFO]: Chat 1.3.0 (ENABLED)
[13:11:12 INFO]: ControlPanel 1.14.0 (ENABLED)
[13:11:12 INFO]: IslandFly 1.14.2-SNAPSHOT-LOCAL (ENABLED)
[13:11:12 INFO]: Level 2.22.1-SNAPSHOT-LOCAL (ENABLED)
[13:11:12 INFO]: Likes 2.5.0 (ENABLED)
[13:11:12 INFO]: Limits 1.27.1-SNAPSHOT-LOCAL (ENABLED)
[13:11:12 INFO]: MagicCobblestoneGenerator 2.7.0 (ENABLED)
[13:11:12 INFO]: MoreFlags 1.1 (ENABLED)
[13:11:12 INFO]: RoseStackerHook 1.3.0-SNAPSHOT-LOCAL (ENABLED)
[13:11:12 INFO]: ShortcutsAddon 1.0.0 (ENABLED)
[13:11:12 INFO]: VoidTeleportAddon 1.0.0 (ENABLED)
[13:11:12 INFO]: Warps 1.16.0 (ENABLED)

[tastybento]

I have reverted 949e55f because this is not the only issue it caused.