Merge pull request #127 from BentoBoxWorld/126_free_fly_bug

126 free fly bug

Author: tastybento

pom.xml

@@ -50,7 +50,7 @@
         <!-- Revision variable removes warning about dynamic version -->
         <revision>${build.version}-SNAPSHOT</revision>
         <!-- This allows to change between versions and snapshots. -->
-        <build.version>1.14.1</build.version>
+        <build.version>1.14.2</build.version>
         <build.number>-LOCAL</build.number>
         <sonar.projectKey>BentoBoxWorld_Boxed</sonar.projectKey>
         <sonar.organization>bentobox-world</sonar.organization>

src/main/java/world/bentobox/islandfly/listeners/FlyListener.java

@@ -9,7 +9,6 @@
 import org.bukkit.event.player.PlayerToggleFlightEvent;
 import org.eclipse.jdt.annotation.NonNull;
 
-import world.bentobox.bentobox.BentoBox;
 import world.bentobox.bentobox.api.events.island.IslandEnterEvent;
 import world.bentobox.bentobox.api.events.island.IslandExitEvent;
 import world.bentobox.bentobox.api.localization.TextVariables;
@@ -45,11 +44,10 @@ public void onToggleFlight(final PlayerToggleFlightEvent event) {
             user.sendMessage("islandfly.not-allowed");
         } else {
             addon.getIslands().getIslandAt(user.getLocation())
-                    .filter(i -> i.getMemberSet().contains(user.getUniqueId())).ifPresent(
-                            is -> {
-                                user.putMetaData(ISLANDFLY + is.getUniqueId(), new MetaDataValue(event.isFlying()));
-                                addon.getPlayers().savePlayer(user.getUniqueId());
-                            });
+                    .filter(i -> i.getMemberSet().contains(user.getUniqueId())).ifPresent(is -> {
+                        user.putMetaData(ISLANDFLY + is.getUniqueId(), new MetaDataValue(event.isFlying()));
+                        addon.getPlayers().savePlayer(user.getUniqueId());
+                    });
 
         }
     }
@@ -72,8 +70,10 @@ public void onEnterIsland(final IslandEnterEvent event) {
         final User user = User.getInstance(event.getPlayerUUID());
         user.getMetaData(ISLANDFLY + event.getIsland().getUniqueId())
                 .ifPresent(mdv -> {
-                    user.getPlayer().setAllowFlight(true);
-                    user.getPlayer().setFlying(mdv.asBoolean());
+                    if (mdv.asBoolean()) {
+                        user.getPlayer().setAllowFlight(true);
+                        user.getPlayer().setFlying(mdv.asBoolean());
+                    }
                 });
         // Wait until after arriving at the island
         Bukkit.getScheduler().runTask(this.addon.getPlugin(), () -> checkUser(user));