Fix public tickets toggle

Author: MeshanKhosla

src/components/queue/CreateTicketForm.tsx

@@ -80,7 +80,9 @@ const CreateTicketForm = (props: CreateTicketFormProps) => {
       setIsPublic(false);
     } else {
       setDescription(STARTER_CONCEPTUAL_TICKET_DESCRIPTION);
-      setIsPublic(true);
+      if (arePublicTicketsEnabled) {
+        setIsPublic(true);
+      }
     }
   };
 
@@ -220,8 +222,8 @@ const CreateTicketForm = (props: CreateTicketFormProps) => {
               <Tooltip
                 hasArrow
                 label='Public tickets can be joined by other students. This is great for group work 
-						   or conceptual questions! If your ticket is public, we are more likely to 
-						   help you for a longer time.'
+               or conceptual questions! If your ticket is public, we are more likely to 
+               help you for a longer time.'
                 bg='gray.300'
                 color='black'
               >

src/components/queue/TicketQueue.tsx

@@ -171,7 +171,7 @@ const TicketQueue = (props: TicketQueueProps) => {
   const isGetTicketsLoading =
     isGetOpenTicketsLoading || isGetAssignedTicketsLoading || isGetPendingTicketsLoading || isGetAbsentTicketsLoading;
 
-  /** Don't show priority tickets on the Open tab since they are in the  */
+  /** Don't show priority tickets on the Open tab */
   const removePriorityTickets = (tickets: TicketWithNames[]) => {
     return tickets.filter(ticket => !ticket.isPriority);
   };

src/components/ticket-page/TicketButtons.tsx

@@ -3,6 +3,8 @@ import { Button, Flex, Spinner } from '@chakra-ui/react';
 import { TicketStatus, TicketType, UserRole } from '@prisma/client';
 import { TicketWithNames } from '../../server/trpc/router/ticket';
 import { trpc } from '../../utils/trpc';
+import useSiteSettings from '../../utils/hooks/useSiteSettings';
+import { SiteSettings, SiteSettingsValues } from '@prisma/client';
 
 interface TicketCardProps {
   ticket: TicketWithNames;
@@ -25,6 +27,8 @@ const TicketButtons = (props: TicketCardProps) => {
 
   const [areButtonsLoading, setAreButtonsLoading] = useState(false);
   const [areButtonsDisabled, setAreButtonsDisabled] = useState(false);
+  const { siteSettings } = useSiteSettings();
+
   const approveTicketsMutation = trpc.ticket.approveTickets.useMutation();
   const resolveTicketsMutation = trpc.ticket.resolveTickets.useMutation();
   const requeueTicketsMutation = trpc.ticket.requeueTickets.useMutation();
@@ -155,6 +159,10 @@ const TicketButtons = (props: TicketCardProps) => {
     )();
   };
 
+  if (siteSettings === undefined) {
+    return <></>;
+  }
+
   return (
     <Flex justifyContent='center' flexDirection={['column', 'column', 'column', 'row']}>
       <Button
@@ -249,6 +257,7 @@ const TicketButtons = (props: TicketCardProps) => {
         onClick={handleToggleIsPublic}
         colorScheme='teal'
         hidden={
+          siteSettings?.get(SiteSettings.ARE_PUBLIC_TICKETS_ENABLED) === SiteSettingsValues.FALSE ||
           isAbsent ||
           isResolved ||
           isClosed ||

src/components/ticket-page/TicketView.tsx

@@ -2,7 +2,6 @@ import { useState, useEffect } from 'react';
 import { useToast } from '@chakra-ui/react';
 import Router, { useRouter } from 'next/router';
 import { trpc } from '../../utils/trpc';
-import { TicketWithNames } from '../../server/trpc/router/ticket';
 import { useSession } from 'next-auth/react';
 import { UserRole } from '@prisma/client';
 import InnerTicket from './InnerTicket';

src/server/trpc/router/ticket.ts

@@ -82,15 +82,25 @@ export const ticketRouter = router({
         return;
       }
 
+      const publicTicketsEnabled = await ctx.prisma.settings.findUnique({
+        where: {
+          setting: SiteSettings.ARE_PUBLIC_TICKETS_ENABLED,
+        },
+      });
+
+      // Ensure that public tickets are enabled if the ticket is public. This is necessary because
+      //  the client might have a stale value for the setting.
+      const isPublic = publicTicketsEnabled?.value === SiteSettingsValues.TRUE ? input.isPublic : false;
+
       // If a ticket is made with a priority assigment, it's a priority ticket
       const isPriority = assignment?.isPriority;
 
       const ticket = await ctx.prisma.ticket.create({
         data: {
           description: input.description,
-          isPublic: input.isPublic ?? false,
+          isPublic: isPublic,
           locationDescription: input.locationDescription,
-          usersInGroup: input.isPublic ? { connect: [{ id: ctx.session.user.id }] } : undefined,
+          usersInGroup: isPublic ? { connect: [{ id: ctx.session.user.id }] } : undefined,
           isPriority: isPriority,
           ticketType: input.ticketType,
           assignment: {
@@ -122,7 +132,7 @@ export const ticketRouter = router({
       });
 
       // Add the ticket to User.ticketsJoined if it is public
-      if (input.isPublic) {
+      if (isPublic) {
         await ctx.prisma.user.update({
           where: { id: ctx.session.user.id },
           data: {