cleaning

Author: ducky64

edg/abstract_parts/AbstractComparator.py

@@ -33,8 +33,7 @@ class VoltageComparator(GeneratorBlock):
     tolerance is specified wide enough.
     The output is logic high when the input exceeds the trip voltage by default,
     this can be inverted with the invert parameter.
-    Optionally this can take a reference voltage input, otherwise this generates a 1:1
-    divider by default.
+    Optionally this can take a reference voltage input, otherwise this generates a divider.
 
     TODO: maybe a version that takes an input analog signal?
     """

edg/abstract_parts/PowerCircuits.py

@@ -228,46 +228,3 @@ def contents(self):
                 'control': DigitalSink(),
                 'gnd': Ground(),
             })
-
-
-class FetPrecharge(Block):
-    """Precharge circuit that limits inrush current with an resistor, then provides low supply impedance
-    by closing a power FET.
-
-    TODO: calculate power rating needed for some capacitance instead of spec'ing for DC"""
-    @init_in_parent
-    def __init__(self, *, precharge_resistance: RangeLike = 100*Ohm(tol=0.1),
-                 pull_resistance: RangeLike = 10*kOhm(tol=0.05),
-                 max_rds: FloatLike = 1*Ohm, clamp_voltage: RangeLike = RangeExpr.ZERO):
-        super().__init__()
-        self.gnd = self.Port(Ground.empty(), [Common])
-        self.pwr_in = self.Port(VoltageSink.empty(), [Input, Power])
-        self.pwr_out = self.Port(VoltageSource.empty(), [Output])
-        self.control = self.Port(DigitalSink.empty())
-
-        self.precharge_resistance = self.ArgParameter(precharge_resistance)
-        self.pull_resistance = self.ArgParameter(pull_resistance)
-        self.max_rds = self.ArgParameter(max_rds)
-        self.clamp_voltage = self.ArgParameter(clamp_voltage)
-
-    def contents(self):
-        super().contents()
-
-        self.switch = self.Block(HighSideSwitch(
-            pull_resistance=self.pull_resistance, max_rds=self.max_rds, clamp_voltage=self.clamp_voltage))
-        self.connect(self.switch.gnd, self.gnd)
-        self.connect(self.switch.pwr, self.pwr_in)
-        self.connect(self.switch.control, self.control)
-
-        (self.res_forcein, self.res, self.res_forceout), _ = self.chain(
-            self.pwr_in,
-            self.Block(ForcedVoltageCurrentDraw(0*Amp(tol=0))),  # current draw modeled by switch
-            self.Block(SeriesPowerResistor(resistance=self.precharge_resistance)),
-            self.Block(ForcedVoltageCurrentDraw(
-                VoltageLink._supply_voltage_range(self.gnd, self.pwr_in) / self.precharge_resistance)),
-        )
-
-        self.merge = self.Block(MergedVoltageSource()).connected_from(
-            self.switch.output, self.res_forceout.pwr_out
-        )
-        self.connect(self.merge.pwr_out, self.pwr_out)

edg/abstract_parts/__init__.py

@@ -73,7 +73,7 @@
 from .AbstractPowerConverters import BuckConverter, DiscreteBuckConverter, BoostConverter, DiscreteBoostConverter
 from .AbstractPowerConverters import BuckConverterPowerPath, BoostConverterPowerPath, BuckBoostConverterPowerPath
 from .PowerCircuits import HalfBridge, FetHalfBridge, HalfBridgeIndependent, HalfBridgePwm, FetHalfBridgeIndependent,\
-    FetHalfBridgePwmReset, RampLimiter, FetPrecharge
+    FetHalfBridgePwmReset, RampLimiter
 from .AbstractLedDriver import LedDriver, LedDriverPwm, LedDriverSwitchingConverter
 from .AbstractFuse import Fuse, SeriesPowerFuse, PptcFuse, FuseStandardFootprint, TableFuse, SeriesPowerPptcFuse
 from .AbstractCrystal import Crystal, TableCrystal, OscillatorReference, CeramicResonator

edg/core/Range.py

@@ -165,14 +165,14 @@ def __add__(self, other: Union['Range', float]) -> 'Range':
       return NotImplemented
 
   def __sub__(self, other: float) -> 'Range':
-    # Range-range subtract semantics not defined
+    # Range-range subtract semantics not defined as tolerance handling is not intuitive
     if isinstance(other, (float, int)):
       return Range(self.lower - other, self.upper - other)
     else:
       return NotImplemented
 
   def __rsub__(self, other: float) -> 'Range':
-    # Range-range subtract semantics not defined
+    # Range-range subtract semantics not defined as tolerance handling is not intuitive
     if isinstance(other, (float, int)):
       return Range(other - self.upper, other - self.lower)
     else:

edg/jlcparts/JlcPartsDiode.py

@@ -42,7 +42,7 @@ def _entry_to_table_row(cls, row_dict: Dict[PartsTableColumn, Any], filename: st
             row_dict[cls.REVERSE_RECOVERY] = reverse_recovery
 
             return row_dict
-        except (KeyError, TypeError, PartParserUtil.ParseError) as e:
+        except (KeyError, TypeError, PartParserUtil.ParseError):
             return None
 
 

edg/parts/AnalogSwitch_Nlas4157.py

@@ -1,3 +1,5 @@
+from deprecated import deprecated
+
 from ..abstract_parts import *
 from .JlcPart import JlcPart
 
@@ -49,6 +51,7 @@ def contents(self):
     self.assign(self.actual_basic_part, False)
 
 
+@deprecated("obsolete part")
 class Nlas4157(AnalogSwitch):
   """NLAS4157 2:1 analog switch, 1ohm Ron, in SOT-363. OBSOLETE.
   Pin compatible with: