Skip to content

Commit fc014b1

Browse files
committed
test(julienne): append to diagnostics strings
This commit appends the text from veggies assertions "message" argument to test diagnoses in the corresponding Julienne tests. For example, a veggies assertion of the form assert_equals(actual, expected, message) becomes a Julienne test diagnosis of the following form: (actual .equalsExpected. expected) // message
1 parent fe32fbd commit fc014b1

File tree

5 files changed

+39
-16
lines changed

5 files changed

+39
-16
lines changed

test/julienne/prif_co_broadcast_test_m.F90

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,14 @@
22

33
module prif_co_broadcast_test_m
44
use prif, only : prif_co_broadcast, prif_num_images, prif_this_image_no_coarray
5-
use julienne_m, only : test_description_t, test_diagnosis_t, test_result_t , test_t, operator(.expect.), operator(.equalsExpected.)
5+
use julienne_m, only : &
6+
test_description_t &
7+
,test_diagnosis_t &
8+
,test_result_t &
9+
,test_t &
10+
,operator(//) &
11+
,operator(.expect.) &
12+
,operator(.equalsExpected.)
613
#if ! HAVE_PROCEDURE_ACTUAL_FOR_POINTER_DUMMY
714
use julienne_m, only : diagnosis_function_i
815
#endif
@@ -95,7 +102,7 @@ function broadcast_derived_type() result(test_diagnosis)
95102
object = object_t(me, .false., "gooey", me*(1.,0.))
96103
call prif_co_broadcast(object, source_image=ni)
97104
associate(expected_object => object_t(ni, .false., "gooey", ni*(1.,0.)))
98-
test_diagnosis = .expect. (object == expected_object)
105+
test_diagnosis = .expect. (object == expected_object) // "co_broadcast derived type"
99106
end associate
100107
end function
101108

test/julienne/prif_coarray_inquiry_test_m.F90

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ module prif_coarray_inquiry_test_m
99
prif_ucobound_no_dim, prif_ucobound_with_dim, &
1010
prif_coshape
1111
use julienne_m, only: &
12-
operator(.all.) &
12+
operator(//) &
13+
,operator(.all.) &
1314
,operator(.also.) &
1415
,operator(.equalsExpected.) &
1516
,operator(.expect.) &
@@ -126,24 +127,24 @@ impure elemental function check_cobound(corank) result(test_diagnosis)
126127
test_diagnosis = .expect. c_associated(allocated_memory)
127128

128129
call prif_size_bytes(coarray_handle, data_size=query_size)
129-
test_diagnosis = test_diagnosis .also. (query_size .equalsExpected. data_size) ! "prif_size_bytes is valid"
130+
test_diagnosis = test_diagnosis .also. (query_size .equalsExpected. data_size) // "prif_size_bytes is valid"
130131

131132
call prif_lcobound_no_dim(coarray_handle, tmp_bounds)
132-
test_diagnosis = test_diagnosis .also. (.all. (tmp_bounds .equalsExpected. lcobounds)) ! "prif_lcobound_no_dim is valid"
133+
test_diagnosis = test_diagnosis .also. (.all. (tmp_bounds .equalsExpected. lcobounds)) // "prif_lcobound_no_dim is valid"
133134

134135
call prif_ucobound_no_dim(coarray_handle, tmp_bounds)
135-
test_diagnosis = test_diagnosis .also. (.all. (tmp_bounds .equalsExpected. ucobounds)) ! "prif_ucobound_no_dim is valid"
136+
test_diagnosis = test_diagnosis .also. (.all. (tmp_bounds .equalsExpected. ucobounds)) // "prif_ucobound_no_dim is valid"
136137

137138
do i = 1, corank
138139
call prif_lcobound_with_dim(coarray_handle, i, tmp_bound)
139-
test_diagnosis = test_diagnosis .also. (tmp_bound .equalsExpected. lcobounds(i)) ! "prif_lcobound_with_dim is valid"
140+
test_diagnosis = test_diagnosis .also. (tmp_bound .equalsExpected. lcobounds(i)) // "prif_lcobound_with_dim is valid"
140141

141142
call prif_ucobound_with_dim(coarray_handle, i, tmp_bound)
142-
test_diagnosis = test_diagnosis .also. (tmp_bound .equalsExpected. ucobounds(i)) ! "prif_ucobound_with_dim is valid"
143+
test_diagnosis = test_diagnosis .also. (tmp_bound .equalsExpected. ucobounds(i)) // "prif_ucobound_with_dim is valid"
143144
end do
144145

145146
call prif_coshape(coarray_handle, sizes)
146-
test_diagnosis = test_diagnosis .also. (.all. ((ucobounds - lcobounds + 1) .equalsExpected. sizes)) ! "prif_coshape is valid"
147+
test_diagnosis = test_diagnosis .also. (.all. ((ucobounds - lcobounds + 1) .equalsExpected. sizes)) // "prif_coshape is valid"
147148

148149
call prif_deallocate_coarray([coarray_handle])
149150
end function

test/julienne/prif_image_queries_test_m.F90

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@ module prif_image_queries_test_m
55
use prif, only : prif_image_status, prif_stopped_images, prif_failed_images, PRIF_STAT_FAILED_IMAGE, PRIF_STAT_STOPPED_IMAGE
66
use prif, only : prif_num_images
77
use julienne_m, only: &
8-
operator(.all.) &
8+
operator(//) &
9+
,operator(.all.) &
910
,operator(.also.) &
1011
,operator(.isAtLeast.) &
1112
,operator(.isAtMost.) &
@@ -73,7 +74,8 @@ function check_image_status() result(test_diagnosis)
7374
integer(c_int) :: image_status
7475

7576
call prif_image_status(1, image_status=image_status)
76-
test_diagnosis = .expect. (any(image_status == [0, PRIF_STAT_FAILED_IMAGE, PRIF_STAT_STOPPED_IMAGE])) ! TODO: replace with .any. once Juliennes supports it
77+
test_diagnosis = .expect. (any(image_status == [0, PRIF_STAT_FAILED_IMAGE, PRIF_STAT_STOPPED_IMAGE])) & ! TODO: replace with .any. once Juliennes supports it
78+
// "permitted image status"
7779
end function
7880

7981
function valid_image_list(nums) result(test_diagnosis)
@@ -87,7 +89,7 @@ function valid_image_list(nums) result(test_diagnosis)
8789
.also. (size(nums) .isAtMost. ni) &
8890
.also. (.all. (nums .isAtLeast. 1)) &
8991
.also. (.all. (nums .isAtMost. ni)) &
90-
.also. (.all. (nums(1:size(nums)-1) .lessThan. nums(2:size(nums))))
92+
.also. (.all. (nums(1:size(nums)-1) .lessThan. nums(2:size(nums)))) // "valid stopped image"
9193
end function
9294

9395
function check_stopped_images() result(test_diagnosis)

test/julienne/prif_num_images_test_m.F90

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,13 @@
22

33
module prif_num_images_test_m
44
use prif, only : prif_num_images
5-
use julienne_m, only: test_description_t, test_diagnosis_t, test_result_t, test_t, operator(.isAtLeast.)
5+
use julienne_m, only: &
6+
operator(//) &
7+
,operator(.isAtLeast.) &
8+
,test_description_t &
9+
,test_diagnosis_t &
10+
,test_result_t &
11+
,test_t
612
#if ! HAVE_PROCEDURE_ACTUAL_FOR_POINTER_DUMMY
713
use julienne_m, only: diagnosis_function_i
814
#endif
@@ -54,7 +60,7 @@ function check_num_images_valid() result(test_diagnosis)
5460
type(test_diagnosis_t) test_diagnosis
5561
integer num_imgs
5662
call prif_num_images(num_images=num_imgs)
57-
test_diagnosis = num_imgs .isAtLeast. 1
63+
test_diagnosis = (num_imgs .isAtLeast. 1) // "positive number of images"
5864
end function
5965

6066
end module prif_num_images_test_m

test/julienne/prif_this_image_no_coarray_test_m.F90

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,14 @@
22

33
module prif_this_image_no_coarray_test_m
44
use prif, only : prif_this_image_no_coarray, prif_num_images, prif_co_sum
5-
use julienne_m, only: test_description_t, test_diagnosis_t, test_result_t, test_t, operator(.all.), operator(.equalsExpected.)
5+
use julienne_m, only: &
6+
operator(//) &
7+
,operator(.all.) &
8+
,operator(.equalsExpected.) &
9+
,test_description_t &
10+
,test_diagnosis_t &
11+
,test_result_t &
12+
,test_t
613
#if ! HAVE_PROCEDURE_ACTUAL_FOR_POINTER_DUMMY
714
use julienne_m, only: diagnosis_function_i
815
#endif
@@ -58,7 +65,7 @@ function check_this_image_set() result(test_diagnosis)
5865
call prif_num_images(num_images=ni)
5966
image_numbers = [(merge(0, me, me/=i), i = 1, ni)]
6067
call prif_co_sum(image_numbers)
61-
test_diagnosis = .all. (image_numbers .equalsExpected. [(i, i = 1, ni)])
68+
test_diagnosis = .all. (image_numbers .equalsExpected. [(i, i = 1, ni)]) // "correct image set"
6269
end function
6370

6471
end module prif_this_image_no_coarray_test_m

0 commit comments

Comments
 (0)