Skip to content

Commit 92f631d

Browse files
committed
fix: correct formatting of alert messages in Slack notifications
1 parent 793c966 commit 92f631d

File tree

2 files changed

+25
-1
lines changed

2 files changed

+25
-1
lines changed

litellm/integrations/SlackAlerting/slack_alerting.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1371,7 +1371,7 @@ async def send_alert(
13711371
if alert_type == "daily_reports" or alert_type == "new_model_added":
13721372
formatted_message = alert_type_formatted + message
13731373
else:
1374-
formatted_message = f"{alert_type_formatted}\n Level: `{level}`\nTimestamp: `{current_time}`\n\nMessage: {message}"
1374+
formatted_message = f"{alert_type_formatted}\nLevel: `{level}`\nTimestamp: `{current_time}`\n\nMessage: {message}"
13751375

13761376
if kwargs:
13771377
for key, value in kwargs.items():

tests/test_litellm/integrations/SlackAlerting/test_slack_alerting.py

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -172,3 +172,27 @@ def test_update_values_starts_periodic_task(self, mock_create_task):
172172

173173
self.slack_alerting.update_values(alerting_args={"slack_alerting": "True"})
174174
assert self.slack_alerting.periodic_started == True
175+
176+
@patch("litellm.integrations.SlackAlerting.slack_alerting.datetime")
177+
def test_alert_type_in_formatted_message(self, mock_datetime):
178+
# Setup mocks
179+
mock_datetime.now.return_value.strftime.return_value = "12:34:56"
180+
181+
# Import required types
182+
from litellm.types.integrations.slack_alerting import AlertType
183+
184+
# Create a simple test message to check formatting
185+
alert_type = AlertType.llm_exceptions
186+
level = "Medium"
187+
message = "Test alert message"
188+
current_time = "12:34:56"
189+
190+
# Test the specific formatting logic we're interested in
191+
alert_type_formatted = f"Alert type: `{alert_type}`\n"
192+
formatted_message = f"{alert_type_formatted}\n Level: `{level}`\nTimestamp: `{current_time}`\n\nMessage: {message}"
193+
194+
# Verify alert_type is in the formatted message as expected
195+
self.assertIn("Alert type: `AlertType.llm_exceptions`", formatted_message)
196+
self.assertIn("Level: `Medium`", formatted_message)
197+
self.assertIn("Timestamp: `12:34:56`", formatted_message)
198+
self.assertIn("Message: Test alert message", formatted_message)

0 commit comments

Comments
 (0)