Circles on every menu item

[gusnan]

Setup (please complete the following information):

• Distribution: Debian
• Distribution release: Sid and trixie
• Geeqie version [geeqie --version]: Latest Git

Describe the bug
The latest git shows icons for every menu item, which looks rather ugly. Is this intended? (It's the same if using the new menu style).

To reproduce
Simply run the program.

Expected behavior
No circles for every menu item.

Screenshots

[caclark]

That looks strange.
This is what I see:

[gusnan]

@caclark Thanks - then it's probably just me.

[gusnan]

Closing, It seems to be just me.

[alienbob]

The same happens to every user of Slackware Linux who installed the latest Geeqie 2.7 release. The menus look just fine in Geeqie 2.6.1 which we had previously in Slackware Linux.

[gusnan]

Re-opening, since Slackware hasn't got anything to do with the Debian packaging, and thus, it's not just me.

[qarkai]

@gusnan can you bisect this? I use separate "global" menu, so not able to find bad commit.

[gusnan]

Bisecting, it looks to me like 0387152 is the bad one.

[qarkai]

Looks like 022d213 causes this.
@caclark it seems that top menu items should stay with nullptr for stock_id.

@gusnan you can check this by replacing PIXBUF_INLINE_ICON_PLACEHOLDER with nullptr in

geeqie/src/layout-util.cc

Line 2452 in 91d2337

{ "FileMenu", PIXBUF_INLINE_ICON_PLACEHOLDER, N_("_File"), nullptr, nullptr, nullptr },

[gusnan]

@qarkai sorry, no difference for me unfortunately.

[qarkai]

Bisecting, it looks to me like 0387152 is the bad one.

This commit just restores icon files. They were removed in b4059b4. What about commit that precedes b4059b4?

[gusnan]

What about commit that precedes b4059b4?

You mean the commit that preceeds it, 78794e8 ? - In that case, thats also bad (showing the icons in the menus).

[qarkai]

You mean the commit that preceeds it, 78794e8 ? - In that case, thats also bad (showing the icons in the menus).

Ok, can you bisect it again knowing that 78794e8 is bad commit?