Cancel previous build/cancel deployment when action is cancelled

[shouze]

When you push/update some branch more quickly than vercel is able to build them... would be nice to cancel previous builds instead of letting them queued until completion.

I don't know how we could proceed at the moment, I just want to open the discussion at this point to find a way to achieve that.

[BetaHuhn]

Yeah seems reasonable.

We could use the Vercel API to cancel a deployment.

On each run we would have to check if there’s a previous unfinished deployment for that branch and then cancel it before creating a new one.

PR welcome!

[shouze]

Edit: for an unknown reason the vercel build is not canceled either when I cancel github workflow manually. Maybe because I was still injecting my custom RUN_ID?

[shouze]

Edit2: Even if I revert custom RUN_ID, when I manually cancel the Github Workflow I still have the very same 404 error on cleanup

[BetaHuhn]

I chose to append RUN_ID with Date.now() as RUN_ID will be the same if you re-run a Workflow. By appending the time, it will be unique every time it runs. The calculated value will be the same during the run of the workflow.

It worked when I tested it by cancelling the workflow run manually, I don't know why you are getting a 404. Maybe it didn't have enough time to create the deployment when you cancelled the run?

[shouze]

Yes undestood regarding RUN_ID, but when you push over and over on the same branch, it will generate distincts RUN_ID values and in fact this is not what we want. For PR my guess is that we want a RUN_ID with is the PR uniquement identifier or something like that.

About the 404, yes very weird, it had time to created Vercel builds I've double checked by having Vercel console opened aside 😉

[BetaHuhn]

Ah yeah makes sense. I wasn't thinking in regards to pushing over and over to the same branch, only about cancelling a single run.

We need to replace RUN_ID with an identifier for a given branch. We could use the git ref for that.