Skip to content

Commit b1f02cf

Browse files
committed
Consistent description of optional parameters
1 parent df2e832 commit b1f02cf

File tree

3 files changed

+34
-21
lines changed

3 files changed

+34
-21
lines changed

README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,12 @@ gcloud dataflow flex-template run "pubsub-to-betterstack-$(date +%Y%m%d-%H%M%S)"
3434

3535
The template supports the following optional parameters:
3636

37-
- `batch_size` - Number of messages to batch before sending to Better Stack. Default: 100
38-
- `window_size` - Window size in seconds for batching messages. Default: 10
39-
- `max_retries` - Maximum number of retry attempts for failed requests. Default: 3
40-
- `initial_retry_delay` - Initial delay between retries in seconds. Default: 1
37+
- `batch_size`: Number of messages to batch before sending to Better Stack. Default: 100
38+
- `window_size`: Window size in seconds for batching messages. Default: 10
39+
- `max_retries`: Maximum number of retry attempts for failed requests. Uses exponential backoff between retries. Default: 3
40+
- `initial_retry_delay`: Initial delay in seconds between retries. The delay doubles with each retry attempt. Default: 1
4141

42-
You can include these parameters in your Dataflow job by adding them to the run command, e.g. `gcloud dataflow flex-template run ... --parameters window_size=30`.
42+
You can include these parameters in your Dataflow job in Optional Parameters section during creation in UI, or by adding them to the `gcloud dataflow flex-template run` command - e.g. `--parameters window_size=5`.
4343

4444
## Releasing new version
4545

metadata.json

Lines changed: 22 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,39 +1,52 @@
11
{
22
"name": "pubsub-to-betterstack",
3-
"description": "Dataflow template to stream data from Pub/Sub to Better Stack",
3+
"description": "A Dataflow template that reads messages from Pub/Sub and sends them to Better Stack Telemetry.",
44
"parameters": [
55
{
66
"name": "input_subscription",
7-
"label": "Input Pub/Sub subscription",
8-
"helpText": "The name of the Pub/Sub subscription to read from",
9-
"isOptional": false,
10-
"regexes": ["^projects/[^/]+/subscriptions/[^/]+$"]
7+
"label": "Input Pub/Sub Subscription",
8+
"helpText": "The name of the Pub/Sub subscription to read from.",
9+
"isOptional": false
1110
},
1211
{
1312
"name": "better_stack_source_token",
1413
"label": "Better Stack Source Token",
15-
"helpText": "The source token of your telemetry source in Better Stack",
14+
"helpText": "The source token of your telemetry source in Better Stack.",
1615
"isOptional": false
1716
},
1817
{
1918
"name": "better_stack_ingesting_host",
2019
"label": "Better Stack Ingesting Host",
21-
"helpText": "The ingesting host of your telemetry source in Better Stack",
20+
"helpText": "The ingesting host of your telemetry source in Better Stack.",
2221
"isOptional": false
2322
},
2423
{
2524
"name": "batch_size",
2625
"label": "Batch Size",
27-
"helpText": "Number of messages to batch before sending to Better Stack",
26+
"helpText": "Number of messages to batch before sending to Better Stack.",
2827
"isOptional": true,
2928
"defaultValue": "100"
3029
},
3130
{
3231
"name": "window_size",
3332
"label": "Window Size",
34-
"helpText": "Window size in seconds for batching messages",
33+
"helpText": "Window size in seconds for batching messages.",
3534
"isOptional": true,
3635
"defaultValue": "10"
36+
},
37+
{
38+
"name": "max_retries",
39+
"label": "Max Retries",
40+
"helpText": "Maximum number of retry attempts for failed requests. Uses exponential backoff between retries.",
41+
"isOptional": true,
42+
"defaultValue": "3"
43+
},
44+
{
45+
"name": "initial_retry_delay",
46+
"label": "Initial Retry Delay",
47+
"helpText": "Initial delay in seconds between retries. The delay doubles with each retry attempt.",
48+
"isOptional": true,
49+
"defaultValue": "1"
3750
}
3851
]
3952
}

pipeline.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -93,41 +93,41 @@ def run(argv=None):
9393
parser.add_argument(
9494
'--input_subscription',
9595
required=True,
96-
help='The name of the Pub/Sub subscription to read from'
96+
help='The name of the Pub/Sub subscription to read from.'
9797
)
9898
parser.add_argument(
9999
'--better_stack_source_token',
100100
required=True,
101-
help='The source token of your telemetry source in Better Stack'
101+
help='The source token of your telemetry source in Better Stack.'
102102
)
103103
parser.add_argument(
104104
'--better_stack_ingesting_host',
105105
required=True,
106-
help='The ingesting host of your telemetry source in Better Stack'
106+
help='The ingesting host of your telemetry source in Better Stack.'
107107
)
108108
parser.add_argument(
109109
'--batch_size',
110110
default=100,
111111
type=int,
112-
help='Number of messages to batch before sending to Better Stack'
112+
help='Number of messages to batch before sending to Better Stack.'
113113
)
114114
parser.add_argument(
115115
'--window_size',
116116
default=10,
117117
type=int,
118-
help='Window size in seconds for batching messages'
118+
help='Window size in seconds for batching messages.'
119119
)
120120
parser.add_argument(
121121
'--max_retries',
122122
default=3,
123123
type=int,
124-
help='Maximum number of retry attempts for failed requests'
124+
help='Maximum number of retry attempts for failed requests. Uses exponential backoff between retries.'
125125
)
126126
parser.add_argument(
127127
'--initial_retry_delay',
128128
default=1,
129129
type=int,
130-
help='Initial delay between retries in seconds'
130+
help='Initial delay in seconds between retries. The delay doubles with each retry attempt.'
131131
)
132132
known_args, pipeline_args = parser.parse_known_args(argv)
133133

0 commit comments

Comments
 (0)