check for ValidationException as permanent error, treat all other errors as transient

Author: effron

lib/journaled/kinesis_batch_sender.rb

@@ -20,12 +20,8 @@ def permanent?
       end
     end
 
-    TRANSIENT_ERROR_CLASSES = [
-      Aws::Kinesis::Errors::InternalFailure,
-      Aws::Kinesis::Errors::ServiceUnavailable,
-      Aws::Kinesis::Errors::Http503Error,
-      Aws::Kinesis::Errors::ProvisionedThroughputExceededException,
-      Seahorse::Client::NetworkingError,
+    PERMANENT_ERROR_CLASSES = [
+      Aws::Kinesis::Errors::ValidationException,
     ].freeze
 
     # Send a batch of database events to Kinesis
@@ -73,23 +69,21 @@ def send_event(event)
       )
 
       event
-    rescue *TRANSIENT_ERROR_CLASSES => e
-      # Event failed with transient error
-      Rails.logger.error("Kinesis event send failed (transient): #{e.class} - #{e.message}")
+    rescue *PERMANENT_ERROR_CLASSES => e
+      Rails.logger.error("Kinesis event send failed (permanent): #{e.class} - #{e.message}")
       FailedEvent.new(
         event:,
         error_code: e.class.to_s,
         error_message: e.message,
-        transient: true,
+        transient: false,
       )
     rescue StandardError => e
-      # Event failed with permanent error
-      Rails.logger.error("Kinesis event send failed (permanent): #{e.class} - #{e.message}")
+      Rails.logger.error("Kinesis event send failed (transient): #{e.class} - #{e.message}")
       FailedEvent.new(
         event:,
         error_code: e.class.to_s,
         error_message: e.message,
-        transient: false,
+        transient: true,
       )
     end
 

spec/lib/journaled/kinesis_batch_sender_spec.rb

@@ -124,7 +124,7 @@
 
       before do
         allow(kinesis_client).to receive(:put_record)
-          .and_raise(Aws::Kinesis::Errors::InvalidArgumentException.new(nil, 'Invalid data'))
+          .and_raise(Aws::Kinesis::Errors::ValidationException.new(nil, 'Invalid data'))
       end
 
       it 'returns failed event with non-transient flag' do
@@ -133,7 +133,7 @@
         expect(result[:failed].length).to eq(1)
         failure = result[:failed].first
         expect(failure.event).to eq(event)
-        expect(failure.error_code).to eq('Aws::Kinesis::Errors::InvalidArgumentException')
+        expect(failure.error_code).to eq('Aws::Kinesis::Errors::ValidationException')
         expect(failure.error_message).to eq('Invalid data')
         expect(failure.transient?).to be false
         expect(failure.permanent?).to be true