Convert split to plain object

Author: rzane

src/abConfiguration.ts

@@ -1,3 +1,4 @@
+import { getSplitVariants } from './split';
 import Visitor from './visitor';
 
 type Options = {
@@ -8,7 +9,7 @@ type Options = {
 
 export function getABVariants({ splitName, trueVariant, visitor }: Options) {
   const split = visitor.config.splitRegistry.getSplit(splitName);
-  const splitVariants = split?.getVariants();
+  const splitVariants = split && getSplitVariants(split);
 
   if (splitVariants && splitVariants.length > 2) {
     visitor.logError(`A/B for ${splitName} configures split with more than 2 variants`);

src/calculateVariant.ts

@@ -1,6 +1,6 @@
 import { md5 } from 'js-md5';
 import Visitor from './visitor';
-import Split from './split';
+import { getSplitVariants, type Split } from './split';
 
 function getSplit(visitor: Visitor, splitName: string): Split {
   const split = visitor.config.splitRegistry.getSplit(splitName);
@@ -29,7 +29,7 @@ export function calculateVariant(visitor: Visitor, splitName: string): string |
   const assignmentBucket = getAssignmentBucket(visitor, splitName);
   const split = getSplit(visitor, splitName);
   const weighting = split.weighting;
-  const sortedVariants = split.getVariants().sort();
+  const sortedVariants = getSplitVariants(split).sort();
 
   for (const variant of sortedVariants) {
     bucketCeiling += weighting[variant];

src/config.ts

@@ -1,5 +1,5 @@
 import Assignment from './assignment';
-import Split from './split';
+import { type Split } from './split';
 import { createSplitRegistry, type SplitRegistry } from './splitRegistry';
 
 const DEFAULT_VISITOR_COOKIE_NAME = 'tt_visitor_id';
@@ -38,9 +38,11 @@ function parseSplitRegistry(rawSplits: RawConfig['splits']): SplitRegistry {
     return createSplitRegistry(null);
   }
 
-  const splits = Object.entries(rawSplits).map(([splitName, rawSplit]) => {
-    return new Split(splitName, rawSplit['feature_gate'], rawSplit['weights']);
-  });
+  const splits = Object.entries(rawSplits).map<Split>(([name, values]) => ({
+    name,
+    isFeatureGate: values.feature_gate,
+    weighting: values.weights
+  }));
 
   return createSplitRegistry(splits);
 }

src/split.test.ts

@@ -1,21 +1,13 @@
-import Split from './split';
+import { getSplitVariants, type Split } from './split';
 
-function createSplit() {
-  return new Split('split name', true, { foo: 50, bar: 50, baz: 0 });
-}
+describe('.getVariants()', () => {
+  it('returns all variants', () => {
+    const split: Split = {
+      name: 'split name',
+      isFeatureGate: true,
+      weighting: { foo: 50, bar: 50, baz: 0 }
+    };
 
-describe('Split', () => {
-  describe('.getVariants()', () => {
-    it('returns all variants', () => {
-      const split = createSplit();
-      expect(split.getVariants()).toEqual(['foo', 'bar', 'baz']);
-    });
-  });
-
-  describe('.weighting', () => {
-    it('returns the weightings hash', () => {
-      const split = createSplit();
-      expect(split.weighting).toEqual({ foo: 50, bar: 50, baz: 0 });
-    });
+    expect(getSplitVariants(split)).toEqual(['foo', 'bar', 'baz']);
   });
 });

src/split.ts

@@ -2,20 +2,12 @@ export type Weighting = {
   [variant: string]: number;
 };
 
-class Split {
+export type Split = {
   name: string;
   isFeatureGate: boolean;
   weighting: Weighting;
+};
 
-  constructor(name: string, isFeatureGate: boolean, weighting: Weighting) {
-    this.name = name;
-    this.isFeatureGate = isFeatureGate;
-    this.weighting = weighting;
-  }
-
-  getVariants(): string[] {
-    return Object.keys(this.weighting);
-  }
+export function getSplitVariants(split: Split): string[] {
+  return Object.keys(split.weighting);
 }
-
-export default Split;

src/splitRegistry.test.ts

@@ -1,10 +1,10 @@
-import Split from './split';
 import { createSplitRegistry } from './splitRegistry';
 
 function setupSplitRegistry() {
-  const split1 = new Split('split1', true, { foo: 50, bar: 50, baz: 0 });
-  const split2 = new Split('split2', true, { up: 50, down: 50 });
-  return createSplitRegistry([split1, split2]);
+  return createSplitRegistry([
+    { name: 'split1', isFeatureGate: true, weighting: { foo: 50, bar: 50, baz: 0 } },
+    { name: 'split2', isFeatureGate: true, weighting: { up: 50, down: 50 } }
+  ]);
 }
 
 describe('SplitRegistry', () => {

src/splitRegistry.ts

@@ -1,4 +1,4 @@
-import Split, { type Weighting } from './split';
+import type { Split, Weighting } from './split';
 
 export type V1Hash = {
   [splitName: string]: Weighting;

src/vary.ts

@@ -1,4 +1,5 @@
 import Assignment from './assignment';
+import { getSplitVariants } from './split';
 import Visitor from './visitor';
 
 type Handler = () => void;
@@ -23,7 +24,7 @@ function validateVariants(visitor: Visitor, assignment: Assignment, variants: Va
   const split = visitor.config.splitRegistry.getSplit(assignment.getSplitName());
   if (!split) return;
 
-  const splitVariants = split.getVariants();
+  const splitVariants = getSplitVariants(split);
   const unknownVariants = configuredVariants.filter(variant => !splitVariants.includes(variant));
   const missingVariants = splitVariants.filter(variant => !configuredVariants.includes(variant));