breaking change: drop support for mysql (#26)

we're not using mysql anymore and maintaining support for it isn't
something we're interested in doing anymore.

/no-platform

Author: samandmoore

.github/workflows/ci.yml

@@ -12,7 +12,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: ['3.2', '3.3', '3.4']
+        ruby: ["3.2", "3.3", "3.4"]
         gemfile:
           - gemfiles/rails_7_0.gemfile
           - gemfiles/rails_7_1.gemfile
@@ -35,25 +35,15 @@ jobs:
         ports:
           # Maps tcp port 5432 on service container to the host
           - 5432:5432
-      mysql:
-        image: mysql:5.7
-        env:
-          MYSQL_ALLOW_EMPTY_PASSWORD: yes
-          MYSQL_DATABASE: with_transactional_lock_test
-          DB_ADAPTER: mysql
-        ports:
-            - 3306:3306
-        options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
-
     steps:
-    - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
-    - uses: ruby/setup-ruby@a4effe49ee8ee5b8b5091268c473a4628afb5651 # v1
-      env:
-        BUNDLE_GEMFILE: ${{ matrix.gemfile }}
-      with:
-        ruby-version: ${{ matrix.ruby }}
-        bundler-cache: true # runs 'bundle install' and caches installed gems automatically
-    - name: Run tests
-      env:
-        BUNDLE_GEMFILE: ${{ matrix.gemfile }}
-      run: bundle exec rake
+      - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
+      - uses: ruby/setup-ruby@a4effe49ee8ee5b8b5091268c473a4628afb5651 # v1
+        env:
+          BUNDLE_GEMFILE: ${{ matrix.gemfile }}
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+      - name: Run tests
+        env:
+          BUNDLE_GEMFILE: ${{ matrix.gemfile }}
+        run: bundle exec rake

CHANGELOG.md

@@ -0,0 +1,12 @@
+# Changelog
+
+All notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
+and this project aims to adhere to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
+
+## [3.0.0]
+
+### Removed
+
+- Removed support for mysql

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    with_transactional_lock (2.4.0)
+    with_transactional_lock (3.0.0)
       activerecord (>= 7.0, < 8.1)
       railties (>= 7.0, < 8.1)
 
@@ -86,7 +86,6 @@ GEM
       crass (~> 1.0.2)
       nokogiri (>= 1.12.0)
     minitest (5.25.4)
-    mysql2 (0.5.6)
     nokogiri (1.18.2-arm64-darwin)
       racc (~> 1.4)
     nokogiri (1.18.2-x86_64-darwin)
@@ -213,7 +212,6 @@ DEPENDENCIES
   appraisal
   betterlint
   database_cleaner
-  mysql2
   pg
   rspec-rails
   rspec-retry

README.md

@@ -1,14 +1,14 @@
 # with_transactional_lock
 
 A simple extension to ActiveRecord for performing advisory locking on
-MySQL and PostgreSQL.
+PostgreSQL.
 
 An advisory lock is a database-level mutex that can be used to prevent
 concurrent access to a shared resource or to prevent two workers from
 performing the same process concurrently.
 
 This gem is different from other advisory locking gems because it
-uses advisory transaction locks instead of advisory session locks. 
+uses advisory transaction locks instead of advisory session locks.
 
 ## Why transactional?
 
@@ -31,7 +31,7 @@ preventing leaks.
 Additionally, application developers tend to think about discrete units
 of database work in terms of transactions. By leveraging the transaction
 boundary, we ensure the advisory lock is released at the earliest
-possible moment that it can be and no sooner. 
+possible moment that it can be and no sooner.
 
 ## Lock acquisition efficiency & fairness
 
@@ -60,25 +60,16 @@ waiting on I/O (possibly allowing another thread to use the CPU).
 
 Add this line to your application's Gemfile:
 
-``` ruby
+```ruby
 gem 'with_transactional_lock'
 ```
 
 And then bundle install:
 
 ```
-$ bundle install
-```
-
-And then if you're using MySQL, you will need to run the installer:
-
-```
-$ rails g with_transactional_lock:install
+bundle install
 ```
 
-This will create a migration that will add an
-`transactional_advisory_locks` table to your database.
-
 ## Usage
 
 Because transactional locks are meaningless outside of the context of a
@@ -92,12 +83,12 @@ ActiveRecord::Base.with_transactional_lock('name_of_a_resource') do
 end
 ```
 
-This call will attempt to acquire an exclusive lock using the provided 
+This call will attempt to acquire an exclusive lock using the provided
 lock name. It will wait indefinitely for that lock -- or at least as
 long as your database connection timeout is willing to allow. Once the
 lock is acquired you will have exclusive ownership of the advisory lock
 with the name that you provided. Your block is free to execute its
-critical work. Upon completion of your transaction, the lock will be 
+critical work. Upon completion of your transaction, the lock will be
 released.
 
 ## Supported databases
@@ -109,15 +100,6 @@ PostgreSQL has first-class support for transactional advisory locks via
 duration of a given transaction and automatically released upon
 transaction commit.
 
-### MySQL
-
-MySQL does not have built-in support for transactional advisory locks.
-So, MySQL gets a special treatment. We emulate the behavior of PostgreSQL
-using a special `transactional_advisory_locks` table with a unique index 
-on the `lock_id` column. This allows us to provide the same transactional 
-and mutual exclusivity guarantees as PostgreSQL. The trade-off is that 
-you need to add another table to your database.
-
 ## License
 
 Any contributions made to this project are covered under the MIT License, found [here](LICENSE)

gemfiles/rails_7_0.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    with_transactional_lock (2.4.0)
+    with_transactional_lock (3.0.0)
       activerecord (>= 7.0, < 8.1)
       railties (>= 7.0, < 8.1)
 
@@ -35,57 +35,58 @@ GEM
       bundler
       rake
       thor (>= 0.14.0)
-    ast (2.4.2)
-    base64 (0.2.0)
-    benchmark (0.4.0)
-    betterlint (1.16.0)
-      rubocop (~> 1.62.0)
-      rubocop-graphql (~> 1.5.0)
-      rubocop-performance (~> 1.21.0)
-      rubocop-rails (~> 2.24.0)
-      rubocop-rake (~> 0.6.0)
-      rubocop-rspec (~> 2.28.0)
-    bigdecimal (3.1.9)
+    ast (2.4.3)
+    base64 (0.3.0)
+    benchmark (0.4.1)
+    betterlint (1.23.0)
+      rubocop (~> 1.71)
+      rubocop-graphql (~> 1.5)
+      rubocop-performance (~> 1.23)
+      rubocop-rails (~> 2.29)
+      rubocop-rake (~> 0.6)
+      rubocop-rspec (~> 2.29)
+    bigdecimal (3.2.2)
     builder (3.3.0)
     concurrent-ruby (1.3.4)
     crass (1.0.6)
     database_cleaner (2.1.0)
       database_cleaner-active_record (>= 2, < 3)
-    database_cleaner-active_record (2.2.0)
+    database_cleaner-active_record (2.2.1)
       activerecord (>= 5.a)
       database_cleaner-core (~> 2.0.0)
     database_cleaner-core (2.0.1)
-    diff-lcs (1.5.1)
-    drb (2.2.1)
+    diff-lcs (1.6.2)
+    drb (2.2.3)
     erubi (1.13.1)
     i18n (1.14.7)
       concurrent-ruby (~> 1.0)
-    json (2.9.1)
-    language_server-protocol (3.17.0.3)
-    logger (1.6.5)
-    loofah (2.24.0)
+    json (2.13.0)
+    language_server-protocol (3.17.0.5)
+    lint_roller (1.1.0)
+    logger (1.7.0)
+    loofah (2.24.1)
       crass (~> 1.0.2)
       nokogiri (>= 1.12.0)
     method_source (1.1.0)
-    minitest (5.25.4)
+    minitest (5.25.5)
     mutex_m (0.3.0)
-    mysql2 (0.5.6)
-    nokogiri (1.18.2-arm64-darwin)
+    nokogiri (1.18.8-arm64-darwin)
       racc (~> 1.4)
-    nokogiri (1.18.2-x86_64-darwin)
+    nokogiri (1.18.8-x86_64-darwin)
       racc (~> 1.4)
-    nokogiri (1.18.2-x86_64-linux-gnu)
+    nokogiri (1.18.8-x86_64-linux-gnu)
       racc (~> 1.4)
-    parallel (1.26.3)
-    parser (3.3.7.0)
+    parallel (1.27.0)
+    parser (3.3.8.0)
       ast (~> 2.4.1)
       racc
     pg (1.5.9)
+    prism (1.4.0)
     racc (1.8.1)
-    rack (2.2.10)
+    rack (2.2.17)
     rack-test (2.2.0)
       rack (>= 1.3)
-    rails-dom-testing (2.2.0)
+    rails-dom-testing (2.3.0)
       activesupport (>= 5.0.0)
       minitest
       nokogiri (>= 1.6)
@@ -100,18 +101,17 @@ GEM
       thor (~> 1.0)
       zeitwerk (~> 2.5)
     rainbow (3.1.1)
-    rake (13.2.1)
+    rake (13.3.0)
     regexp_parser (2.10.0)
-    rexml (3.4.0)
-    rspec-core (3.13.2)
+    rspec-core (3.13.5)
       rspec-support (~> 3.13.0)
-    rspec-expectations (3.13.3)
+    rspec-expectations (3.13.5)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
-    rspec-mocks (3.13.2)
+    rspec-mocks (3.13.5)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
-    rspec-rails (7.1.0)
+    rspec-rails (7.1.1)
       actionpack (>= 7.0)
       activesupport (>= 7.0)
       railties (>= 7.0)
@@ -121,37 +121,44 @@ GEM
       rspec-support (~> 3.13)
     rspec-retry (0.6.2)
       rspec-core (> 3.3)
-    rspec-support (3.13.2)
-    rubocop (1.62.1)
+    rspec-support (3.13.4)
+    rubocop (1.78.0)
       json (~> 2.3)
-      language_server-protocol (>= 3.17.0)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8, < 3.0)
-      rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.31.1, < 2.0)
+      regexp_parser (>= 2.9.3, < 3.0)
+      rubocop-ast (>= 1.45.1, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.37.0)
-      parser (>= 3.3.1.0)
-    rubocop-capybara (2.21.0)
-      rubocop (~> 1.41)
-    rubocop-factory_bot (2.26.1)
-      rubocop (~> 1.61)
-    rubocop-graphql (1.5.4)
-      rubocop (>= 1.50, < 2)
-    rubocop-performance (1.21.1)
-      rubocop (>= 1.48.1, < 2.0)
-      rubocop-ast (>= 1.31.1, < 2.0)
-    rubocop-rails (2.24.1)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.46.0)
+      parser (>= 3.3.7.2)
+      prism (~> 1.4)
+    rubocop-capybara (2.22.1)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
+    rubocop-factory_bot (2.27.1)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
+    rubocop-graphql (1.5.6)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.72.1, < 2)
+    rubocop-performance (1.25.0)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.75.0, < 2.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
+    rubocop-rails (2.32.0)
       activesupport (>= 4.2.0)
+      lint_roller (~> 1.1)
       rack (>= 1.1)
-      rubocop (>= 1.33.0, < 2.0)
-      rubocop-ast (>= 1.31.1, < 2.0)
-    rubocop-rake (0.6.0)
-      rubocop (~> 1.0)
-    rubocop-rspec (2.28.0)
+      rubocop (>= 1.75.0, < 2.0)
+      rubocop-ast (>= 1.44.0, < 2.0)
+    rubocop-rake (0.7.1)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.72.1)
+    rubocop-rspec (2.31.0)
       rubocop (~> 1.40)
       rubocop-capybara (~> 2.17)
       rubocop-factory_bot (~> 2.22)
@@ -162,8 +169,10 @@ GEM
     thor (1.3.2)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (2.6.0)
-    zeitwerk (2.7.1)
+    unicode-display_width (3.1.4)
+      unicode-emoji (~> 4.0, >= 4.0.4)
+    unicode-emoji (4.0.4)
+    zeitwerk (2.7.3)
 
 PLATFORMS
   arm64-darwin-22
@@ -182,7 +191,6 @@ DEPENDENCIES
   drb
   logger
   mutex_m
-  mysql2
   pg
   railties (~> 7.0.0)
   rspec-rails