Support Debug build and upload debug binaries

(cherry picked from commit 4e2dd62)

Author: BewareMyPower

.github/workflows/ci-build-binary-artifacts.yaml

@@ -163,11 +163,35 @@ jobs:
         shell: bash
         run: 7z a -tzip pulsar-client-cpp-${{ matrix.triplet }}.zip ${{ env.INSTALL_DIR }}/*
 
-      - name: Upload binaries to release
-        uses: svenstaro/upload-release-action@v2
+      - name: Upload artifacts
+        uses: actions/upload-artifact@v3
         with:
-          repo_token: ${{ secrets.GITHUB_TOKEN }}
-          file: pulsar-client-cpp-${{ matrix.triplet }}.zip
-          asset_name: pulsar-client-cpp-${{ matrix.triplet }}.zip
-          tag: ${{ github.ref }}
-          overwrite: true
+          name: ${{ matrix.triplet }}
+          path: ${{ env.INSTALL_DIR }}
+
+      - name: Build and package (Debug)
+        shell: bash
+        run: |
+          BUILD_DIR=./build-debug
+          INSTALL_DIR_DEBUG={{ env.INSTALL_DIR }}-Debug
+          mkdir -p $BUILD_DIR
+          cmake -B $BUILD_DIR \
+            -G "${{ matrix.generator }}" ${{ matrix.arch }} \
+            -DBUILD_TESTS=OFF \
+            -DVCPKG_TRIPLET=${{ matrix.triplet }} \
+            -DCMAKE_INSTALL_PREFIX=$INSTALL_DIR_DEBUG \
+            -DCMAKE_BUILD_TYPE=Debug \
+            -S .
+          cmake --build $BUILD_DIR --parallel --config Debug
+          cmake --install $BUILD_DIR --config Debug
+          cp dependencies.txt $INSTALL_DIR_DEBUG
+
+      - name: Zip artifact (Debug)
+        shell: bash
+        run: 7z a -tzip pulsar-client-cpp-${{ matrix.triplet }}-Debug.zip ${{ env.INSTALL_DIR }}-Debug/*
+
+      - name: Upload artifacts (Debug)
+        uses: actions/upload-artifact@v3
+        with:
+          name: ${{ matrix.triplet }}-Debug
+          path: ${{ env.INSTALL_DIR }}-Debug

.github/workflows/ci-pr-validation.yaml

@@ -200,6 +200,21 @@ jobs:
             ./build-static/Release/win-example.exe
           fi
 
+      - name: Build (Debug with LINK_STATIC=ON)
+        shell: bash
+        run: |
+          if [ "$RUNNER_OS" == "Windows" ]; then
+            cmake \
+              -B ./build-2 \
+              -G "${{ matrix.generator }}" ${{ matrix.arch }} \
+              -DBUILD_TESTS=OFF \
+              -DVCPKG_TRIPLET="${{ matrix.triplet }}-static" \
+              -DCMAKE_INSTALL_PREFIX="${{ env.INSTALL_DIR }}" \
+              -DCMAKE_BUILD_TYPE=Debug \
+              -S .
+            cmake --build ./build-2 --parallel --config Debug
+          fi
+
   package:
     name: Build ${{matrix.pkg.name}} ${{matrix.cpu.platform}}
     runs-on: ubuntu-22.04

CMakeLists.txt

@@ -44,6 +44,7 @@ if (VCPKG_TRIPLET)
     if (CMAKE_BUILD_TYPE STREQUAL "Debug")
         set(ZLIB_ROOT ${VCPKG_DEBUG_ROOT})
         set(OPENSSL_ROOT_DIR ${VCPKG_DEBUG_ROOT})
+        set(CMAKE_PREFIX_PATH ${VCPKG_DEBUG_ROOT} ${CMAKE_PREFIX_PATH})
     endif ()
     if (VCPKG_TRIPLET MATCHES ".*-static")
         set(LINK_STATIC ON)
@@ -202,13 +203,21 @@ if (LINK_STATIC AND NOT VCPKG_TRIPLET)
 elseif (LINK_STATIC AND VCPKG_TRIPLET)
     find_package(protobuf REQUIRED)
     message(STATUS "Found protobuf static library: " ${Protobuf_LIBRARIES})
-    find_library(ZLIB_LIBRARIES NAMES zlib z)
+    if (MSVC AND (${CMAKE_BUILD_TYPE} STREQUAL Debug))
+        find_library(ZLIB_LIBRARIES NAMES zlibd)
+    else ()
+        find_library(ZLIB_LIBRARIES NAMES zlib z)
+    endif ()
     if (ZLIB_LIBRARIES)
         message(STATUS "Found zlib static library: " ${ZLIB_LIBRARIES})
     else ()
         message(FATAL_ERROR "Failed to find zlib static library")
     endif ()
-    find_library(CURL_LIBRARIES NAMES libcurl)
+    if (MSVC AND (${CMAKE_BUILD_TYPE} STREQUAL Debug))
+        find_library(CURL_LIBRARIES NAMES libcurl-d)
+    else ()
+        find_library(CURL_LIBRARIES NAMES libcurl)
+    endif ()
     if (CURL_LIBRARIES)
         message(STATUS "Found libcurl: ${CURL_LIBRARIES}")
     else ()

lib/CMakeLists.txt

@@ -46,7 +46,11 @@ endif(NOT LIBRARY_VERSION)
 if (MSVC)
     find_package(dlfcn-win32 REQUIRED)
     set(CMAKE_DL_LIBS dlfcn-win32::dl psapi.lib)
-    get_target_property(dlfcn-win32_LIBRARY dlfcn-win32::dl IMPORTED_LOCATION_RELEASE)
+    if (CMAKE_BUILD_TYPE STREQUAL "Debug")
+        get_target_property(dlfcn-win32_LIBRARY dlfcn-win32::dl IMPORTED_LOCATION_DEBUG)
+    else ()
+        get_target_property(dlfcn-win32_LIBRARY dlfcn-win32::dl IMPORTED_LOCATION_RELEASE)
+    endif ()
     message(STATUS "dlfcn-win32_LIBRARY: " ${dlfcn-win32_LIBRARY})
 endif(MSVC)