Specificly using std::toupper instead of toupper. Fixed some issues with clang

4.3

Author: Dilawar Singh

basecode/FieldElementFinfo.h

@@ -112,7 +112,7 @@ template < class T, class F > class FieldElementFinfo: public FieldElementFinfoB
 				getNumField_( getNumField )
 		{
 				string setname = "setNum" + name;
-				setname[6] = toupper( setname[6] );
+				setname[6] = std::toupper( setname[6] );
 				// setNumField is a tricky operation, because it may require
 				// cross-node rescaling of the 
 				// FieldDataHandler::fieldDimension. To acheive this we
@@ -124,7 +124,7 @@ template < class T, class F > class FieldElementFinfo: public FieldElementFinfoB
 					new OpFunc1< T, unsigned int >( setNumField ) );
 
 				string getname = "getNum" + name;
-				getname[6] = toupper( getname[6] );
+				getname[6] = std::toupper( getname[6] );
 				getNum_ = new DestFinfo(
 					getname,
 					"Requests number of field entries in field array."

basecode/LookupValueFinfo.h

@@ -45,14 +45,14 @@ template < class T, class L, class F > class LookupValueFinfo: public LookupValu
 			: LookupValueFinfoBase( name, doc )
 		{
 				string setname = "set" + name;
-				setname[3] = toupper( setname[3] );
+				setname[3] = std::toupper( setname[3] );
 				set_ = new DestFinfo(
 					setname,
 					"Assigns field value.",
 					new OpFunc2< T, L, F >( setFunc ) );
 
 				string getname = "get" + name;
-				getname[3] = toupper( getname[3] );
+				getname[3] = std::toupper( getname[3] );
 				get_ = new DestFinfo(
 					getname,
 					"Requests field value. The requesting Element must "
@@ -103,7 +103,7 @@ template < class T, class L, class F > class ReadOnlyLookupValueFinfo: public Lo
 			: LookupValueFinfoBase( name, doc )
 		{
 				string getname = "get" + name;
-				getname[3] = toupper( getname[3] );
+				getname[3] = std::toupper( getname[3] );
 				get_ = new DestFinfo(
 					getname,
 					"Requests field value. The requesting Element must "

basecode/ValueFinfo.h

@@ -47,14 +47,14 @@ template < class T, class F > class ValueFinfo: public ValueFinfoBase
 			: ValueFinfoBase( name, doc )
 		{
 				string setname = "set" + name;
-				setname[3] = toupper( setname[3] );
+				setname[3] = std::toupper( setname[3] );
 				set_ = new DestFinfo(
 					setname,
 					"Assigns field value.",
 					new OpFunc1< T, F >( setFunc ) );
 
 				string getname = "get" + name;
-				getname[3] = toupper( getname[3] );
+				getname[3] = std::toupper( getname[3] );
 				get_ = new DestFinfo(
 					getname,
 					"Requests field value. The requesting Element must "
@@ -96,7 +96,7 @@ template < class T, class F > class ReadOnlyValueFinfo: public ValueFinfoBase
 			: ValueFinfoBase( name, doc )
 		{
 				string getname = "get" + name;
-				getname[3] = toupper( getname[3] );
+				getname[3] = std::toupper( getname[3] );
 				get_ = new DestFinfo(
 					getname,
 					"Requests field value. The requesting Element must "