Merge pull request #1 from Bharath-code/feature/v2-polish-enhancements

feat: add spinner, improve errors, optimize scan performance

Author: Bharath-code

internal/scan/scan.go

@@ -13,13 +13,39 @@ import (
 	"github.com/Bharath-code/git-scope/internal/model"
 )
 
+// smartIgnorePatterns are always-ignored directories for performance
+// These are system/tool directories that should never contain user repos
+var smartIgnorePatterns = []string{
+	// macOS/Linux system directories
+	"Library", ".Trash", ".cache", ".local",
+	// Package managers & runtimes
+	".npm", ".yarn", ".pnpm", ".bun", ".cargo", ".rustup", ".go",
+	".venv", ".pyenv", ".rbenv", ".nvm", ".sdkman",
+	// IDE extensions (contain third-party repos, not your code)
+	".vscode", ".vscode-server", ".cursor", ".zed", ".idea", ".atom",
+	// Shell & tools configs
+	".oh-my-zsh", ".tmux", ".vim", ".emacs.d", ".gemini",
+	// Docker/Cloud
+	".docker", ".kube", ".ssh", ".gnupg",
+	// Cloud sync (slow and likely duplicates)
+	"Google Drive", "OneDrive", "Dropbox", "iCloud",
+}
+
 // ScanRoots recursively scans the given root directories for git repositories
 // It skips directories matching the ignore patterns
 func ScanRoots(roots, ignore []string) ([]model.Repo, error) {
-	ignoreSet := make(map[string]struct{}, len(ignore))
+	// Build ignore set from user config + smart defaults
+	ignoreSet := make(map[string]struct{}, len(ignore)+len(smartIgnorePatterns))
+	
+	// Add user-defined ignores
 	for _, pattern := range ignore {
 		ignoreSet[pattern] = struct{}{}
 	}
+	
+	// Add smart defaults (always apply for performance)
+	for _, pattern := range smartIgnorePatterns {
+		ignoreSet[pattern] = struct{}{}
+	}
 
 	var mu sync.Mutex
 	var repos []model.Repo

internal/tui/model.go

@@ -5,6 +5,7 @@ import (
 	"sort"
 	"strings"
 
+	"github.com/charmbracelet/bubbles/spinner"
 	"github.com/charmbracelet/bubbles/table"
 	"github.com/charmbracelet/bubbles/textinput"
 	tea "github.com/charmbracelet/bubbletea"
@@ -48,6 +49,7 @@ type Model struct {
 	cfg         *config.Config
 	table       table.Model
 	textInput   textinput.Model
+	spinner     spinner.Model
 	repos       []model.Repo
 	filteredRepos []model.Repo  // After filter applied
 	sortedRepos []model.Repo   // After sort applied
@@ -113,10 +115,16 @@ func NewModel(cfg *config.Config) Model {
 	ti.CharLimit = 50
 	ti.Width = 30
 
+	// Create spinner with Braille pattern
+	sp := spinner.New()
+	sp.Spinner = spinner.Dot
+	sp.Style = lipgloss.NewStyle().Foreground(lipgloss.Color("#7C3AED"))
+
 	return Model{
 		cfg:        cfg,
 		table:      t,
 		textInput:  ti,
+		spinner:    sp,
 		state:      StateLoading,
 		sortMode:   SortByDirty,
 		filterMode: FilterAll,
@@ -125,7 +133,7 @@ func NewModel(cfg *config.Config) Model {
 
 // Init initializes the model
 func (m Model) Init() tea.Cmd {
-	return scanReposCmd(m.cfg)
+	return tea.Batch(m.spinner.Tick, scanReposCmd(m.cfg))
 }
 
 // GetSelectedRepo returns the currently selected repo

internal/tui/update.go

@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"os/exec"
 
+	"github.com/charmbracelet/bubbles/spinner"
 	"github.com/charmbracelet/bubbles/textinput"
 	tea "github.com/charmbracelet/bubbletea"
 	"github.com/Bharath-code/git-scope/internal/model"
@@ -21,6 +22,13 @@ func (m Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 		m.height = msg.Height
 		m.resizeTable()
 
+	case spinner.TickMsg:
+		// Update spinner during loading
+		if m.state == StateLoading {
+			m.spinner, cmd = m.spinner.Update(msg)
+			cmds = append(cmds, cmd)
+		}
+
 	case scanCompleteMsg:
 		m.repos = msg.repos
 		m.state = StateReady

internal/tui/view.go

@@ -33,7 +33,9 @@ func (m Model) renderLoading() string {
 
 	b.WriteString(compactLogo())
 	b.WriteString("  ")
-	b.WriteString(loadingStyle.Render("⏳ Scanning repositories..."))
+	b.WriteString(m.spinner.View())
+	b.WriteString(" ")
+	b.WriteString(loadingStyle.Render("Scanning repositories..."))
 	b.WriteString("\n\n")
 
 	b.WriteString(subtitleStyle.Render("Searching for git repos in:"))
@@ -56,7 +58,7 @@ func (m Model) renderError() string {
 	b.WriteString(compactLogo())
 	b.WriteString("  ")
 	b.WriteString(errorTitleStyle.Render("✗ Error"))
-	b.WriteString("\n")
+	b.WriteString("\n\n")
 
 	errContent := ""
 	if m.err != nil {
@@ -67,9 +69,22 @@ func (m Model) renderError() string {
 	b.WriteString(errorBoxStyle.Render(errContent))
 	b.WriteString("\n\n")
 
-	b.WriteString(helpItem("q", "quit"))
-	b.WriteString("  •  ")
+	// Actionable suggestions
+	b.WriteString(subtitleStyle.Render("💡 Suggestions:"))
+	b.WriteString("\n")
+	b.WriteString(pathBulletStyle.Render("  → "))
+	b.WriteString(pathStyle.Render("Check your config at ~/.config/git-scope/config.yml"))
+	b.WriteString("\n")
+	b.WriteString(pathBulletStyle.Render("  → "))
+	b.WriteString(pathStyle.Render("Run 'git-scope init' to reconfigure"))
+	b.WriteString("\n")
+	b.WriteString(pathBulletStyle.Render("  → "))
+	b.WriteString(pathStyle.Render("Make sure git is installed and in PATH"))
+	b.WriteString("\n\n")
+
 	b.WriteString(helpItem("r", "retry"))
+	b.WriteString("  •  ")
+	b.WriteString(helpItem("q", "quit"))
 
 	return b.String()
 }