pleases linter

#709

Author: XaverStiensmeier

bibigrid/core/actions/create.py

@@ -233,7 +233,7 @@ def start_vpn_or_master(self, configuration, provider):  # pylint: disable=too-m
                         f"Floating ip {configuration['floatingIpId']} does not exist on "
                         f"{provider.cloud_specification['identifier']}!")
                 configuration["floating_ip"] = floating_ip["floating_ip_address"]
-                _ = provider.add_ip_list(server, [configuration["floating_ip"]])
+                _ = provider.add_ip_list(server=server, floating_ip=[configuration["floating_ip"]])
             self.log.info(
                 f"Server {name} uses floating ip {configuration['floating_ip']} ({'pre-existing'
                 if configuration.get('floatingIpId') else 'created'})")

bibigrid/core/actions/terminate.py

@@ -29,7 +29,8 @@ def write_cluster_state(state):
         yaml.safe_dump(data=state, stream=cluster_info_file)
 
 
-def terminate(cluster_id, providers, floating_ip_ids, log, debug=False, assume_yes=False):
+# pylint: disable=too-many-locals
+def terminate(*, cluster_id, providers, floating_ip_ids, log, debug=False, assume_yes=False):
     """
     Goes through all providers and gets info of all servers which name contains cluster ID.
     It then checks if any resources are reserved, but not used and frees them that were hold by the cluster.

bibigrid/core/provider.py

@@ -203,7 +203,7 @@ def get_external_network(self, network_name_or_id):
         """
 
     @abstractmethod
-    def add_ip_list(self, server, ips, wait=False, timeout=60, fixed_address=None, nat_destination=None):
+    def add_ip_list(self, *, server, ips, wait=False, timeout=60, fixed_address=None, nat_destination=None):
         """
         Add ip list to server.
         :param server:
@@ -216,16 +216,16 @@ def add_ip_list(self, server, ips, wait=False, timeout=60, fixed_address=None, n
         """
 
     @abstractmethod
-    def get_floating_ip(self, id, filters=None):
+    def get_floating_ip(self, floating_ip_id, filters=None):
         """
         Get a floating IP by id.
-        @param id:
+        @param floating_ip_id:
         @param filters:
         @return:
         """
 
     @abstractmethod
-    def create_floating_ip(self, network=None, server=None, fixed_address=None, nat_destination=None, port=None,
+    def create_floating_ip(self, *, network=None, server=None, fixed_address=None, nat_destination=None, port=None,
                            wait=False, timeout=60):
         """
 

bibigrid/openstack/openstack_provider.py

@@ -288,16 +288,16 @@ def get_external_network(self, network_name_or_id):
                     return router.external_gateway_info["network_id"]
         return None
 
-    def get_floating_ip(self, id, filters=None):
+    def get_floating_ip(self, floating_ip_id, filters=None):
         """
         Get a floating IP by id.
-        @param id:
+        @param floating_ip_id:
         @param filters:
         @return:
         """
-        return self.conn.get_floating_ip(id, filters)
+        return self.conn.get_floating_ip(floating_ip_id, filters)
 
-    def add_ip_list(self, server, ips, wait=False, timeout=60, fixed_address=None, nat_destination=None):
+    def add_ip_list(self, *, server, ips, wait=False, timeout=60, fixed_address=None, nat_destination=None):
         """
         Add ip list to server.
         :param server:
@@ -311,7 +311,7 @@ def add_ip_list(self, server, ips, wait=False, timeout=60, fixed_address=None, n
         return self.conn.add_ip_list(server, ips, wait=wait, timeout=timeout, fixed_address=fixed_address,
                                      nat_destination=nat_destination)
 
-    def create_floating_ip(self, network=None, server=None, fixed_address=None, nat_destination=None, port=None,
+    def create_floating_ip(self, *, network=None, server=None, fixed_address=None, nat_destination=None, port=None,
                            wait=True, timeout=60):
         """