Skip to content

Commit a8fa35d

Browse files
committed
Upgrade to mavericks
1 parent fc197ce commit a8fa35d

File tree

7 files changed

+28
-16
lines changed

7 files changed

+28
-16
lines changed

app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ dependencies {
4848
implementation("com.airbnb.android:epoxy:$epoxy_version")
4949
implementation 'androidx.legacy:legacy-support-v4:1.0.0'
5050
kapt "com.airbnb.android:epoxy-processor:$epoxy_version"
51-
implementation 'com.airbnb.android:mvrx:1.5.1'
51+
implementation 'com.airbnb.android:mavericks:2.4.0'
5252
// ============
5353

5454
testImplementation 'junit:junit:4.13.2'

app/src/main/AndroidManifest.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
<uses-permission android:name="android.permission.INTERNET" />
77

88
<application
9+
android:name=".MyApplication"
910
android:allowBackup="true"
1011
android:icon="@mipmap/ic_launcher"
1112
android:label="@string/app_name"
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
package org.billcarsonfr.jsonviewerexample
2+
3+
import android.app.Application
4+
import com.airbnb.mvrx.Mavericks
5+
6+
class MyApplication : Application() {
7+
8+
override fun onCreate() {
9+
super.onCreate()
10+
Mavericks.initialize(false)
11+
}
12+
13+
}

jsonviewer/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ dependencies {
4242
// Epoxy dependency
4343
implementation "com.airbnb.android:epoxy:$epoxy_version"
4444
kapt "com.airbnb.android:epoxy-processor:$epoxy_version"
45-
implementation 'com.airbnb.android:mvrx:1.5.1'
45+
implementation 'com.airbnb.android:mavericks:2.4.0'
4646
// Span utils
4747
implementation 'me.gujun.android:span:1.7'
4848
implementation 'com.google.android.material:material:1.4.0-alpha01'

jsonviewer/src/main/java/org/billcarsonfr/jsonviewer/JSonViewerDialog.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import android.view.View
66
import android.view.ViewGroup
77
import android.view.WindowManager
88
import androidx.fragment.app.DialogFragment
9-
import com.airbnb.mvrx.MvRx
9+
import com.airbnb.mvrx.Mavericks
1010

1111

1212
class JSonViewerDialog : DialogFragment() {
@@ -22,7 +22,7 @@ class JSonViewerDialog : DialogFragment() {
2222

2323
override fun onActivityCreated(savedInstanceState: Bundle?) {
2424
super.onActivityCreated(savedInstanceState)
25-
val args: JSonViewerFragmentArgs = arguments?.getParcelable(MvRx.KEY_ARG) ?: return
25+
val args: JSonViewerFragmentArgs = arguments?.getParcelable(Mavericks.KEY_ARG) ?: return
2626
if (savedInstanceState == null) {
2727
childFragmentManager.beginTransaction()
2828
.replace(
@@ -56,7 +56,7 @@ class JSonViewerDialog : DialogFragment() {
5656
val args = Bundle()
5757
val parcelableArgs =
5858
JSonViewerFragmentArgs(jsonString, initialOpenDepth, false, styleProvider)
59-
args.putParcelable(MvRx.KEY_ARG, parcelableArgs)
59+
args.putParcelable(Mavericks.KEY_ARG, parcelableArgs)
6060
return JSonViewerDialog().apply { arguments = args }
6161
}
6262
}

jsonviewer/src/main/java/org/billcarsonfr/jsonviewer/JSonViewerFragment.kt

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,10 @@ import android.os.Parcelable
55
import android.view.LayoutInflater
66
import android.view.View
77
import android.view.ViewGroup
8+
import androidx.fragment.app.Fragment
89
import androidx.recyclerview.widget.LinearLayoutManager
910
import com.airbnb.epoxy.EpoxyRecyclerView
10-
import com.airbnb.mvrx.BaseMvRxFragment
11-
import com.airbnb.mvrx.MvRx
12-
import com.airbnb.mvrx.fragmentViewModel
13-
import com.airbnb.mvrx.withState
11+
import com.airbnb.mvrx.*
1412
import kotlinx.parcelize.Parcelize
1513

1614
@Parcelize
@@ -22,9 +20,9 @@ data class JSonViewerFragmentArgs(
2220
) : Parcelable
2321

2422

25-
class JSonViewerFragment : BaseMvRxFragment() {
23+
class JSonViewerFragment : Fragment(), MavericksView {
2624

27-
private val viewModel: JSonViewerViewModel by fragmentViewModel(JSonViewerViewModel::class)
25+
private val viewModel: JSonViewerViewModel by fragmentViewModel()
2826

2927
private val epoxyController by lazy {
3028
JSonViewerEpoxyController(requireContext())
@@ -37,7 +35,7 @@ class JSonViewerFragment : BaseMvRxFragment() {
3735
container: ViewGroup?,
3836
savedInstanceState: Bundle?
3937
): View? {
40-
val args: JSonViewerFragmentArgs? = arguments?.getParcelable(MvRx.KEY_ARG)
38+
val args: JSonViewerFragmentArgs? = arguments?.getParcelable(Mavericks.KEY_ARG)
4139
val inflate =
4240
if (args?.wrap == true) {
4341
inflater.inflate(R.layout.fragment_jv_recycler_view_wrap, container, false)
@@ -71,7 +69,7 @@ class JSonViewerFragment : BaseMvRxFragment() {
7169
return JSonViewerFragment().apply {
7270
arguments = Bundle().apply {
7371
putParcelable(
74-
MvRx.KEY_ARG,
72+
Mavericks.KEY_ARG,
7573
JSonViewerFragmentArgs(
7674
jsonString,
7775
initialOpenDepth,

jsonviewer/src/main/java/org/billcarsonfr/jsonviewer/JSonViewerViewModel.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ import kotlinx.coroutines.launch
77

88
data class JSonViewerState(
99
val root: Async<JSonViewerObject> = Uninitialized
10-
) : MvRxState
10+
) : MavericksState
1111

1212
class JSonViewerViewModel(initialState: JSonViewerState) :
13-
BaseMvRxViewModel<JSonViewerState>(initialState, false) {
13+
MavericksViewModel<JSonViewerState>(initialState) {
1414

1515

1616
fun setJsonSource(json: String, initialOpenDepth: Int) {
@@ -36,7 +36,7 @@ class JSonViewerViewModel(initialState: JSonViewerState) :
3636
}
3737
}
3838

39-
companion object : MvRxViewModelFactory<JSonViewerViewModel, JSonViewerState> {
39+
companion object : MavericksViewModelFactory<JSonViewerViewModel, JSonViewerState> {
4040

4141
@JvmStatic
4242
override fun initialState(viewModelContext: ViewModelContext): JSonViewerState? {

0 commit comments

Comments
 (0)