fix: config to enable slack

Author: binaryk

config/developer.php

@@ -12,7 +12,12 @@
     'model' => \Binarcode\LaravelDeveloper\Models\DeveloperLog::class,
 
     /**
-     * The slack incoming webhook to send notifications.
+     * Indicate whether to allow using slack helper.
+     */
+    'slack_dev_enabled' => env('SLACK_DEV_LOG_ENABLED', true),
+
+    /**
+     * The slack webhook to send notifications.
      */
     'slack_dev_hook' => env('SLACK_DEV_HOOK'),
 

src/Notifications/Slack.php

@@ -57,8 +57,12 @@ public function channel(string $channel): self
         return $this;
     }
 
-    private function send($item)
+    private function send($item): self
     {
+        if (! config('developer.slack_dev_enabled')) {
+            return $this;
+        }
+
         /**
          * @var string $class
          */

src/helpers.php

@@ -47,11 +47,7 @@ function measure_timing($callable = null, string $key = 'action')
 if (! function_exists('slack')) {
     function slack(...$args)
     {
-        if (! App::runningUnitTests()) {
-            return Slack::make($args);
-        }
-
-        return false;
+        return Slack::make($args);
     }
 }
 

tests/Helpers/SlackHelperTest.php

@@ -9,7 +9,6 @@
 use Binarcode\LaravelDeveloper\Tests\TestCase;
 use Exception;
 use Illuminate\Notifications\AnonymousNotifiable;
-use Illuminate\Support\Facades\App;
 use Illuminate\Support\Facades\Notification;
 
 class SlackHelperTest extends TestCase
@@ -18,10 +17,6 @@ public function test_slack_helper_returns_laravel_developer_instance(): void
     {
         Notification::fake();
 
-        App::partialMock()
-            ->shouldReceive('environment')
-            ->andReturn('dev');
-
         $this->assertInstanceOf(Slack::class, slack());
         $this->assertInstanceOf(Slack::class, slack('message'));
         $this->assertInstanceOf(Slack::class, slack(new Exception()));
@@ -31,10 +26,6 @@ public function test_slack_helper_can_send_message_to_slack(): void
     {
         Notification::fake();
 
-        App::partialMock()
-            ->shouldReceive('environment')
-            ->andReturn('dev');
-
         $this->assertInstanceOf(Slack::class, slack('message'));
 
         Notification::assertSentTo(new AnonymousNotifiable(), DevNotification::class);
@@ -48,10 +39,6 @@ public function test_slack_helper_can_send_throwable_to_slack(): void
             'developer.developer_log_base_url' => 'app.test/{id}',
         ]);
 
-        App::partialMock()
-            ->shouldReceive('environment')
-            ->andReturn('dev');
-
         $this->assertInstanceOf(Slack::class, slack(new Exception('not found', 404))->persist());
 
         $this->assertDatabaseCount('developer_logs', 1);
@@ -67,25 +54,21 @@ public function test_slack_helper_can_send_throwable_to_slack(): void
             DevNotification::class,
             function (DevNotification $class) use ($uuid) {
                 return $class->notificationDto->attachment_link === "app.test/{$uuid}";
-            }
+            },
         );
     }
 
     public function test_slack_helper_can_send_notifications_to_slack(): void
     {
         Notification::fake();
 
-        App::partialMock()
-            ->shouldReceive('environment')
-            ->andReturn('dev');
-
         config([
             'developer.developer_log_base_url' => 'app.test/{id}',
             'developer.slack_dev_hook' => 'https://test.com',
         ]);
 
         $this->assertInstanceOf(Slack::class, slack(
-            new DummyNotification()
+            new DummyNotification(),
         )->persist());
 
         Notification::assertSentTo(new AnonymousNotifiable(), DummyNotification::class);