Try catch.

Author: binaryk

src/Models/MailatorSchedule.php

@@ -13,12 +13,14 @@
 use Carbon\Carbon;
 use Carbon\CarbonInterface;
 use Closure;
+use Exception;
 use Illuminate\Contracts\Mail\Mailable;
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Support\Arr;
 use Illuminate\Support\Facades\Validator;
 use Illuminate\Support\Str;
 use Opis\Closure\SerializableClosure;
+use Throwable;
 
 /**
  * Class MailatorSchedule.
@@ -324,27 +326,33 @@ public function logs()
 
     public function shouldSend(): bool
     {
-        $this->load('logs');
-
-        return $this->configurationsPasses() && $this->whenPasses() && $this->eventsPasses();
+        try {
+            $this->load('logs');
+            return $this->configurationsPasses() && $this->whenPasses() && $this->eventsPasses();
+        } catch (Exception|Throwable) {
+            return false;
+        }
     }
 
     public function execute(bool $now = false): void
     {
         $this->save();
 
-        if ($this->hasCustomAction()) {
-            unserialize($this->action)->handle($this);
+        try {
+            if ($this->hasCustomAction()) {
+                unserialize($this->action)->handle($this);
 
-            $this->markAsSent();
+                $this->markAsSent();
 
-            static::garbageResolver()->handle($this);
-        } else {
-            if ($now) {
-                dispatch_sync(new SendMailJob($this));
+                static::garbageResolver()->handle($this);
             } else {
-                dispatch(new SendMailJob($this));
+                if ($now) {
+                    dispatch_sync(new SendMailJob($this));
+                } else {
+                    dispatch(new SendMailJob($this));
+                }
             }
+        } catch (Exception|Throwable) {
         }
     }
 

tests/Feature/AfterConstraintTest.php

@@ -58,7 +58,24 @@ public function test_past_target_with_after_now_passed_after_constraint_hourly_b
 
         $scheduler->save();
 
-        $this->travel(3)->hours();
+        $this->travel(1)->hours();
+
+        $can = app(
+            AfterConstraint::class
+        )->canSend(
+            $scheduler,
+            $scheduler->logs
+        );
+
+        self::assertTrue(
+            $scheduler->fresh()->isFutureAction()
+        );
+
+        self::assertTrue(
+            $can
+        );
+
+        $this->travel(1)->hours();
 
         $can = app(
             AfterConstraint::class

tests/Feature/Console/MailatorScheduleCommandTest.php

@@ -0,0 +1,44 @@
+<?php
+
+namespace Binarcode\LaravelMailator\Tests\Feature\Console;
+
+use Binarcode\LaravelMailator\Console\Commands\MailatorSchedulerCommand;
+use Binarcode\LaravelMailator\Models\MailatorSchedule;
+use Binarcode\LaravelMailator\Tests\Fixtures\Actions\NoopAction;
+use Binarcode\LaravelMailator\Tests\Fixtures\Constraints\FailingConstraint;
+use Binarcode\LaravelMailator\Tests\Fixtures\Constraints\TrueConstraint;
+use Binarcode\LaravelMailator\Tests\Fixtures\CustomAction;
+use Binarcode\LaravelMailator\Tests\Fixtures\User;
+use Binarcode\LaravelMailator\Tests\TestCase;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+class MailatorScheduleCommandTest extends TestCase
+{
+    use RefreshDatabase;
+
+    public function test_failing_during_run_dont_stop_execution(): void
+    {
+        MailatorSchedule::init('A')
+            ->constraint(new FailingConstraint)
+            ->actionClass(new NoopAction)
+            ->save();
+
+        MailatorSchedule::init('B')
+            ->constraint(new TrueConstraint)
+            ->actionClass(new CustomAction(
+                    $user = User::factory()->create([
+                        'email_verified_at' => null,
+                    ])
+                )
+            )
+            ->save();
+
+
+        $this->artisan(
+            MailatorSchedulerCommand::class
+        );
+
+        self::assertTrue($user->fresh()->hasVerifiedEmail());
+
+    }
+}

tests/Fixtures/Actions/NoopAction.php

@@ -0,0 +1,14 @@
+<?php
+
+namespace Binarcode\LaravelMailator\Tests\Fixtures\Actions;
+
+use Binarcode\LaravelMailator\Actions\Action;
+use Binarcode\LaravelMailator\Models\MailatorSchedule;
+
+class NoopAction implements Action
+{
+    public function handle(MailatorSchedule $schedule)
+    {
+        //
+    }
+}

tests/Fixtures/Constraints/FailingConstraint.php

@@ -0,0 +1,15 @@
+<?php
+
+namespace Binarcode\LaravelMailator\Tests\Fixtures\Constraints;
+
+use Binarcode\LaravelMailator\Constraints\SendScheduleConstraint;
+use Binarcode\LaravelMailator\Models\MailatorSchedule;
+use Illuminate\Support\Collection;
+
+class FailingConstraint implements SendScheduleConstraint
+{
+    public function canSend(MailatorSchedule $schedule, Collection $logs): bool
+    {
+        abort(403, 'Some failing.');
+    }
+}

tests/Fixtures/Constraints/TrueConstraint.php

@@ -0,0 +1,15 @@
+<?php
+
+namespace Binarcode\LaravelMailator\Tests\Fixtures\Constraints;
+
+use Binarcode\LaravelMailator\Constraints\SendScheduleConstraint;
+use Binarcode\LaravelMailator\Models\MailatorSchedule;
+use Illuminate\Support\Collection;
+
+class TrueConstraint implements SendScheduleConstraint
+{
+    public function canSend(MailatorSchedule $schedule, Collection $logs): bool
+    {
+        return true;
+    }
+}