Not required value for default filters

Author: binaryk

src/Services/Search/RepositorySearchService.php

@@ -201,11 +201,14 @@ protected function applyFilters(RestifyRequest $request, Repository $repository,
                         return false;
                     }
 
-                    if ($matchingFilter->invalidPayloadValue($request, $filter['value'])) {
+                    if (array_key_exists('value', $filter) && $matchingFilter->invalidPayloadValue($request, $filter['value'])) {
                         return false;
                     }
 
-                    $matchingFilter->resolve($request, $filter['value']);
+                    $matchingFilter->resolve(
+                        $request,
+                        array_key_exists('value', $filter) ? $filter['value'] : null
+                    );
 
                     return $matchingFilter;
                 })

tests/Controllers/RepositoryFilterControllerTest.php

@@ -4,6 +4,7 @@
 
 use Binaryk\LaravelRestify\Tests\Fixtures\Post\ActiveBooleanFilter;
 use Binaryk\LaravelRestify\Tests\Fixtures\Post\CreatedAfterDateFilter;
+use Binaryk\LaravelRestify\Tests\Fixtures\Post\InactiveFilter;
 use Binaryk\LaravelRestify\Tests\Fixtures\Post\Post;
 use Binaryk\LaravelRestify\Tests\Fixtures\Post\SelectCategoryFilter;
 use Binaryk\LaravelRestify\Tests\Fixtures\User\UserRepository;
@@ -17,7 +18,26 @@ public function test_can_get_available_filters()
             ->withoutExceptionHandling()
             ->getJson('restify-api/posts/filters');
 
-        $this->assertCount(3, $response->json('data'));
+        $this->assertCount(4, $response->json('data'));
+    }
+
+    public function test_value_filter_doesnt_require_value()
+    {
+        factory(Post::class)->create(['is_active' => false]);
+        factory(Post::class)->create(['is_active' => true]);
+
+        $filters = base64_encode(json_encode([
+            [
+                'class' => InactiveFilter::class,
+            ],
+        ]));
+
+        $response = $this
+            ->withoutExceptionHandling()
+            ->getJson('restify-api/posts?filters='.$filters)
+            ->assertStatus(200);
+
+        $this->assertCount(1, $response->json('data'));
     }
 
     public function test_the_boolean_filter_is_applied()

tests/Fixtures/Post/InactiveFilter.php

@@ -0,0 +1,14 @@
+<?php
+
+namespace Binaryk\LaravelRestify\Tests\Fixtures\Post;
+
+use Binaryk\LaravelRestify\Filter;
+use Binaryk\LaravelRestify\Http\Requests\RestifyRequest;
+
+class InactiveFilter extends Filter
+{
+    public function filter(RestifyRequest $request, $query, $value)
+    {
+        $query->where('is_active', false);
+    }
+}

tests/Fixtures/Post/PostRepository.php

@@ -80,6 +80,7 @@ public function filters(RestifyRequest $request)
             ActiveBooleanFilter::new()->canSee(fn () => true),
             SelectCategoryFilter::new(),
             CreatedAfterDateFilter::new(),
+            InactiveFilter::new(),
         ];
     }