fix(Search): Correctly search for strings with quotes and double quotes

Author: arthurkirkosa

src/Filters/SearchableFilter.php

@@ -44,7 +44,7 @@ public function filter(RestifyRequest $request, $query, $value)
         if (! config('restify.search.case_sensitive')) {
             $upper = strtoupper($value);
 
-            return $query->orWhereRaw("UPPER({$this->column}) LIKE \"%{$upper}%\"");
+            return $query->orWhereRaw("UPPER({$this->column}) LIKE ?", ['%'.$upper.'%']);
         }
 
         return $query->orWhere($this->column, $likeOperator, "%{$value}%");

src/Services/Search/RepositorySearchService.php

@@ -244,6 +244,6 @@ protected function applyGroupBy(RestifyRequest $request, Repository $repository,
 
     public static function make(): static
     {
-        return new static;
+        return new static();
     }
 }

tests/Feature/RepositorySearchServiceTest.php

@@ -125,6 +125,51 @@ public function test_can_search_using_belongs_to_field_with_custom_foreign_key()
             ->assertJsonCount(2, 'data');
     }
 
+    public function test_can_search_strings_with_quotes_and_double_quotes(): void
+    {
+        Post::factory()->create([
+            'title' => "A Guy Named O'Neal was Standing at 5 o'clock with a 10\" cookie.",
+        ]);
+
+        $this->getJson(PostRepository::route(query: ['search' => 'John']))
+            ->assertJsonCount(0, 'data');
+
+        $this->getJson(PostRepository::route(query: ['search' => 'Guy']))
+            ->assertJsonCount(1, 'data');
+
+        $this->getJson(PostRepository::route(query: ['search' => "5 o'clock"]))
+            ->assertJsonCount(1, 'data');
+
+        $this->getJson(PostRepository::route(query: ['search' => '10" present']))
+            ->assertJsonCount(0, 'data');
+
+        $this->getJson(PostRepository::route(query: ['search' => '10" cookie']))
+            ->assertJsonCount(1, 'data');
+
+        $this->getJson(PostRepository::route(query: ['search' => '150TPL5 (1 1/2" PVC SCH40 THREADED PLUG']))
+            ->assertJsonCount(0, 'data');
+
+        config()->set('restify.search.case_sensitive', false);
+
+        $this->getJson(PostRepository::route(query: ['search' => 'John']))
+            ->assertJsonCount(0, 'data');
+
+        $this->getJson(PostRepository::route(query: ['search' => 'Guy']))
+            ->assertJsonCount(1, 'data');
+
+        $this->getJson(PostRepository::route(query: ['search' => "5 o'clock"]))
+            ->assertJsonCount(1, 'data');
+
+        $this->getJson(PostRepository::route(query: ['search' => '10" present']))
+            ->assertJsonCount(0, 'data');
+
+        $this->getJson(PostRepository::route(query: ['search' => '10" cookie']))
+            ->assertJsonCount(1, 'data');
+
+        $this->getJson(PostRepository::route(query: ['search' => '150TPL5 (1 1/2" PVC SCH40 THREADED PLUG']))
+            ->assertJsonCount(0, 'data');
+    }
+
     public function test_can_match_closure(): void
     {
         User::factory(4)->create();