fix(Matches): Correctly match Booleans: GET converts them to 0 and 1

Author: arthurkirkosa

src/Filters/MatchFilter.php

@@ -46,7 +46,7 @@ public function filter(RestifyRequest $request, Builder|Relation $query, $value)
                     break;
                 case RestifySearchable::MATCH_BOOL:
                 case 'boolean':
-                    if ($value === 'false') {
+                    if ($value === 'false' || $value === '0') {
                         $query->where(function ($query) use ($field) {
                             if ($this->negation) {
                                 return $query->where($field, true);

tests/Feature/Filters/MatchFilterTest.php

@@ -4,6 +4,7 @@
 
 use Binaryk\LaravelRestify\Contracts\RestifySearchable;
 use Binaryk\LaravelRestify\Filters\MatchFilter;
+use Binaryk\LaravelRestify\Tests\Fixtures\Post\Post;
 use Binaryk\LaravelRestify\Tests\Fixtures\Post\PostRepository;
 use Binaryk\LaravelRestify\Tests\Fixtures\User\User;
 use Binaryk\LaravelRestify\Tests\Fixtures\User\UserRepository;
@@ -16,8 +17,7 @@ class MatchFilterTest extends IntegrationTestCase
 {
     public function test_matchable_filter_has_key(): void
     {
-        $filter = new class extends MatchFilter
-        {
+        $filter = new class () extends MatchFilter {
             public ?string $column = 'approved_at';
         };
 
@@ -175,6 +175,26 @@ public function test_can_match_date(): void
         $this->getJson(UserRepository::route(query: ['created_at' => '2020-12-01']))->assertJsonCount(3, 'data');
     }
 
+    public function test_can_match_boolean(): void
+    {
+        PostRepository::$match = [
+            'is_active' => 'boolean',
+        ];
+
+        Post::factory(2)->sequence(
+            ['is_active' => true, 'title' => 'Active post 1'],
+            ['is_active' => false, 'title' => 'Inactive post 2'],
+        )->create();
+
+        $this->getJson(PostRepository::route())->assertJsonCount(2, 'data');
+
+        $this->getJson(PostRepository::route(query: ['is_active' => true]))
+            ->assertJsonCount(1, 'data');
+
+        $this->getJson(PostRepository::route(query: ['is_active' => false]))
+            ->assertJsonCount(1, 'data');
+    }
+
     public function test_can_match_datetime_interval(): void
     {
         User::factory()->state([

tests/Fixtures/Post/PostRepository.php

@@ -27,6 +27,7 @@ class PostRepository extends Repository
 
     public static array $match = [
         'title' => RestifySearchable::MATCH_TEXT,
+        'is_active' => RestifySearchable::MATCH_BOOL,
     ];
 
     public static array $middleware = [];
@@ -50,6 +51,8 @@ public function fields(RestifyRequest $request): array
             field('description')->storingRules('required')->messages([
                 'required' => 'Description field is required',
             ]),
+
+            field('is_active'),
         ];
     }
 
@@ -121,7 +124,7 @@ public function actions(RestifyRequest $request): array
                 ->canSee(function (ActionRequest $request) {
                     return $_SERVER['actions.posts.invalidate'] ?? true;
                 }),
-            new PublishInvokablePostAction,
+            new PublishInvokablePostAction(),
         ];
     }
 
@@ -131,8 +134,8 @@ public function getters(RestifyRequest $request): array
             PostsIndexGetter::make(),
             PostsShowGetter::make()->onlyOnShow(),
             UnauthenticatedActionGetter::make()->withoutMiddleware(AuthorizeRestify::class),
-            new PostsShowInvokableGetter,
-            new PostsIndexInvokableGetter,
+            new PostsShowInvokableGetter(),
+            new PostsIndexInvokableGetter(),
         ];
     }
 }