Adapt unit test

Author: binaryk

src/Repositories/Crudable.php

@@ -157,7 +157,7 @@ public function destroy(RestifyRequest $request, $repositoryId)
      * @param array $payload
      * @return mixed
      */
-    public function allowToUpdate(RestifyRequest $request, $payload = [])
+    public function allowToUpdate(RestifyRequest $request, $payload = null)
     {
         $this->authorizeToUpdate($request);
 
@@ -171,9 +171,9 @@ public function allowToUpdate(RestifyRequest $request, $payload = [])
      * @param array $payload
      * @return mixed
      */
-    public function allowToStore(RestifyRequest $request, $payload = [])
+    public function allowToStore(RestifyRequest $request, $payload = null)
     {
-        self::authorizeToCreate($request);
+        self::authorizeToStore($request);
 
         $validator = self::validatorForStoring($request, $payload);
 

src/Repositories/ResponseResolver.php

@@ -59,7 +59,7 @@ public function resolveDetailsMeta($request)
     {
         return [
             'authorizedToShow' => $this->authorizedToShow($request),
-            'authorizedToCreate' => $this->authorizedToCreate($request),
+            'authorizedToStore' => $this->authorizedToStore($request),
             'authorizedToUpdate' => $this->authorizedToUpdate($request),
             'authorizedToDelete' => $this->authorizedToDelete($request),
         ];

src/Traits/AuthorizableModels.php

@@ -92,30 +92,30 @@ public function authorizedToShow(Request $request)
     }
 
     /**
-     * Determine if the current user can create new repositories or throw an exception.
+     * Determine if the current user can store new repositories or throw an exception.
      *
      * @param \Illuminate\Http\Request $request
      * @return void
      *
      * @throws \Illuminate\Auth\Access\AuthorizationException
      */
-    public static function authorizeToCreate(Request $request)
+    public static function authorizeToStore(Request $request)
     {
-        if (! static::authorizedToCreate($request)) {
-            throw new AuthorizationException('Unauthorized to create.');
+        if (! static::authorizedToStore($request)) {
+            throw new AuthorizationException('Unauthorized to store.');
         }
     }
 
     /**
-     * Determine if the current user can create new repositories.
+     * Determine if the current user can store new repositories.
      *
      * @param \Illuminate\Http\Request $request
      * @return bool
      */
-    public static function authorizedToCreate(Request $request)
+    public static function authorizedToStore(Request $request)
     {
         if (static::authorizable()) {
-            return Gate::check('create', static::$model);
+            return Gate::check('store', static::$model);
         }
 
         return true;

tests/Controllers/RepositoryIndexControllerTest.php

@@ -74,10 +74,9 @@ public function users()
     public function test_search_query_works()
     {
         $users = $this->mockUsers(10, ['[email protected]']);
-        $request = Mockery::mock(RestifyRequest::class);
         $model = $users->where('email', '[email protected]')->first(); //find manually the model
         $repository = Restify::repositoryForModel(get_class($model));
-        $expected = $repository::resolveWith($model)->toArray(request());
+        $expected = $repository::resolveWith($model)->toArray(resolve(RestifyRequest::class));
         unset($expected['relationships']);
 
         $r = $this->withExceptionHandling()
@@ -171,6 +170,10 @@ public function test_that_match_param_works()
             ->andReturnFalse();
         $request->shouldReceive('get')
             ->andReturnFalse();
+        $request->shouldReceive('isDetailRequest')
+            ->andReturnFalse();
+        $request->shouldReceive('isIndexRequest')
+            ->andReturnTrue();
 
         $model = $users->where('email', '[email protected]')->first();
         $repository = Restify::repositoryForModel(get_class($model));
@@ -210,6 +213,10 @@ public function test_that_with_param_works()
             ->andReturnTrue();
         $request->shouldReceive('get')
             ->andReturn('posts');
+        $request->shouldReceive('isDetailRequest')
+            ->andReturnFalse();
+        $request->shouldReceive('isIndexRequest')
+            ->andReturnTrue();
 
         $r = $this->withExceptionHandling()
             ->getJson('/restify-api/users?with=posts')

tests/Controllers/RepositoryStoreControllerTest.php

@@ -37,21 +37,21 @@ public function test_basic_validation_works()
 
     public function test_unauthorized_store()
     {
-        $_SERVER['restify.user.creatable'] = false;
+        $_SERVER['restify.post.creatable'] = false;
 
         Gate::policy(Post::class, PostPolicy::class);
 
         $this->withExceptionHandling()->post('/restify-api/posts', [
             'title' => 'Title',
             'description' => 'Title',
         ])->assertStatus(403)
-            ->assertJson(['errors' => ['Unauthorized to create.']]);
+            ->assertJson(['errors' => ['Unauthorized to store.']]);
     }
 
     public function test_success_storing()
     {
         $user = $this->mockUsers()->first();
-        $r = json_decode($this->withExceptionHandling()->post('/restify-api/posts', [
+        $r = json_decode($this->withoutExceptionHandling()->post('/restify-api/posts', [
             'user_id' => $user->id,
             'title' => 'Some post title',
             'description' => 'A very short description',

tests/Factories/BookFactory.php

@@ -0,0 +1,24 @@
+<?php
+
+use Faker\Generator as Faker;
+
+/*
+|--------------------------------------------------------------------------
+| Model Factories
+|--------------------------------------------------------------------------
+|
+| This directory should contain each of the model factory definitions for
+| your application. Factories provide a convenient way to generate new
+| model instances for testing / seeding your application's database.
+|
+*/
+
+$factory->define(Binaryk\LaravelRestify\Tests\Fixtures\Book::class, function (Faker $faker) {
+    return [
+        'title' => $faker->text(30),
+        'description' => $faker->text,
+        'author' => $faker->name,
+        'price' => $faker->randomFloat(),
+        'stock' => $faker->numberBetween(0, 100),
+    ];
+});

tests/FieldResolversTest.php

@@ -0,0 +1,42 @@
+<?php
+
+namespace Binaryk\LaravelRestify\Tests;
+
+use Binaryk\LaravelRestify\Fields\Field;
+use Binaryk\LaravelRestify\Tests\Fixtures\Book;
+use Binaryk\LaravelRestify\Tests\Fixtures\BookRepository;
+
+/**
+ * @package Binaryk\LaravelRestify\Tests;
+ * @author Eduard Lupacescu <[email protected]>
+ */
+class FieldResolversTest extends IntegrationTest
+{
+    public function test_show_callback_change_details_value()
+    {
+        tap($this->basicField(), function (Field $field) {
+            $book = factory(Book::class)->create();
+            $repository = $this->basicRepository();
+            $repository->resource = $book;
+
+            $field->showCallback(function ($value, $repo) use ($book, $repository) {
+                $this->assertInstanceOf(get_class($repository), $repo);
+                $this->assertSame($value, $book->title); //assert that the value is read from the database
+                return 'something else';
+            });
+
+            $this->assertSame($field->resolveForShow($repository), 'something else');
+        });
+    }
+
+    public function basicField()
+    {
+        return Field::make('title');
+    }
+
+    public function basicRepository()
+    {
+        return new class extends BookRepository {
+        };
+    }
+}

tests/Fixtures/Book.php

@@ -0,0 +1,24 @@
+<?php
+
+namespace Binaryk\LaravelRestify\Tests\Fixtures;
+
+use Binaryk\LaravelRestify\Contracts\RestifySearchable;
+use Binaryk\LaravelRestify\Traits\InteractWithSearch;
+use Illuminate\Database\Eloquent\Model;
+
+/**
+ * @author Eduard Lupacescu <[email protected]>
+ */
+class Book extends Model implements RestifySearchable
+{
+    use InteractWithSearch;
+
+    protected $fillable = [
+        'id',
+        'title',
+        'description',
+        'author',
+        'price',
+        'stock',
+    ];
+}

tests/Fixtures/BookPolicy.php

@@ -0,0 +1,49 @@
+<?php
+
+namespace Binaryk\LaravelRestify\Tests\Fixtures;
+
+/**
+ * @author Eduard Lupacescu <[email protected]>
+ */
+class BookPolicy
+{
+    /**
+     * Determine if the given user can view resources.
+     */
+    public function viewAny($user)
+    {
+        return $_SERVER['restify.book.viewAnyable'] ?? true;
+    }
+
+    /**
+     * Determine if users can be created.
+     */
+    public function store($user)
+    {
+        return $_SERVER['restify.book.storable'] ?? true;
+    }
+
+    /**
+     * Determine if books can be updated.
+     */
+    public function update($user, $book)
+    {
+        return $_SERVER['restify.book.updateable'] ?? true;
+    }
+
+    /**
+     * Determine if book can be shown
+     */
+    public function show($user, $book)
+    {
+        return $_SERVER['restify.book.showable'] ?? true;
+    }
+
+    /**
+     * Determine if books can be deleted
+     */
+    public function destroy($user)
+    {
+        return $_SERVER['restify.book.destroyable'] ?? true;
+    }
+}

tests/Fixtures/BookRepository.php

@@ -0,0 +1,38 @@
+<?php
+
+namespace Binaryk\LaravelRestify\Tests\Fixtures;
+
+use Binaryk\LaravelRestify\Fields\Field;
+use Binaryk\LaravelRestify\Http\Requests\RestifyRequest;
+use Binaryk\LaravelRestify\Repositories\Repository;
+
+/**
+ * @author Eduard Lupacescu <[email protected]>
+ */
+class BookRepository extends Repository
+{
+    public static $model = Book::class;
+
+    /**
+     * Get the URI key for the resource.
+     *
+     * @return string
+     */
+    public static function uriKey()
+    {
+        return 'books';
+    }
+
+    /**
+     * @param  RestifyRequest  $request
+     * @return array
+     */
+    public function fields(RestifyRequest $request)
+    {
+        return [
+            Field::make('title')->storingRules('required')->messages([
+                'required' => 'This field is required',
+            ]),
+        ];
+    }
+}