Skip to content

Handle edge cases in trace defintion if frames held less than frames_per_toc_entry frames #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 14, 2025
Merged

Handle edge cases in trace defintion if frames held less than frames_per_toc_entry frames #28

merged 3 commits into from
Aug 14, 2025

Conversation

Rot127
Copy link
Contributor

@Rot127 Rot127 commented Jul 2, 2025 •
edited
Loading

The TOC defintion was lagging the edge case of an TOC entry holding less than the required frames per entry (usually 64).

This handles the case by:

  • Adding the missing ceil operation in the trace reader
  • Adding a more detailed description of the trace in the README.

@Rot127 Rot127 marked this pull request as draft July 6, 2025 18:28
@Rot127
Copy link
Contributor Author

Rot127 commented Jul 7, 2025

I think the padding elements are not worth it.
Too much refactoring for not enough gain.

Will remove them again.

@Rot127 Rot127 marked this pull request as ready for review July 7, 2025 19:15
@Rot127 Rot127 mentioned this pull request Jul 17, 2025
Open
1 task
@Rot127 Rot127 merged commit 7587868 into master Aug 14, 2025
@Rot127 Rot127 deleted the tcg-plugin branch August 14, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@notxvilka notxvilka notxvilka approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rot127 @notxvilka