Commit b637902
committed
makes bap-extra packages optional to facilitate local development
Eases local dune-base developement, so that you can easily start local
development without too much external dependencies hassle. Allows you
to disable bap-extra packages and just do `dune build` and everything
should work.
For the context, Dune doesn't provide nice options for multi-project
monorepos. The dune files represent the static information about the
project and it is presumed that there is an external tool that
generates them. Cf., tezos manifest that generates dune files from the
OCaml EDSL or whatever they use in Janestreet (jenga?). Originally,
the plan was to implement the same mechanism, e.g., generate the
dune-project file during the configuration phase. But right now I
don't have enough time for that, so I am pushing a simple
workaround. All packages in bap-extra are now marked as allow_empty,
indicating that they can produce now artifacts. Their corresponding
libraries are now optional (if a dependency is not met, then the
library is silently not built). The only special case is ghidra that
doesn't have dependencies trackable by Dune (i.e., OCaml libraries,
besides base and bap), so to prevent it from building I added a small
check that ghidra library is installed.1 parent 0ff8147 commit b637902
6 files changed
+22
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
74 | | - | |
75 | 74 | | |
76 | 75 | | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
77 | 83 | | |
78 | 84 | | |
79 | 85 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
565 | 565 | | |
566 | 566 | | |
567 | 567 | | |
| 568 | + | |
568 | 569 | | |
569 | 570 | | |
570 | 571 | | |
| |||
996 | 997 | | |
997 | 998 | | |
998 | 999 | | |
| 1000 | + | |
999 | 1001 | | |
1000 | 1002 | | |
1001 | 1003 | | |
| |||
1096 | 1098 | | |
1097 | 1099 | | |
1098 | 1100 | | |
| 1101 | + | |
1099 | 1102 | | |
1100 | 1103 | | |
1101 | 1104 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
1 | 4 | | |
2 | 5 | | |
3 | 6 | | |
| |||
12 | 15 | | |
13 | 16 | | |
14 | 17 | | |
15 | | - | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
2 | 3 | | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
| 8 | + | |
7 | 9 | | |
8 | 10 | | |
9 | 11 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
2 | 3 | | |
3 | 4 | | |
4 | 5 | | |
| |||
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
| 20 | + | |
19 | 21 | | |
20 | 22 | | |
21 | 23 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
2 | 3 | | |
3 | 4 | | |
4 | 5 | | |
| |||
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
| 21 | + | |
20 | 22 | | |
21 | 23 | | |
22 | 24 | | |
| |||
0 commit comments